mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-21 10:33:27 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
85 lines
3 KiB
Rust
85 lines
3 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_then;
|
|
use clippy_utils::source::snippet_opt;
|
|
use if_chain::if_chain;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir::{BinOpKind, Expr, ExprKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_middle::ty;
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for uses of bitwise and/or operators between booleans, where performance may be improved by using
|
|
/// a lazy and.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// The bitwise operators do not support short-circuiting, so it may hinder code performance.
|
|
/// Additionally, boolean logic "masked" as bitwise logic is not caught by lints like `unnecessary_fold`
|
|
///
|
|
/// ### Known problems
|
|
/// This lint evaluates only when the right side is determined to have no side effects. At this time, that
|
|
/// determination is quite conservative.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// let (x,y) = (true, false);
|
|
/// if x & !y {} // where both x and y are booleans
|
|
/// ```
|
|
/// Use instead:
|
|
/// ```rust
|
|
/// let (x,y) = (true, false);
|
|
/// if x && !y {}
|
|
/// ```
|
|
#[clippy::version = "1.54.0"]
|
|
pub NEEDLESS_BITWISE_BOOL,
|
|
pedantic,
|
|
"Boolean expressions that use bitwise rather than lazy operators"
|
|
}
|
|
|
|
declare_lint_pass!(NeedlessBitwiseBool => [NEEDLESS_BITWISE_BOOL]);
|
|
|
|
fn is_bitwise_operation(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
|
|
let ty = cx.typeck_results().expr_ty(expr);
|
|
if_chain! {
|
|
if !expr.span.from_expansion();
|
|
if let (&ExprKind::Binary(ref op, _, right), &ty::Bool) = (&expr.kind, &ty.kind());
|
|
if op.node == BinOpKind::BitAnd || op.node == BinOpKind::BitOr;
|
|
if let ExprKind::Call(..) | ExprKind::MethodCall(..) | ExprKind::Binary(..) | ExprKind::Unary(..) = right.kind;
|
|
if !right.can_have_side_effects();
|
|
then {
|
|
return true;
|
|
}
|
|
}
|
|
false
|
|
}
|
|
|
|
fn suggession_snippet(cx: &LateContext<'_>, expr: &Expr<'_>) -> Option<String> {
|
|
if let ExprKind::Binary(ref op, left, right) = expr.kind {
|
|
if let (Some(l_snippet), Some(r_snippet)) = (snippet_opt(cx, left.span), snippet_opt(cx, right.span)) {
|
|
let op_snippet = match op.node {
|
|
BinOpKind::BitAnd => "&&",
|
|
_ => "||",
|
|
};
|
|
return Some(format!("{} {} {}", l_snippet, op_snippet, r_snippet));
|
|
}
|
|
}
|
|
None
|
|
}
|
|
|
|
impl LateLintPass<'_> for NeedlessBitwiseBool {
|
|
fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) {
|
|
if is_bitwise_operation(cx, expr) {
|
|
span_lint_and_then(
|
|
cx,
|
|
NEEDLESS_BITWISE_BOOL,
|
|
expr.span,
|
|
"use of bitwise operator instead of lazy operator between booleans",
|
|
|diag| {
|
|
if let Some(sugg) = suggession_snippet(cx, expr) {
|
|
diag.span_suggestion(expr.span, "try", sugg, Applicability::MachineApplicable);
|
|
}
|
|
},
|
|
);
|
|
}
|
|
}
|
|
}
|