mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-30 06:53:27 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
90 lines
3.2 KiB
Rust
90 lines
3.2 KiB
Rust
use clippy_utils::diagnostics::span_lint;
|
|
use rustc_hir::{BorrowKind, Expr, ExprKind, Mutability};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_middle::ty::subst::Subst;
|
|
use rustc_middle::ty::{self, Ty};
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use std::iter;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Detects passing a mutable reference to a function that only
|
|
/// requires an immutable reference.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// The mutable reference rules out all other references to
|
|
/// the value. Also the code misleads about the intent of the call site.
|
|
///
|
|
/// ### Example
|
|
/// ```ignore
|
|
/// // Bad
|
|
/// my_vec.push(&mut value)
|
|
///
|
|
/// // Good
|
|
/// my_vec.push(&value)
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub UNNECESSARY_MUT_PASSED,
|
|
style,
|
|
"an argument passed as a mutable reference although the callee only demands an immutable reference"
|
|
}
|
|
|
|
declare_lint_pass!(UnnecessaryMutPassed => [UNNECESSARY_MUT_PASSED]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for UnnecessaryMutPassed {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
|
|
match e.kind {
|
|
ExprKind::Call(fn_expr, arguments) => {
|
|
if let ExprKind::Path(ref path) = fn_expr.kind {
|
|
check_arguments(
|
|
cx,
|
|
arguments,
|
|
cx.typeck_results().expr_ty(fn_expr),
|
|
&rustc_hir_pretty::to_string(rustc_hir_pretty::NO_ANN, |s| s.print_qpath(path, false)),
|
|
"function",
|
|
);
|
|
}
|
|
},
|
|
ExprKind::MethodCall(path, _, arguments, _) => {
|
|
let def_id = cx.typeck_results().type_dependent_def_id(e.hir_id).unwrap();
|
|
let substs = cx.typeck_results().node_substs(e.hir_id);
|
|
let method_type = cx.tcx.type_of(def_id).subst(cx.tcx, substs);
|
|
check_arguments(cx, arguments, method_type, &path.ident.as_str(), "method");
|
|
},
|
|
_ => (),
|
|
}
|
|
}
|
|
}
|
|
|
|
fn check_arguments<'tcx>(
|
|
cx: &LateContext<'tcx>,
|
|
arguments: &[Expr<'_>],
|
|
type_definition: Ty<'tcx>,
|
|
name: &str,
|
|
fn_kind: &str,
|
|
) {
|
|
match type_definition.kind() {
|
|
ty::FnDef(..) | ty::FnPtr(_) => {
|
|
let parameters = type_definition.fn_sig(cx.tcx).skip_binder().inputs();
|
|
for (argument, parameter) in iter::zip(arguments, parameters) {
|
|
match parameter.kind() {
|
|
ty::Ref(_, _, Mutability::Not)
|
|
| ty::RawPtr(ty::TypeAndMut {
|
|
mutbl: Mutability::Not, ..
|
|
}) => {
|
|
if let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Mut, _) = argument.kind {
|
|
span_lint(
|
|
cx,
|
|
UNNECESSARY_MUT_PASSED,
|
|
argument.span,
|
|
&format!("the {} `{}` doesn't need a mutable reference", fn_kind, name),
|
|
);
|
|
}
|
|
},
|
|
_ => (),
|
|
}
|
|
}
|
|
},
|
|
_ => (),
|
|
}
|
|
}
|