mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-21 10:33:27 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
72 lines
2 KiB
Rust
72 lines
2 KiB
Rust
//! Lint on if expressions with an else if, but without a final else branch.
|
|
|
|
use clippy_utils::diagnostics::span_lint_and_help;
|
|
use rustc_ast::ast::{Expr, ExprKind};
|
|
use rustc_lint::{EarlyContext, EarlyLintPass};
|
|
use rustc_middle::lint::in_external_macro;
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for usage of if expressions with an `else if` branch,
|
|
/// but without a final `else` branch.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Some coding guidelines require this (e.g., MISRA-C:2004 Rule 14.10).
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// # fn a() {}
|
|
/// # fn b() {}
|
|
/// # let x: i32 = 1;
|
|
/// if x.is_positive() {
|
|
/// a();
|
|
/// } else if x.is_negative() {
|
|
/// b();
|
|
/// }
|
|
/// ```
|
|
///
|
|
/// Could be written:
|
|
///
|
|
/// ```rust
|
|
/// # fn a() {}
|
|
/// # fn b() {}
|
|
/// # let x: i32 = 1;
|
|
/// if x.is_positive() {
|
|
/// a();
|
|
/// } else if x.is_negative() {
|
|
/// b();
|
|
/// } else {
|
|
/// // We don't care about zero.
|
|
/// }
|
|
/// ```
|
|
#[clippy::version = "pre 1.29.0"]
|
|
pub ELSE_IF_WITHOUT_ELSE,
|
|
restriction,
|
|
"`if` expression with an `else if`, but without a final `else` branch"
|
|
}
|
|
|
|
declare_lint_pass!(ElseIfWithoutElse => [ELSE_IF_WITHOUT_ELSE]);
|
|
|
|
impl EarlyLintPass for ElseIfWithoutElse {
|
|
fn check_expr(&mut self, cx: &EarlyContext<'_>, mut item: &Expr) {
|
|
if in_external_macro(cx.sess, item.span) {
|
|
return;
|
|
}
|
|
|
|
while let ExprKind::If(_, _, Some(ref els)) = item.kind {
|
|
if let ExprKind::If(_, _, None) = els.kind {
|
|
span_lint_and_help(
|
|
cx,
|
|
ELSE_IF_WITHOUT_ELSE,
|
|
els.span,
|
|
"`if` expression with an `else if`, but without a final `else`",
|
|
None,
|
|
"add an `else` block here",
|
|
);
|
|
}
|
|
|
|
item = els;
|
|
}
|
|
}
|
|
}
|