mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-26 14:40:32 +00:00
209 lines
5.4 KiB
Text
209 lines
5.4 KiB
Text
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:7:5
|
|
|
|
|
LL | for n in x {
|
|
| ^ - help: try: `x.into_iter().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | if let Some(y) = n {
|
|
LL | | println!("{}", y);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> tests/ui/manual_flatten.rs:9:9
|
|
|
|
|
LL | / if let Some(y) = n {
|
|
LL | | println!("{}", y);
|
|
LL | | }
|
|
| |_________^
|
|
= note: `-D clippy::manual-flatten` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::manual_flatten)]`
|
|
|
|
error: unnecessary `if let` since only the `Ok` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:16:5
|
|
|
|
|
LL | for n in y.clone() {
|
|
| ^ --------- help: try: `y.clone().into_iter().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | };
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> tests/ui/manual_flatten.rs:18:9
|
|
|
|
|
LL | / if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | };
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Ok` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:24:5
|
|
|
|
|
LL | for n in &y {
|
|
| ^ -- help: try: `y.iter().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> tests/ui/manual_flatten.rs:26:9
|
|
|
|
|
LL | / if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Ok` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:33:5
|
|
|
|
|
LL | for n in z {
|
|
| ^ - help: try: `z.iter().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> tests/ui/manual_flatten.rs:35:9
|
|
|
|
|
LL | / if let Ok(n) = n {
|
|
LL | | println!("{}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:43:5
|
|
|
|
|
LL | for n in z {
|
|
| ^ - help: try: `z.flatten()`
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | if let Some(m) = n {
|
|
LL | | println!("{}", m);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> tests/ui/manual_flatten.rs:45:9
|
|
|
|
|
LL | / if let Some(m) = n {
|
|
LL | | println!("{}", m);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:77:5
|
|
|
|
|
LL | for n in &vec_of_ref {
|
|
| ^ ----------- help: try: `vec_of_ref.iter().copied().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> tests/ui/manual_flatten.rs:79:9
|
|
|
|
|
LL | / if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:85:5
|
|
|
|
|
LL | for n in vec_of_ref {
|
|
| ^ ---------- help: try: `vec_of_ref.iter().copied().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> tests/ui/manual_flatten.rs:87:9
|
|
|
|
|
LL | / if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:93:5
|
|
|
|
|
LL | for n in slice_of_ref {
|
|
| ^ ------------ help: try: `slice_of_ref.iter().copied().flatten()`
|
|
| _____|
|
|
| |
|
|
LL | |
|
|
LL | | if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: ...and remove the `if let` statement in the for loop
|
|
--> tests/ui/manual_flatten.rs:95:9
|
|
|
|
|
LL | / if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
| |_________^
|
|
|
|
error: unnecessary `if let` since only the `Some` variant of the iterator element is used
|
|
--> tests/ui/manual_flatten.rs:124:5
|
|
|
|
|
LL | / for n in vec![
|
|
LL | |
|
|
LL | | Some(1),
|
|
LL | | Some(2),
|
|
... |
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
help: remove the `if let` statement in the for loop and then...
|
|
--> tests/ui/manual_flatten.rs:130:9
|
|
|
|
|
LL | / if let Some(n) = n {
|
|
LL | | println!("{:?}", n);
|
|
LL | | }
|
|
| |_________^
|
|
help: try
|
|
|
|
|
LL ~ for n in vec![
|
|
LL +
|
|
LL + Some(1),
|
|
LL + Some(2),
|
|
LL + Some(3)
|
|
LL ~ ].iter().flatten() {
|
|
|
|
|
|
|
error: aborting due to 9 previous errors
|
|
|