mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
eb3970285b
In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones changelog: none
154 lines
5.9 KiB
Text
154 lines
5.9 KiB
Text
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:15:12
|
|
|
|
|
LL | if let Ok(_) = &result {}
|
|
| -------^^^^^---------- help: try this: `if result.is_ok()`
|
|
|
|
|
= note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:17:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<i32, i32>(42) {}
|
|
| -------^^^^^--------------------- help: try this: `if Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:19:12
|
|
|
|
|
LL | if let Err(_) = Err::<i32, i32>(42) {}
|
|
| -------^^^^^^---------------------- help: try this: `if Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:21:15
|
|
|
|
|
LL | while let Ok(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^--------------------- help: try this: `while Ok::<i32, i32>(10).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:23:15
|
|
|
|
|
LL | while let Err(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^^--------------------- help: try this: `while Ok::<i32, i32>(10).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:33:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try this: `Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:38:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `Ok::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:43:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:48:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try this: `Err::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:53:20
|
|
|
|
|
LL | let _ = if let Ok(_) = Ok::<usize, ()>(4) { true } else { false };
|
|
| -------^^^^^--------------------- help: try this: `if Ok::<usize, ()>(4).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:59:20
|
|
|
|
|
LL | let _ = if let Ok(_) = gen_res() {
|
|
| -------^^^^^------------ help: try this: `if gen_res().is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:61:19
|
|
|
|
|
LL | } else if let Err(_) = gen_res() {
|
|
| -------^^^^^^------------ help: try this: `if gen_res().is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:84:19
|
|
|
|
|
LL | while let Some(_) = r#try!(result_opt()) {}
|
|
| ----------^^^^^^^----------------------- help: try this: `while (r#try!(result_opt())).is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:85:16
|
|
|
|
|
LL | if let Some(_) = r#try!(result_opt()) {}
|
|
| -------^^^^^^^----------------------- help: try this: `if (r#try!(result_opt())).is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:91:12
|
|
|
|
|
LL | if let Some(_) = m!() {}
|
|
| -------^^^^^^^------- help: try this: `if m!().is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:92:15
|
|
|
|
|
LL | while let Some(_) = m!() {}
|
|
| ----------^^^^^^^------- help: try this: `while m!().is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:110:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<i32, i32>(42) {}
|
|
| -------^^^^^--------------------- help: try this: `if Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:112:12
|
|
|
|
|
LL | if let Err(_) = Err::<i32, i32>(42) {}
|
|
| -------^^^^^^---------------------- help: try this: `if Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:114:15
|
|
|
|
|
LL | while let Ok(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^--------------------- help: try this: `while Ok::<i32, i32>(10).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:116:15
|
|
|
|
|
LL | while let Err(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^^--------------------- help: try this: `while Ok::<i32, i32>(10).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:118:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try this: `Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:123:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try this: `Err::<i32, i32>(42).is_err()`
|
|
|
|
error: aborting due to 22 previous errors
|
|
|