mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-18 00:53:31 +00:00
38d4ac7cea
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
59 lines
1.7 KiB
Text
59 lines
1.7 KiB
Text
error: This else block is redundant.
|
|
|
|
--> $DIR/needless_continue.rs:27:16
|
|
|
|
|
LL | } else {
|
|
| ________________^
|
|
LL | | continue;
|
|
LL | | }
|
|
| |_________^
|
|
|
|
|
= note: `-D clippy::needless-continue` implied by `-D warnings`
|
|
= help: Consider dropping the else clause and merging the code that follows (in the loop) with the if block, like so:
|
|
if i % 2 == 0 && i % 3 == 0 {
|
|
println!("{}", i);
|
|
println!("{}", i + 1);
|
|
if i % 5 == 0 {
|
|
println!("{}", i + 2);
|
|
}
|
|
let i = 0;
|
|
println!("bar {} ", i);
|
|
// Merged code follows...println!("bleh");
|
|
{
|
|
println!("blah");
|
|
}
|
|
if !(!(i == 2) || !(i == 5)) {
|
|
println!("lama");
|
|
}
|
|
if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
continue;
|
|
} else {
|
|
println!("Blabber");
|
|
println!("Jabber");
|
|
}
|
|
println!("bleh");
|
|
}
|
|
|
|
|
|
error: There is no need for an explicit `else` block for this `if` expression
|
|
|
|
--> $DIR/needless_continue.rs:42:9
|
|
|
|
|
LL | / if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
LL | | continue;
|
|
LL | | } else {
|
|
LL | | println!("Blabber");
|
|
LL | | println!("Jabber");
|
|
LL | | }
|
|
| |_________^
|
|
|
|
|
= help: Consider dropping the else clause, and moving out the code in the else block, like so:
|
|
if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
continue;
|
|
}
|
|
println!("Blabber");
|
|
println!("Jabber");
|
|
...
|
|
|
|
error: aborting due to 2 previous errors
|
|
|