mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
51e2d6a4a9
Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown This is an attempt to fix suggestions one part of which is 6 lines or more far from the first. I've noticed "the problem" (of not showing some parts of the suggestion) here: https://github.com/rust-lang/rust/pull/97759#discussion_r889689230. I'm not sure about the implementation (this big closure is just bad and makes already complicated code even more so), but I want to at least discuss the result. Here is an example of how this changes the output: Before: ```text help: consider enclosing expression in a block | 3 ~ 'l: { match () { () => break 'l, 4 | 5 | 6 | 7 | 8 | ... ``` After: ```text help: consider enclosing expression in a block | 3 ~ 'l: { match () { () => break 'l, 4 | ... 31| 32~ } }; | ``` r? `@estebank` `@rustbot` label +A-diagnostics +A-suggestion-diagnostics |
||
|---|---|---|
| .. | ||
| false_positives.rs | ||
| shared_at_bottom.rs | ||
| shared_at_bottom.stderr | ||
| shared_at_top.rs | ||
| shared_at_top.stderr | ||
| shared_at_top_and_bottom.rs | ||
| shared_at_top_and_bottom.stderr | ||
| valid_if_blocks.rs | ||
| valid_if_blocks.stderr | ||