mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-30 06:53:27 +00:00
eb3970285b
In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones changelog: none
187 lines
4 KiB
Text
187 lines
4 KiB
Text
error: passing a unit value to a function
|
|
--> $DIR/unit_arg.rs:62:5
|
|
|
|
|
LL | / foo({
|
|
LL | | 1;
|
|
LL | | });
|
|
| |______^
|
|
|
|
|
= note: `-D clippy::unit-arg` implied by `-D warnings`
|
|
help: remove the semicolon from the last statement in the block
|
|
|
|
|
LL | 1
|
|
|
|
|
help: or move the expression in front of the call and replace it with the unit literal `()`
|
|
|
|
|
LL ~ {
|
|
LL + 1;
|
|
LL + };
|
|
LL ~ foo(());
|
|
|
|
|
|
|
error: passing a unit value to a function
|
|
--> $DIR/unit_arg.rs:65:5
|
|
|
|
|
LL | foo(foo(1));
|
|
| ^^^^^^^^^^^
|
|
|
|
|
help: move the expression in front of the call and replace it with the unit literal `()`
|
|
|
|
|
LL ~ foo(1);
|
|
LL ~ foo(());
|
|
|
|
|
|
|
error: passing a unit value to a function
|
|
--> $DIR/unit_arg.rs:66:5
|
|
|
|
|
LL | / foo({
|
|
LL | | foo(1);
|
|
LL | | foo(2);
|
|
LL | | });
|
|
| |______^
|
|
|
|
|
help: remove the semicolon from the last statement in the block
|
|
|
|
|
LL | foo(2)
|
|
|
|
|
help: or move the expression in front of the call and replace it with the unit literal `()`
|
|
|
|
|
LL ~ {
|
|
LL + foo(1);
|
|
LL + foo(2);
|
|
LL + };
|
|
LL ~ foo(());
|
|
|
|
|
|
|
error: passing a unit value to a function
|
|
--> $DIR/unit_arg.rs:71:5
|
|
|
|
|
LL | / b.bar({
|
|
LL | | 1;
|
|
LL | | });
|
|
| |______^
|
|
|
|
|
help: remove the semicolon from the last statement in the block
|
|
|
|
|
LL | 1
|
|
|
|
|
help: or move the expression in front of the call and replace it with the unit literal `()`
|
|
|
|
|
LL ~ {
|
|
LL + 1;
|
|
LL + };
|
|
LL ~ b.bar(());
|
|
|
|
|
|
|
error: passing unit values to a function
|
|
--> $DIR/unit_arg.rs:74:5
|
|
|
|
|
LL | taking_multiple_units(foo(0), foo(1));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: move the expressions in front of the call and replace them with the unit literal `()`
|
|
|
|
|
LL ~ foo(0);
|
|
LL + foo(1);
|
|
LL ~ taking_multiple_units((), ());
|
|
|
|
|
|
|
error: passing unit values to a function
|
|
--> $DIR/unit_arg.rs:75:5
|
|
|
|
|
LL | / taking_multiple_units(foo(0), {
|
|
LL | | foo(1);
|
|
LL | | foo(2);
|
|
LL | | });
|
|
| |______^
|
|
|
|
|
help: remove the semicolon from the last statement in the block
|
|
|
|
|
LL | foo(2)
|
|
|
|
|
help: or move the expressions in front of the call and replace them with the unit literal `()`
|
|
|
|
|
LL ~ foo(0);
|
|
LL + {
|
|
LL + foo(1);
|
|
LL + foo(2);
|
|
LL + };
|
|
LL ~ taking_multiple_units((), ());
|
|
|
|
|
|
|
error: passing unit values to a function
|
|
--> $DIR/unit_arg.rs:79:5
|
|
|
|
|
LL | / taking_multiple_units(
|
|
LL | | {
|
|
LL | | foo(0);
|
|
LL | | foo(1);
|
|
... |
|
|
LL | | },
|
|
LL | | );
|
|
| |_____^
|
|
|
|
|
help: remove the semicolon from the last statement in the block
|
|
|
|
|
LL | foo(1)
|
|
|
|
|
help: remove the semicolon from the last statement in the block
|
|
|
|
|
LL | foo(3)
|
|
|
|
|
help: or move the expressions in front of the call and replace them with the unit literal `()`
|
|
|
|
|
LL ~ {
|
|
LL + foo(0);
|
|
LL + foo(1);
|
|
LL + };
|
|
LL + {
|
|
LL + foo(2);
|
|
LL + foo(3);
|
|
LL + };
|
|
LL + taking_multiple_units(
|
|
LL + (),
|
|
LL + (),
|
|
LL ~ );
|
|
|
|
|
|
|
error: passing a unit value to a function
|
|
--> $DIR/unit_arg.rs:90:13
|
|
|
|
|
LL | None.or(Some(foo(2)));
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
help: move the expression in front of the call and replace it with the unit literal `()`
|
|
|
|
|
LL ~ None.or({
|
|
LL + foo(2);
|
|
LL + Some(())
|
|
LL ~ });
|
|
|
|
|
|
|
error: passing a unit value to a function
|
|
--> $DIR/unit_arg.rs:93:5
|
|
|
|
|
LL | foo(foo(()));
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
help: move the expression in front of the call and replace it with the unit literal `()`
|
|
|
|
|
LL ~ foo(());
|
|
LL ~ foo(());
|
|
|
|
|
|
|
error: passing a unit value to a function
|
|
--> $DIR/unit_arg.rs:130:5
|
|
|
|
|
LL | Some(foo(1))
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
help: move the expression in front of the call and replace it with the unit literal `()`
|
|
|
|
|
LL ~ foo(1);
|
|
LL + Some(())
|
|
|
|
|
|
|
error: aborting due to 10 previous errors
|
|
|