mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-21 10:33:27 +00:00
f743fec6b0
Clippy had a false positive for with `ifs_same_cond` when two
if-let expressions have an `option_env!` macro. The fix is similar to the
`env!` macro fix.
The following example had a clippy error:
```rust
if let Some(env1) = option_env!("ENV1") {
// ...
} else if let Some(env2) = option_env!("ENV2") {
// ...
}
```
See https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=01b85c61b56ddd900117fb247af04824
changelog: Fix [`ifs_same_cond`] false positive when using `option_env!` in if-let expressions.
51 lines
1.1 KiB
Text
51 lines
1.1 KiB
Text
error: this `if` has the same condition as a previous `if`
|
|
--> $DIR/ifs_same_cond.rs:14:15
|
|
|
|
|
LL | } else if b {
|
|
| ^
|
|
|
|
|
note: same as this
|
|
--> $DIR/ifs_same_cond.rs:13:8
|
|
|
|
|
LL | if b {
|
|
| ^
|
|
= note: `-D clippy::ifs-same-cond` implied by `-D warnings`
|
|
|
|
error: this `if` has the same condition as a previous `if`
|
|
--> $DIR/ifs_same_cond.rs:19:15
|
|
|
|
|
LL | } else if a == 1 {
|
|
| ^^^^^^
|
|
|
|
|
note: same as this
|
|
--> $DIR/ifs_same_cond.rs:18:8
|
|
|
|
|
LL | if a == 1 {
|
|
| ^^^^^^
|
|
|
|
error: this `if` has the same condition as a previous `if`
|
|
--> $DIR/ifs_same_cond.rs:25:15
|
|
|
|
|
LL | } else if 2 * a == 1 {
|
|
| ^^^^^^^^^^
|
|
|
|
|
note: same as this
|
|
--> $DIR/ifs_same_cond.rs:23:8
|
|
|
|
|
LL | if 2 * a == 1 {
|
|
| ^^^^^^^^^^
|
|
|
|
error: this `if` has the same condition as a previous `if`
|
|
--> $DIR/ifs_same_cond.rs:58:15
|
|
|
|
|
LL | } else if a.contains("ah") {
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
|
note: same as this
|
|
--> $DIR/ifs_same_cond.rs:57:8
|
|
|
|
|
LL | if a.contains("ah") {
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
error: aborting due to 4 previous errors
|
|
|