mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-30 15:03:36 +00:00
bf2e63104d
Fix `cmp_owned` on copy types fixes #8803 fixes #7365 changelog: Don't lint `cmp_owned` on `From::from` for copy types
75 lines
1.3 KiB
Rust
75 lines
1.3 KiB
Rust
#[allow(clippy::unnecessary_operation)]
|
|
#[allow(clippy::implicit_clone)]
|
|
|
|
fn main() {
|
|
let x = &Baz;
|
|
let y = &Baz;
|
|
y.to_owned() == *x;
|
|
|
|
let x = &&Baz;
|
|
let y = &Baz;
|
|
y.to_owned() == **x;
|
|
|
|
let x = 0u32;
|
|
let y = U32Wrapper(x);
|
|
let _ = U32Wrapper::from(x) == y;
|
|
}
|
|
|
|
struct Foo;
|
|
|
|
impl PartialEq for Foo {
|
|
fn eq(&self, other: &Self) -> bool {
|
|
self.to_owned() == *other
|
|
}
|
|
}
|
|
|
|
impl ToOwned for Foo {
|
|
type Owned = Bar;
|
|
fn to_owned(&self) -> Bar {
|
|
Bar
|
|
}
|
|
}
|
|
|
|
#[derive(PartialEq, Eq)]
|
|
struct Baz;
|
|
|
|
impl ToOwned for Baz {
|
|
type Owned = Baz;
|
|
fn to_owned(&self) -> Baz {
|
|
Baz
|
|
}
|
|
}
|
|
|
|
#[derive(PartialEq, Eq)]
|
|
struct Bar;
|
|
|
|
impl PartialEq<Foo> for Bar {
|
|
fn eq(&self, _: &Foo) -> bool {
|
|
true
|
|
}
|
|
}
|
|
|
|
impl std::borrow::Borrow<Foo> for Bar {
|
|
fn borrow(&self) -> &Foo {
|
|
static FOO: Foo = Foo;
|
|
&FOO
|
|
}
|
|
}
|
|
|
|
#[derive(Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
|
|
struct U32Wrapper(u32);
|
|
impl From<u32> for U32Wrapper {
|
|
fn from(x: u32) -> Self {
|
|
Self(x)
|
|
}
|
|
}
|
|
impl PartialEq<u32> for U32Wrapper {
|
|
fn eq(&self, other: &u32) -> bool {
|
|
self.0 == *other
|
|
}
|
|
}
|
|
impl PartialEq<U32Wrapper> for u32 {
|
|
fn eq(&self, other: &U32Wrapper) -> bool {
|
|
*self == other.0
|
|
}
|
|
}
|