mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
d10296910f
Fixes issue where ranges containing ints with different signs would be incorrect due to comparing as unsigned.
57 lines
1.3 KiB
Rust
57 lines
1.3 KiB
Rust
// run-rustfix
|
|
|
|
#[warn(clippy::manual_range_contains)]
|
|
#[allow(unused)]
|
|
#[allow(clippy::no_effect)]
|
|
#[allow(clippy::short_circuit_statement)]
|
|
#[allow(clippy::unnecessary_operation)]
|
|
fn main() {
|
|
let x = 9_i32;
|
|
|
|
// order shouldn't matter
|
|
(8..12).contains(&x);
|
|
(21..42).contains(&x);
|
|
(1..100).contains(&x);
|
|
|
|
// also with inclusive ranges
|
|
(9..=99).contains(&x);
|
|
(1..=33).contains(&x);
|
|
(1..=999).contains(&x);
|
|
|
|
// and the outside
|
|
!(8..12).contains(&x);
|
|
!(21..42).contains(&x);
|
|
!(1..100).contains(&x);
|
|
|
|
// also with the outside of inclusive ranges
|
|
!(9..=99).contains(&x);
|
|
!(1..=33).contains(&x);
|
|
!(1..=999).contains(&x);
|
|
|
|
// not a range.contains
|
|
x > 8 && x < 12; // lower bound not inclusive
|
|
x < 8 && x <= 12; // same direction
|
|
x >= 12 && 12 >= x; // same bounds
|
|
x < 8 && x > 12; // wrong direction
|
|
|
|
x <= 8 || x >= 12;
|
|
x >= 8 || x >= 12;
|
|
x < 12 || 12 < x;
|
|
x >= 8 || x <= 12;
|
|
|
|
// Fix #6315
|
|
let y = 3.;
|
|
(0. ..1.).contains(&y);
|
|
!(0. ..=1.).contains(&y);
|
|
|
|
// handle negatives #8721
|
|
(-10..=10).contains(&x);
|
|
x >= 10 && x <= -10;
|
|
(-3. ..=3.).contains(&y);
|
|
y >= 3. && y <= -3.;
|
|
}
|
|
|
|
// Fix #6373
|
|
pub const fn in_range(a: i32) -> bool {
|
|
3 <= a && a <= 20
|
|
}
|