mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-15 01:17:16 +00:00
203 lines
7.3 KiB
Text
203 lines
7.3 KiB
Text
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:15:12
|
|
|
|
|
LL | if let Ok(_) = &result {}
|
|
| -------^^^^^---------- help: try: `if result.is_ok()`
|
|
|
|
|
= note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::redundant_pattern_matching)]`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:17:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<i32, i32>(42) {}
|
|
| -------^^^^^--------------------- help: try: `if Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:19:12
|
|
|
|
|
LL | if let Err(_) = Err::<i32, i32>(42) {}
|
|
| -------^^^^^^---------------------- help: try: `if Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:21:15
|
|
|
|
|
LL | while let Ok(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^--------------------- help: try: `while Ok::<i32, i32>(10).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:23:15
|
|
|
|
|
LL | while let Err(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^^--------------------- help: try: `while Ok::<i32, i32>(10).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:33:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try: `Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:38:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try: `Ok::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:43:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try: `Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:48:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try: `Err::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:53:20
|
|
|
|
|
LL | let _ = if let Ok(_) = Ok::<usize, ()>(4) { true } else { false };
|
|
| -------^^^^^--------------------- help: try: `if Ok::<usize, ()>(4).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:61:20
|
|
|
|
|
LL | let _ = if let Ok(_) = gen_res() {
|
|
| -------^^^^^------------ help: try: `if gen_res().is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:63:19
|
|
|
|
|
LL | } else if let Err(_) = gen_res() {
|
|
| -------^^^^^^------------ help: try: `if gen_res().is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:86:19
|
|
|
|
|
LL | while let Some(_) = r#try!(result_opt()) {}
|
|
| ----------^^^^^^^----------------------- help: try: `while r#try!(result_opt()).is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:87:16
|
|
|
|
|
LL | if let Some(_) = r#try!(result_opt()) {}
|
|
| -------^^^^^^^----------------------- help: try: `if r#try!(result_opt()).is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:93:12
|
|
|
|
|
LL | if let Some(_) = m!() {}
|
|
| -------^^^^^^^------- help: try: `if m!().is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_some()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:94:15
|
|
|
|
|
LL | while let Some(_) = m!() {}
|
|
| ----------^^^^^^^------- help: try: `while m!().is_some()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:112:12
|
|
|
|
|
LL | if let Ok(_) = Ok::<i32, i32>(42) {}
|
|
| -------^^^^^--------------------- help: try: `if Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:114:12
|
|
|
|
|
LL | if let Err(_) = Err::<i32, i32>(42) {}
|
|
| -------^^^^^^---------------------- help: try: `if Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:116:15
|
|
|
|
|
LL | while let Ok(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^--------------------- help: try: `while Ok::<i32, i32>(10).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:118:15
|
|
|
|
|
LL | while let Err(_) = Ok::<i32, i32>(10) {}
|
|
| ----------^^^^^^--------------------- help: try: `while Ok::<i32, i32>(10).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:120:5
|
|
|
|
|
LL | / match Ok::<i32, i32>(42) {
|
|
LL | | Ok(_) => true,
|
|
LL | | Err(_) => false,
|
|
LL | | };
|
|
| |_____^ help: try: `Ok::<i32, i32>(42).is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:125:5
|
|
|
|
|
LL | / match Err::<i32, i32>(42) {
|
|
LL | | Ok(_) => false,
|
|
LL | | Err(_) => true,
|
|
LL | | };
|
|
| |_____^ help: try: `Err::<i32, i32>(42).is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:135:5
|
|
|
|
|
LL | / match x {
|
|
LL | | Ok(_) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_____^ help: try: `x.is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:140:5
|
|
|
|
|
LL | / match x {
|
|
LL | | Ok(_) => false,
|
|
LL | | _ => true,
|
|
LL | | };
|
|
| |_____^ help: try: `x.is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:145:5
|
|
|
|
|
LL | / match x {
|
|
LL | | Err(_) => true,
|
|
LL | | _ => false,
|
|
LL | | };
|
|
| |_____^ help: try: `x.is_err()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:150:5
|
|
|
|
|
LL | / match x {
|
|
LL | | Err(_) => false,
|
|
LL | | _ => true,
|
|
LL | | };
|
|
| |_____^ help: try: `x.is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_ok()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:171:13
|
|
|
|
|
LL | let _ = matches!(x, Ok(_));
|
|
| ^^^^^^^^^^^^^^^^^^ help: try: `x.is_ok()`
|
|
|
|
error: redundant pattern matching, consider using `is_err()`
|
|
--> $DIR/redundant_pattern_matching_result.rs:173:13
|
|
|
|
|
LL | let _ = matches!(x, Err(_));
|
|
| ^^^^^^^^^^^^^^^^^^^ help: try: `x.is_err()`
|
|
|
|
error: aborting due to 28 previous errors
|
|
|