mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 15:14:29 +00:00
264 lines
13 KiB
Text
264 lines
13 KiB
Text
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:9:19
|
|
|
|
|
LL | let _ = (0..).find(|n| to_opt(*n).is_some()).map(|a| to_opt(a).unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|a| to_opt(a))`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:9:28
|
|
|
|
|
LL | let _ = (0..).find(|n| to_opt(*n).is_some()).map(|a| to_opt(a).unwrap());
|
|
| ^^^^^^^^^^
|
|
= note: `-D clippy::manual-find-map` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::manual_find_map)]`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:12:19
|
|
|
|
|
LL | let _ = (0..).find(|&n| to_opt(n).is_some()).map(|a| to_opt(a).expect("hi"));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|a| to_opt(a))`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:12:29
|
|
|
|
|
LL | let _ = (0..).find(|&n| to_opt(n).is_some()).map(|a| to_opt(a).expect("hi"));
|
|
| ^^^^^^^^^
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:15:19
|
|
|
|
|
LL | let _ = (0..).find(|&n| to_res(n).is_ok()).map(|a| to_res(a).unwrap_or(1));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|a| to_res(a).ok())`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:15:29
|
|
|
|
|
LL | let _ = (0..).find(|&n| to_res(n).is_ok()).map(|a| to_res(a).unwrap_or(1));
|
|
| ^^^^^^^^^
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:18:10
|
|
|
|
|
LL | .find(|&x| to_ref(to_opt(x)).is_some())
|
|
| __________^
|
|
LL | | .map(|y| to_ref(to_opt(y)).unwrap());
|
|
| |____________________________________________^ help: try: `find_map(|y| *to_ref(to_opt(y)))`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:18:20
|
|
|
|
|
LL | .find(|&x| to_ref(to_opt(x)).is_some())
|
|
| ^^^^^^^^^^^^^^^^^
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:21:10
|
|
|
|
|
LL | .find(|x| to_ref(to_opt(*x)).is_some())
|
|
| __________^
|
|
LL | | .map(|y| to_ref(to_opt(y)).unwrap());
|
|
| |____________________________________________^ help: try: `find_map(|y| *to_ref(to_opt(y)))`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:21:19
|
|
|
|
|
LL | .find(|x| to_ref(to_opt(*x)).is_some())
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:25:10
|
|
|
|
|
LL | .find(|&x| to_ref(to_res(x)).is_ok())
|
|
| __________^
|
|
LL | | .map(|y| to_ref(to_res(y)).unwrap());
|
|
| |____________________________________________^ help: try: `find_map(|y| to_ref(to_res(y)).ok())`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:25:20
|
|
|
|
|
LL | .find(|&x| to_ref(to_res(x)).is_ok())
|
|
| ^^^^^^^^^^^^^^^^^
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:28:10
|
|
|
|
|
LL | .find(|x| to_ref(to_res(*x)).is_ok())
|
|
| __________^
|
|
LL | | .map(|y| to_ref(to_res(y)).unwrap());
|
|
| |____________________________________________^ help: try: `find_map(|y| to_ref(to_res(y)).ok())`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:28:19
|
|
|
|
|
LL | .find(|x| to_ref(to_res(*x)).is_ok())
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:34:26
|
|
|
|
|
LL | iter::<Option<u8>>().find(|x| x.is_some()).map(|x| x.unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x)`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:35:27
|
|
|
|
|
LL | iter::<&Option<u8>>().find(|x| x.is_some()).map(|x| x.unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| *x)`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:36:28
|
|
|
|
|
LL | iter::<&&Option<u8>>().find(|x| x.is_some()).map(|x| x.unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| **x)`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:37:27
|
|
|
|
|
LL | iter::<Option<&u8>>().find(|x| x.is_some()).map(|x| x.cloned().unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.cloned())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:38:28
|
|
|
|
|
LL | iter::<&Option<&u8>>().find(|x| x.is_some()).map(|x| x.cloned().unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.cloned())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:39:31
|
|
|
|
|
LL | iter::<&Option<String>>().find(|x| x.is_some()).map(|x| x.as_deref().unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.as_deref())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:40:31
|
|
|
|
|
LL | iter::<Option<&String>>().find(|&x| to_ref(x).is_some()).map(|y| to_ref(y).cloned().unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|y| to_ref(y).cloned())`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:40:41
|
|
|
|
|
LL | iter::<Option<&String>>().find(|&x| to_ref(x).is_some()).map(|y| to_ref(y).cloned().unwrap());
|
|
| ^^^^^^^^^
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:42:30
|
|
|
|
|
LL | iter::<Result<u8, ()>>().find(|x| x.is_ok()).map(|x| x.unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:43:31
|
|
|
|
|
LL | iter::<&Result<u8, ()>>().find(|x| x.is_ok()).map(|x| x.unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:44:32
|
|
|
|
|
LL | iter::<&&Result<u8, ()>>().find(|x| x.is_ok()).map(|x| x.unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:45:31
|
|
|
|
|
LL | iter::<Result<&u8, ()>>().find(|x| x.is_ok()).map(|x| x.cloned().unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.cloned().ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:46:32
|
|
|
|
|
LL | iter::<&Result<&u8, ()>>().find(|x| x.is_ok()).map(|x| x.cloned().unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.cloned().ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:47:35
|
|
|
|
|
LL | iter::<&Result<String, ()>>().find(|x| x.is_ok()).map(|x| x.as_deref().unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|x| x.as_deref().ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:48:35
|
|
|
|
|
LL | iter::<Result<&String, ()>>().find(|&x| to_ref(x).is_ok()).map(|y| to_ref(y).cloned().unwrap());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `find_map(|y| to_ref(y).cloned().ok())`
|
|
|
|
|
note: the suggestion might change the behavior of the program when merging `filter` and `map`, because this expression potentially contains side effects and will only execute once
|
|
--> tests/ui/manual_find_map.rs:48:45
|
|
|
|
|
LL | iter::<Result<&String, ()>>().find(|&x| to_ref(x).is_ok()).map(|y| to_ref(y).cloned().unwrap());
|
|
| ^^^^^^^^^
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:96:10
|
|
|
|
|
LL | .find(|f| f.option_field.is_some())
|
|
| __________^
|
|
LL | | .map(|f| f.option_field.clone().unwrap());
|
|
| |_________________________________________________^ help: try: `find_map(|f| f.option_field.clone())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:101:10
|
|
|
|
|
LL | .find(|f| f.ref_field.is_some())
|
|
| __________^
|
|
LL | | .map(|f| f.ref_field.cloned().unwrap());
|
|
| |_______________________________________________^ help: try: `find_map(|f| f.ref_field.cloned())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:106:10
|
|
|
|
|
LL | .find(|f| f.ref_field.is_some())
|
|
| __________^
|
|
LL | | .map(|f| f.ref_field.copied().unwrap());
|
|
| |_______________________________________________^ help: try: `find_map(|f| f.ref_field.copied())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:111:10
|
|
|
|
|
LL | .find(|f| f.result_field.is_ok())
|
|
| __________^
|
|
LL | | .map(|f| f.result_field.clone().unwrap());
|
|
| |_________________________________________________^ help: try: `find_map(|f| f.result_field.clone().ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:116:10
|
|
|
|
|
LL | .find(|f| f.result_field.is_ok())
|
|
| __________^
|
|
LL | | .map(|f| f.result_field.as_ref().unwrap());
|
|
| |__________________________________________________^ help: try: `find_map(|f| f.result_field.as_ref().ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:121:10
|
|
|
|
|
LL | .find(|f| f.result_field.is_ok())
|
|
| __________^
|
|
LL | | .map(|f| f.result_field.as_deref().unwrap());
|
|
| |____________________________________________________^ help: try: `find_map(|f| f.result_field.as_deref().ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:126:10
|
|
|
|
|
LL | .find(|f| f.result_field.is_ok())
|
|
| __________^
|
|
LL | | .map(|f| f.result_field.as_mut().unwrap());
|
|
| |__________________________________________________^ help: try: `find_map(|f| f.result_field.as_mut().ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:131:10
|
|
|
|
|
LL | .find(|f| f.result_field.is_ok())
|
|
| __________^
|
|
LL | | .map(|f| f.result_field.as_deref_mut().unwrap());
|
|
| |________________________________________________________^ help: try: `find_map(|f| f.result_field.as_deref_mut().ok())`
|
|
|
|
error: `find(..).map(..)` can be simplified as `find_map(..)`
|
|
--> tests/ui/manual_find_map.rs:136:10
|
|
|
|
|
LL | .find(|f| f.result_field.is_ok())
|
|
| __________^
|
|
LL | | .map(|f| f.result_field.to_owned().unwrap());
|
|
| |____________________________________________________^ help: try: `find_map(|f| f.result_field.to_owned().ok())`
|
|
|
|
error: aborting due to 30 previous errors
|
|
|