mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-23 21:23:56 +00:00
260 lines
5.4 KiB
Text
260 lines
5.4 KiB
Text
error: this if statement can be collapsed
|
|
--> $DIR/collapsible_if.rs:15:5
|
|
|
|
|
LL | / if x == "hello" {
|
|
LL | | if y == "world" {
|
|
LL | | println!("Hello world!");
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::collapsible-if` implied by `-D warnings`
|
|
help: try
|
|
|
|
|
LL | if x == "hello" && y == "world" {
|
|
LL | println!("Hello world!");
|
|
LL | }
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
|
--> $DIR/collapsible_if.rs:21:5
|
|
|
|
|
LL | / if x == "hello" || x == "world" {
|
|
LL | | if y == "world" || y == "hello" {
|
|
LL | | println!("Hello world!");
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | if (x == "hello" || x == "world") && (y == "world" || y == "hello") {
|
|
LL | println!("Hello world!");
|
|
LL | }
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
|
--> $DIR/collapsible_if.rs:27:5
|
|
|
|
|
LL | / if x == "hello" && x == "world" {
|
|
LL | | if y == "world" || y == "hello" {
|
|
LL | | println!("Hello world!");
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | if x == "hello" && x == "world" && (y == "world" || y == "hello") {
|
|
LL | println!("Hello world!");
|
|
LL | }
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
|
--> $DIR/collapsible_if.rs:33:5
|
|
|
|
|
LL | / if x == "hello" || x == "world" {
|
|
LL | | if y == "world" && y == "hello" {
|
|
LL | | println!("Hello world!");
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | if (x == "hello" || x == "world") && y == "world" && y == "hello" {
|
|
LL | println!("Hello world!");
|
|
LL | }
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
|
--> $DIR/collapsible_if.rs:39:5
|
|
|
|
|
LL | / if x == "hello" && x == "world" {
|
|
LL | | if y == "world" && y == "hello" {
|
|
LL | | println!("Hello world!");
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | if x == "hello" && x == "world" && y == "world" && y == "hello" {
|
|
LL | println!("Hello world!");
|
|
LL | }
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
|
--> $DIR/collapsible_if.rs:45:5
|
|
|
|
|
LL | / if 42 == 1337 {
|
|
LL | | if 'a' != 'A' {
|
|
LL | | println!("world!")
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | if 42 == 1337 && 'a' != 'A' {
|
|
LL | println!("world!")
|
|
LL | }
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
|
--> $DIR/collapsible_if.rs:54:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if y == "world" {
|
|
LL | | println!("world!")
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | } else if y == "world" {
|
|
LL | println!("world!")
|
|
LL | }
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
|
--> $DIR/collapsible_if.rs:62:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if let Some(42) = Some(42) {
|
|
LL | | println!("world!")
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | } else if let Some(42) = Some(42) {
|
|
LL | println!("world!")
|
|
LL | }
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
|
--> $DIR/collapsible_if.rs:70:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if y == "world" {
|
|
LL | | println!("world")
|
|
LL | | }
|
|
... |
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | } else if y == "world" {
|
|
LL | println!("world")
|
|
LL | }
|
|
LL | else {
|
|
LL | println!("!")
|
|
LL | }
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
|
--> $DIR/collapsible_if.rs:81:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if let Some(42) = Some(42) {
|
|
LL | | println!("world")
|
|
LL | | }
|
|
... |
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | } else if let Some(42) = Some(42) {
|
|
LL | println!("world")
|
|
LL | }
|
|
LL | else {
|
|
LL | println!("!")
|
|
LL | }
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
|
--> $DIR/collapsible_if.rs:92:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if let Some(42) = Some(42) {
|
|
LL | | println!("world")
|
|
LL | | }
|
|
... |
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | } else if let Some(42) = Some(42) {
|
|
LL | println!("world")
|
|
LL | }
|
|
LL | else {
|
|
LL | println!("!")
|
|
LL | }
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
|
--> $DIR/collapsible_if.rs:103:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if x == "hello" {
|
|
LL | | println!("world")
|
|
LL | | }
|
|
... |
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | } else if x == "hello" {
|
|
LL | println!("world")
|
|
LL | }
|
|
LL | else {
|
|
LL | println!("!")
|
|
LL | }
|
|
|
|
|
|
|
error: this `else { if .. }` block can be collapsed
|
|
--> $DIR/collapsible_if.rs:114:12
|
|
|
|
|
LL | } else {
|
|
| ____________^
|
|
LL | | if let Some(42) = Some(42) {
|
|
LL | | println!("world")
|
|
LL | | }
|
|
... |
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | } else if let Some(42) = Some(42) {
|
|
LL | println!("world")
|
|
LL | }
|
|
LL | else {
|
|
LL | println!("!")
|
|
LL | }
|
|
|
|
|
|
|
error: this if statement can be collapsed
|
|
--> $DIR/collapsible_if.rs:173:5
|
|
|
|
|
LL | / if x == "hello" {
|
|
LL | | if y == "world" { // Collapsible
|
|
LL | | println!("Hello world!");
|
|
LL | | }
|
|
LL | | }
|
|
| |_____^
|
|
help: try
|
|
|
|
|
LL | if x == "hello" && y == "world" { // Collapsible
|
|
LL | println!("Hello world!");
|
|
LL | }
|
|
|
|
|
|
|
error: aborting due to 14 previous errors
|
|
|