mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-30 16:39:26 +00:00
369 lines
13 KiB
Text
369 lines
13 KiB
Text
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:41:14
|
|
|
|
|
LL | for i in 0..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::needless-range-loop` implied by `-D warnings`
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in &vec {
|
|
| ^^^^^^ ^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:50:14
|
|
|
|
|
LL | for i in 0..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in &vec {
|
|
| ^^^^^^ ^^^^
|
|
|
|
error: the loop variable `j` is only used to index `STATIC`.
|
|
--> $DIR/for_loop.rs:55:14
|
|
|
|
|
LL | for j in 0..4 {
|
|
| ^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in &STATIC {
|
|
| ^^^^^^ ^^^^^^^
|
|
|
|
error: the loop variable `j` is only used to index `CONST`.
|
|
--> $DIR/for_loop.rs:59:14
|
|
|
|
|
LL | for j in 0..4 {
|
|
| ^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in &CONST {
|
|
| ^^^^^^ ^^^^^^
|
|
|
|
error: the loop variable `i` is used to index `vec`
|
|
--> $DIR/for_loop.rs:63:14
|
|
|
|
|
LL | for i in 0..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for (i, <item>) in vec.iter().enumerate() {
|
|
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec2`.
|
|
--> $DIR/for_loop.rs:71:14
|
|
|
|
|
LL | for i in 0..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in vec2.iter().take(vec.len()) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:75:14
|
|
|
|
|
LL | for i in 5..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in vec.iter().skip(5) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:79:14
|
|
|
|
|
LL | for i in 0..MAX_LEN {
|
|
| ^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in vec.iter().take(MAX_LEN) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:83:14
|
|
|
|
|
LL | for i in 0..=MAX_LEN {
|
|
| ^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in vec.iter().take(MAX_LEN + 1) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:87:14
|
|
|
|
|
LL | for i in 5..10 {
|
|
| ^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in vec.iter().take(10).skip(5) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is only used to index `vec`.
|
|
--> $DIR/for_loop.rs:91:14
|
|
|
|
|
LL | for i in 5..=10 {
|
|
| ^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for <item> in vec.iter().take(10 + 1).skip(5) {
|
|
| ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is used to index `vec`
|
|
--> $DIR/for_loop.rs:95:14
|
|
|
|
|
LL | for i in 5..vec.len() {
|
|
| ^^^^^^^^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for (i, <item>) in vec.iter().enumerate().skip(5) {
|
|
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: the loop variable `i` is used to index `vec`
|
|
--> $DIR/for_loop.rs:99:14
|
|
|
|
|
LL | for i in 5..10 {
|
|
| ^^^^^
|
|
help: consider using an iterator
|
|
|
|
|
LL | for (i, <item>) in vec.iter().enumerate().take(10).skip(5) {
|
|
| ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:103:14
|
|
|
|
|
LL | for i in 10..0 {
|
|
| ^^^^^
|
|
|
|
|
= note: `-D clippy::reverse-range-loop` implied by `-D warnings`
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
LL | for i in (0..10).rev() {
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:107:14
|
|
|
|
|
LL | for i in 10..=0 {
|
|
| ^^^^^^
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
LL | for i in (0...10).rev() {
|
|
| ^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:111:14
|
|
|
|
|
LL | for i in MAX_LEN..0 {
|
|
| ^^^^^^^^^^
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
LL | for i in (0..MAX_LEN).rev() {
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:115:14
|
|
|
|
|
LL | for i in 5..5 {
|
|
| ^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:140:14
|
|
|
|
|
LL | for i in 10..5 + 4 {
|
|
| ^^^^^^^^^
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
LL | for i in (5 + 4..10).rev() {
|
|
| ^^^^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:144:14
|
|
|
|
|
LL | for i in (5 + 2)..(3 - 1) {
|
|
| ^^^^^^^^^^^^^^^^
|
|
help: consider using the following if you are attempting to iterate over this range in reverse
|
|
|
|
|
LL | for i in ((3 - 1)..(5 + 2)).rev() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: this range is empty so this for loop will never run
|
|
--> $DIR/for_loop.rs:148:14
|
|
|
|
|
LL | for i in (5 + 2)..(8 - 1) {
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:170:15
|
|
|
|
|
LL | for _v in vec.iter() {}
|
|
| ^^^^^^^^^^ help: to write this more concisely, try: `&vec`
|
|
|
|
|
= note: `-D clippy::explicit-iter-loop` implied by `-D warnings`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:172:15
|
|
|
|
|
LL | for _v in vec.iter_mut() {}
|
|
| ^^^^^^^^^^^^^^ help: to write this more concisely, try: `&mut vec`
|
|
|
|
error: it is more concise to loop over containers instead of using explicit iteration methods`
|
|
--> $DIR/for_loop.rs:175:15
|
|
|
|
|
LL | for _v in out_vec.into_iter() {}
|
|
| ^^^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `out_vec`
|
|
|
|
|
= note: `-D clippy::explicit-into-iter-loop` implied by `-D warnings`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:178:15
|
|
|
|
|
LL | for _v in array.into_iter() {}
|
|
| ^^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&array`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:183:15
|
|
|
|
|
LL | for _v in [1, 2, 3].iter() {}
|
|
| ^^^^^^^^^^^^^^^^ help: to write this more concisely, try: `&[1, 2, 3]`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:187:15
|
|
|
|
|
LL | for _v in [0; 32].iter() {}
|
|
| ^^^^^^^^^^^^^^ help: to write this more concisely, try: `&[0; 32]`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:192:15
|
|
|
|
|
LL | for _v in ll.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&ll`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:195:15
|
|
|
|
|
LL | for _v in vd.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&vd`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:198:15
|
|
|
|
|
LL | for _v in bh.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&bh`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:201:15
|
|
|
|
|
LL | for _v in hm.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&hm`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:204:15
|
|
|
|
|
LL | for _v in bt.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&bt`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:207:15
|
|
|
|
|
LL | for _v in hs.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&hs`
|
|
|
|
error: it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
--> $DIR/for_loop.rs:210:15
|
|
|
|
|
LL | for _v in bs.iter() {}
|
|
| ^^^^^^^^^ help: to write this more concisely, try: `&bs`
|
|
|
|
error: you are iterating over `Iterator::next()` which is an Option; this will compile but is probably not what you want
|
|
--> $DIR/for_loop.rs:212:15
|
|
|
|
|
LL | for _v in vec.iter().next() {}
|
|
| ^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::iter-next-loop` implied by `-D warnings`
|
|
|
|
error: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator
|
|
--> $DIR/for_loop.rs:219:5
|
|
|
|
|
LL | vec.iter().cloned().map(|x| out.push(x)).collect::<Vec<_>>();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::unused-collect` implied by `-D warnings`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:363:14
|
|
|
|
|
LL | for i in 0..src.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[..])`
|
|
|
|
|
= note: `-D clippy::manual-memcpy` implied by `-D warnings`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:368:14
|
|
|
|
|
LL | for i in 0..src.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst[10..(src.len() + 10)].clone_from_slice(&src[..])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:373:14
|
|
|
|
|
LL | for i in 0..src.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[10..])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:378:14
|
|
|
|
|
LL | for i in 11..src.len() {
|
|
| ^^^^^^^^^^^^^ help: try replacing the loop by: `dst[11..src.len()].clone_from_slice(&src[(11 - 10)..(src.len() - 10)])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:383:14
|
|
|
|
|
LL | for i in 0..dst.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst.clone_from_slice(&src[..dst.len()])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:396:14
|
|
|
|
|
LL | for i in 10..256 {
|
|
| ^^^^^^^
|
|
help: try replacing the loop by
|
|
|
|
|
LL | for i in dst[10..256].clone_from_slice(&src[(10 - 5)..(256 - 5)])
|
|
LL | dst2[(10 + 500)..(256 + 500)].clone_from_slice(&src[10..256]) {
|
|
|
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:408:14
|
|
|
|
|
LL | for i in 10..LOOP_OFFSET {
|
|
| ^^^^^^^^^^^^^^^ help: try replacing the loop by: `dst[(10 + LOOP_OFFSET)..(LOOP_OFFSET + LOOP_OFFSET)].clone_from_slice(&src[(10 - some_var)..(LOOP_OFFSET - some_var)])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:421:14
|
|
|
|
|
LL | for i in 0..src_vec.len() {
|
|
| ^^^^^^^^^^^^^^^^ help: try replacing the loop by: `dst_vec[..src_vec.len()].clone_from_slice(&src_vec[..])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:450:14
|
|
|
|
|
LL | for i in from..from + src.len() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `dst[from..from + src.len()].clone_from_slice(&src[0..(from + src.len() - from)])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:454:14
|
|
|
|
|
LL | for i in from..from + 3 {
|
|
| ^^^^^^^^^^^^^^ help: try replacing the loop by: `dst[from..from + 3].clone_from_slice(&src[0..(from + 3 - from)])`
|
|
|
|
error: it looks like you're manually copying between slices
|
|
--> $DIR/for_loop.rs:461:14
|
|
|
|
|
LL | for i in 0..src.len() {
|
|
| ^^^^^^^^^^^^ help: try replacing the loop by: `dst[..src.len()].clone_from_slice(&src[..])`
|
|
|
|
error: aborting due to 46 previous errors
|
|
|