mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-01-02 08:19:11 +00:00
d647696c1f
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
66 lines
2.1 KiB
Rust
66 lines
2.1 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
use clippy_utils::source::snippet_opt;
|
|
use clippy_utils::ty::is_type_diagnostic_item;
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir::{Expr, ExprKind};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_middle::ty::TyS;
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
|
use rustc_span::symbol::sym;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for no-op uses of Option::{as_deref,as_deref_mut},
|
|
/// for example, `Option<&T>::as_deref()` returns the same type.
|
|
///
|
|
/// ### Why is this bad?
|
|
/// Redundant code and improving readability.
|
|
///
|
|
/// ### Example
|
|
/// ```rust
|
|
/// let a = Some(&1);
|
|
/// let b = a.as_deref(); // goes from Option<&i32> to Option<&i32>
|
|
/// ```
|
|
/// Could be written as:
|
|
/// ```rust
|
|
/// let a = Some(&1);
|
|
/// let b = a;
|
|
/// ```
|
|
#[clippy::version = "1.57.0"]
|
|
pub NEEDLESS_OPTION_AS_DEREF,
|
|
complexity,
|
|
"no-op use of `deref` or `deref_mut` method to `Option`."
|
|
}
|
|
|
|
declare_lint_pass!(OptionNeedlessDeref=> [
|
|
NEEDLESS_OPTION_AS_DEREF,
|
|
]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for OptionNeedlessDeref {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
if expr.span.from_expansion() {
|
|
return;
|
|
}
|
|
let typeck = cx.typeck_results();
|
|
let outer_ty = typeck.expr_ty(expr);
|
|
|
|
if_chain! {
|
|
if is_type_diagnostic_item(cx,outer_ty,sym::Option);
|
|
if let ExprKind::MethodCall(path, _, [sub_expr], _) = expr.kind;
|
|
let symbol = path.ident.as_str();
|
|
if symbol=="as_deref" || symbol=="as_deref_mut";
|
|
if TyS::same_type( outer_ty, typeck.expr_ty(sub_expr) );
|
|
then{
|
|
span_lint_and_sugg(
|
|
cx,
|
|
NEEDLESS_OPTION_AS_DEREF,
|
|
expr.span,
|
|
"derefed type is same as origin",
|
|
"try this",
|
|
snippet_opt(cx,sub_expr.span).unwrap(),
|
|
Applicability::MachineApplicable
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|