mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
52c4dc65d9
suggest `try_into` when casting to wildcard type; fix [`cast_possible_truncation`] suggesting useless parenthesis; remove suggesting for float to float conversion in [`cast_possible_truncation`] style nit
353 lines
11 KiB
Text
353 lines
11 KiB
Text
error: casting `i32` to `f32` causes a loss of precision (`i32` is 32 bits wide, but `f32`'s mantissa is only 23 bits wide)
|
|
--> $DIR/cast.rs:14:5
|
|
|
|
|
LL | x0 as f32;
|
|
| ^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::cast-precision-loss` implied by `-D warnings`
|
|
|
|
error: casting `i64` to `f32` causes a loss of precision (`i64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)
|
|
--> $DIR/cast.rs:16:5
|
|
|
|
|
LL | x1 as f32;
|
|
| ^^^^^^^^^
|
|
|
|
error: casting `i64` to `f64` causes a loss of precision (`i64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
|
|
--> $DIR/cast.rs:17:5
|
|
|
|
|
LL | x1 as f64;
|
|
| ^^^^^^^^^
|
|
|
|
error: casting `u32` to `f32` causes a loss of precision (`u32` is 32 bits wide, but `f32`'s mantissa is only 23 bits wide)
|
|
--> $DIR/cast.rs:19:5
|
|
|
|
|
LL | x2 as f32;
|
|
| ^^^^^^^^^
|
|
|
|
error: casting `u64` to `f32` causes a loss of precision (`u64` is 64 bits wide, but `f32`'s mantissa is only 23 bits wide)
|
|
--> $DIR/cast.rs:21:5
|
|
|
|
|
LL | x3 as f32;
|
|
| ^^^^^^^^^
|
|
|
|
error: casting `u64` to `f64` causes a loss of precision (`u64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
|
|
--> $DIR/cast.rs:22:5
|
|
|
|
|
LL | x3 as f64;
|
|
| ^^^^^^^^^
|
|
|
|
error: casting `f32` to `i32` may truncate the value
|
|
--> $DIR/cast.rs:24:5
|
|
|
|
|
LL | 1f32 as i32;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
= note: `-D clippy::cast-possible-truncation` implied by `-D warnings`
|
|
|
|
error: casting `f32` to `u32` may truncate the value
|
|
--> $DIR/cast.rs:25:5
|
|
|
|
|
LL | 1f32 as u32;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
|
|
error: casting `f32` to `u32` may lose the sign of the value
|
|
--> $DIR/cast.rs:25:5
|
|
|
|
|
LL | 1f32 as u32;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::cast-sign-loss` implied by `-D warnings`
|
|
|
|
error: casting `f64` to `f32` may truncate the value
|
|
--> $DIR/cast.rs:26:5
|
|
|
|
|
LL | 1f64 as f32;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
|
|
error: casting `i32` to `i8` may truncate the value
|
|
--> $DIR/cast.rs:27:5
|
|
|
|
|
LL | 1i32 as i8;
|
|
| ^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | i8::try_from(1i32);
|
|
| ~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `i32` to `u8` may truncate the value
|
|
--> $DIR/cast.rs:28:5
|
|
|
|
|
LL | 1i32 as u8;
|
|
| ^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | u8::try_from(1i32);
|
|
| ~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `f64` to `isize` may truncate the value
|
|
--> $DIR/cast.rs:29:5
|
|
|
|
|
LL | 1f64 as isize;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
|
|
error: casting `f64` to `usize` may truncate the value
|
|
--> $DIR/cast.rs:30:5
|
|
|
|
|
LL | 1f64 as usize;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
|
|
error: casting `f64` to `usize` may lose the sign of the value
|
|
--> $DIR/cast.rs:30:5
|
|
|
|
|
LL | 1f64 as usize;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: casting `u32` to `u16` may truncate the value
|
|
--> $DIR/cast.rs:31:5
|
|
|
|
|
LL | 1f32 as u32 as u16;
|
|
| ^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | u16::try_from(1f32 as u32);
|
|
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `f32` to `u32` may truncate the value
|
|
--> $DIR/cast.rs:31:5
|
|
|
|
|
LL | 1f32 as u32 as u16;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
|
|
error: casting `f32` to `u32` may lose the sign of the value
|
|
--> $DIR/cast.rs:31:5
|
|
|
|
|
LL | 1f32 as u32 as u16;
|
|
| ^^^^^^^^^^^
|
|
|
|
error: casting `i32` to `i8` may truncate the value
|
|
--> $DIR/cast.rs:33:22
|
|
|
|
|
LL | let _x: i8 = 1i32 as _;
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | let _x: i8 = 1i32.try_into();
|
|
| ~~~~~~~~~~~~~~~
|
|
|
|
error: casting `f32` to `i32` may truncate the value
|
|
--> $DIR/cast.rs:34:9
|
|
|
|
|
LL | 1f32 as i32;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
|
|
error: casting `f64` to `i32` may truncate the value
|
|
--> $DIR/cast.rs:35:9
|
|
|
|
|
LL | 1f64 as i32;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
|
|
error: casting `f32` to `u8` may truncate the value
|
|
--> $DIR/cast.rs:36:9
|
|
|
|
|
LL | 1f32 as u8;
|
|
| ^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
|
|
error: casting `f32` to `u8` may lose the sign of the value
|
|
--> $DIR/cast.rs:36:9
|
|
|
|
|
LL | 1f32 as u8;
|
|
| ^^^^^^^^^^
|
|
|
|
error: casting `u8` to `i8` may wrap around the value
|
|
--> $DIR/cast.rs:39:5
|
|
|
|
|
LL | 1u8 as i8;
|
|
| ^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::cast-possible-wrap` implied by `-D warnings`
|
|
|
|
error: casting `u16` to `i16` may wrap around the value
|
|
--> $DIR/cast.rs:40:5
|
|
|
|
|
LL | 1u16 as i16;
|
|
| ^^^^^^^^^^^
|
|
|
|
error: casting `u32` to `i32` may wrap around the value
|
|
--> $DIR/cast.rs:41:5
|
|
|
|
|
LL | 1u32 as i32;
|
|
| ^^^^^^^^^^^
|
|
|
|
error: casting `u64` to `i64` may wrap around the value
|
|
--> $DIR/cast.rs:42:5
|
|
|
|
|
LL | 1u64 as i64;
|
|
| ^^^^^^^^^^^
|
|
|
|
error: casting `usize` to `isize` may wrap around the value
|
|
--> $DIR/cast.rs:43:5
|
|
|
|
|
LL | 1usize as isize;
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
error: casting `i32` to `u32` may lose the sign of the value
|
|
--> $DIR/cast.rs:46:5
|
|
|
|
|
LL | -1i32 as u32;
|
|
| ^^^^^^^^^^^^
|
|
|
|
error: casting `isize` to `usize` may lose the sign of the value
|
|
--> $DIR/cast.rs:48:5
|
|
|
|
|
LL | -1isize as usize;
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
error: casting `i64` to `i8` may truncate the value
|
|
--> $DIR/cast.rs:115:5
|
|
|
|
|
LL | (-99999999999i64).min(1) as i8; // should be linted because signed
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | i8::try_from((-99999999999i64).min(1)); // should be linted because signed
|
|
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `u64` to `u8` may truncate the value
|
|
--> $DIR/cast.rs:127:5
|
|
|
|
|
LL | 999999u64.clamp(0, 256) as u8; // should still be linted
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | u8::try_from(999999u64.clamp(0, 256)); // should still be linted
|
|
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `main::E2` to `u8` may truncate the value
|
|
--> $DIR/cast.rs:148:21
|
|
|
|
|
LL | let _ = self as u8;
|
|
| ^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | let _ = u8::try_from(self);
|
|
| ~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `main::E2::B` to `u8` will truncate the value
|
|
--> $DIR/cast.rs:149:21
|
|
|
|
|
LL | let _ = Self::B as u8;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::cast-enum-truncation` implied by `-D warnings`
|
|
|
|
error: casting `main::E5` to `i8` may truncate the value
|
|
--> $DIR/cast.rs:185:21
|
|
|
|
|
LL | let _ = self as i8;
|
|
| ^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | let _ = i8::try_from(self);
|
|
| ~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `main::E5::A` to `i8` will truncate the value
|
|
--> $DIR/cast.rs:186:21
|
|
|
|
|
LL | let _ = Self::A as i8;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
error: casting `main::E6` to `i16` may truncate the value
|
|
--> $DIR/cast.rs:200:21
|
|
|
|
|
LL | let _ = self as i16;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | let _ = i16::try_from(self);
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `main::E7` to `usize` may truncate the value on targets with 32-bit wide pointers
|
|
--> $DIR/cast.rs:215:21
|
|
|
|
|
LL | let _ = self as usize;
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | let _ = usize::try_from(self);
|
|
| ~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `main::E10` to `u16` may truncate the value
|
|
--> $DIR/cast.rs:256:21
|
|
|
|
|
LL | let _ = self as u16;
|
|
| ^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | let _ = u16::try_from(self);
|
|
| ~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `u32` to `u8` may truncate the value
|
|
--> $DIR/cast.rs:264:13
|
|
|
|
|
LL | let c = (q >> 16) as u8;
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | let c = u8::try_from(q >> 16);
|
|
| ~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: casting `u32` to `u8` may truncate the value
|
|
--> $DIR/cast.rs:267:13
|
|
|
|
|
LL | let c = (q / 1000) as u8;
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
|
= help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ...
|
|
help: ... or use `try_from` and handle the error accordingly
|
|
|
|
|
LL | let c = u8::try_from(q / 1000);
|
|
| ~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
error: aborting due to 41 previous errors
|
|
|