mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 15:14:29 +00:00
157 lines
7 KiB
Text
157 lines
7 KiB
Text
error: called `map(f)` on an `Option` value where `f` is a function that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:37:5
|
|
|
|
|
LL | x.field.map(do_nothing);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(x_field) = x.field { do_nothing(x_field) }`
|
|
|
|
|
= note: `-D clippy::option-map-unit-fn` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::option_map_unit_fn)]`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a function that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:39:5
|
|
|
|
|
LL | x.field.map(do_nothing);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(x_field) = x.field { do_nothing(x_field) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a function that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:41:5
|
|
|
|
|
LL | x.field.map(diverge);
|
|
| ^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(x_field) = x.field { diverge(x_field) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:47:5
|
|
|
|
|
LL | x.field.map(|value| x.do_option_nothing(value + captured));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { x.do_option_nothing(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:49:5
|
|
|
|
|
LL | x.field.map(|value| { x.do_option_plus_one(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { x.do_option_plus_one(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:52:5
|
|
|
|
|
LL | x.field.map(|value| do_nothing(value + captured));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { do_nothing(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:54:5
|
|
|
|
|
LL | x.field.map(|value| { do_nothing(value + captured) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { do_nothing(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:56:5
|
|
|
|
|
LL | x.field.map(|value| { do_nothing(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { do_nothing(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:58:5
|
|
|
|
|
LL | x.field.map(|value| { { do_nothing(value + captured); } });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { do_nothing(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:61:5
|
|
|
|
|
LL | x.field.map(|value| diverge(value + captured));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { diverge(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:63:5
|
|
|
|
|
LL | x.field.map(|value| { diverge(value + captured) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { diverge(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:65:5
|
|
|
|
|
LL | x.field.map(|value| { diverge(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { diverge(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:67:5
|
|
|
|
|
LL | x.field.map(|value| { { diverge(value + captured); } });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { diverge(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:72:5
|
|
|
|
|
LL | x.field.map(|value| { let y = plus_one(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { let y = plus_one(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:74:5
|
|
|
|
|
LL | x.field.map(|value| { plus_one(value + captured); });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { plus_one(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:76:5
|
|
|
|
|
LL | x.field.map(|value| { { plus_one(value + captured); } });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = x.field { plus_one(value + captured); }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:79:5
|
|
|
|
|
LL | x.field.map(|ref value| { do_nothing(value + captured) });
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(ref value) = x.field { do_nothing(value + captured) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a function that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:81:5
|
|
|
|
|
LL | option().map(do_nothing);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(a) = option() { do_nothing(a) }`
|
|
|
|
error: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`
|
|
--> tests/ui/option_map_unit_fn_fixable.rs:83:5
|
|
|
|
|
LL | option().map(|value| println!("{:?}", value));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
|
|
| |
|
|
| help: try: `if let Some(value) = option() { println!("{:?}", value) }`
|
|
|
|
error: aborting due to 19 previous errors
|
|
|