mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-24 13:43:17 +00:00
6bb6dd64d4
There was an error when trying to negate an expression like `x - 1.0`. We used to format it as `-x - 1.0` whereas a proper negation would be `-(x - 1.0)`. Therefore, we add parentheses around the expression when it is a Binary ExprKind. We also add parentheses around multiply and divide expressions, even though this is not strictly necessary.
33 lines
964 B
Rust
33 lines
964 B
Rust
// run-rustfix
|
|
#![warn(clippy::suboptimal_flops)]
|
|
#![allow(clippy::unnecessary_cast)]
|
|
|
|
fn main() {
|
|
let one = 1;
|
|
let x = 3f32;
|
|
|
|
let y = 4f32;
|
|
let _ = x.mul_add(x, y);
|
|
let _ = x.mul_add(x, -y);
|
|
let _ = y.mul_add(y, x);
|
|
let _ = y.mul_add(-y, x);
|
|
let _ = (y as f32).mul_add(y as f32, x);
|
|
let _ = x.mul_add(x, y).sqrt();
|
|
let _ = y.mul_add(y, x).sqrt();
|
|
|
|
let _ = (x - 1.0).mul_add(x - 1.0, -y);
|
|
let _ = (x - 1.0).mul_add(x - 1.0, -y) + 3.0;
|
|
let _ = (x - 1.0).mul_add(x - 1.0, -(y + 3.0));
|
|
let _ = (y + 1.0).mul_add(-(y + 1.0), x);
|
|
let _ = (3.0 * y).mul_add(-(3.0 * y), x);
|
|
let _ = (y + 1.0 + x).mul_add(-(y + 1.0 + x), x);
|
|
let _ = (y + 1.0 + 2.0).mul_add(-(y + 1.0 + 2.0), x);
|
|
|
|
// Cases where the lint shouldn't be applied
|
|
let _ = x.powi(2);
|
|
let _ = x.powi(1 + 1);
|
|
let _ = x.powi(3);
|
|
let _ = x.powi(4) + y;
|
|
let _ = x.powi(one + 1);
|
|
let _ = (x.powi(2) + y.powi(2)).sqrt();
|
|
}
|