mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-09-20 14:41:58 +00:00
140 lines
4.4 KiB
Text
140 lines
4.4 KiB
Text
error: this `else` block is redundant
|
|
--> tests/ui/needless_continue.rs:30:16
|
|
|
|
|
LL | } else {
|
|
| ________________^
|
|
LL | |
|
|
LL | | continue;
|
|
LL | | }
|
|
| |_________^
|
|
|
|
|
= help: consider dropping the `else` clause and merging the code that follows (in the loop) with the `if` block
|
|
if i % 2 == 0 && i % 3 == 0 {
|
|
println!("{}", i);
|
|
println!("{}", i + 1);
|
|
if i % 5 == 0 {
|
|
println!("{}", i + 2);
|
|
}
|
|
let i = 0;
|
|
println!("bar {} ", i);
|
|
// merged code follows:
|
|
println!("bleh");
|
|
{
|
|
println!("blah");
|
|
}
|
|
if !(!(i == 2) || !(i == 5)) {
|
|
println!("lama");
|
|
}
|
|
if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
|
|
continue;
|
|
} else {
|
|
println!("Blabber");
|
|
println!("Jabber");
|
|
}
|
|
println!("bleh");
|
|
}
|
|
= note: `-D clippy::needless-continue` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::needless_continue)]`
|
|
|
|
error: there is no need for an explicit `else` block for this `if` expression
|
|
--> tests/ui/needless_continue.rs:46:9
|
|
|
|
|
LL | / if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
LL | |
|
|
LL | | continue;
|
|
LL | | } else {
|
|
LL | | println!("Blabber");
|
|
LL | | println!("Jabber");
|
|
LL | | }
|
|
| |_________^
|
|
|
|
|
= help: consider dropping the `else` clause
|
|
if (zero!(i % 2) || nonzero!(i % 5)) && i % 3 != 0 {
|
|
|
|
continue;
|
|
}
|
|
{
|
|
println!("Blabber");
|
|
println!("Jabber");
|
|
}
|
|
|
|
error: this `continue` expression is redundant
|
|
--> tests/ui/needless_continue.rs:60:9
|
|
|
|
|
LL | continue;
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider dropping the `continue` expression
|
|
|
|
error: this `continue` expression is redundant
|
|
--> tests/ui/needless_continue.rs:68:9
|
|
|
|
|
LL | continue;
|
|
| ^^^^^^^^^
|
|
|
|
|
= help: consider dropping the `continue` expression
|
|
|
|
error: this `continue` expression is redundant
|
|
--> tests/ui/needless_continue.rs:76:9
|
|
|
|
|
LL | continue
|
|
| ^^^^^^^^
|
|
|
|
|
= help: consider dropping the `continue` expression
|
|
|
|
error: this `continue` expression is redundant
|
|
--> tests/ui/needless_continue.rs:85:9
|
|
|
|
|
LL | continue
|
|
| ^^^^^^^^
|
|
|
|
|
= help: consider dropping the `continue` expression
|
|
|
|
error: this `else` block is redundant
|
|
--> tests/ui/needless_continue.rs:136:24
|
|
|
|
|
LL | } else {
|
|
| ________________________^
|
|
LL | |
|
|
LL | | continue 'inner;
|
|
LL | | }
|
|
| |_________________^
|
|
|
|
|
= help: consider dropping the `else` clause and merging the code that follows (in the loop) with the `if` block
|
|
if condition() {
|
|
println!("bar-3");
|
|
// merged code follows:
|
|
println!("bar-4");
|
|
update_condition();
|
|
if condition() {
|
|
|
|
continue;
|
|
} else {
|
|
println!("bar-5");
|
|
}
|
|
println!("bar-6");
|
|
}
|
|
|
|
error: there is no need for an explicit `else` block for this `if` expression
|
|
--> tests/ui/needless_continue.rs:143:17
|
|
|
|
|
LL | / if condition() {
|
|
LL | |
|
|
LL | | continue;
|
|
LL | | } else {
|
|
LL | | println!("bar-5");
|
|
LL | | }
|
|
| |_________________^
|
|
|
|
|
= help: consider dropping the `else` clause
|
|
if condition() {
|
|
|
|
continue;
|
|
}
|
|
{
|
|
println!("bar-5");
|
|
}
|
|
|
|
error: aborting due to 8 previous errors
|
|
|