mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-27 15:11:30 +00:00
357 lines
14 KiB
Text
357 lines
14 KiB
Text
error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
|
|
--> $DIR/methods.rs:35:5
|
|
|
|
|
LL | / pub fn add(self, other: T) -> T {
|
|
LL | | self
|
|
LL | | }
|
|
| |_____^
|
|
|
|
|
= note: `-D clippy::should-implement-trait` implied by `-D warnings`
|
|
|
|
error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:70:17
|
|
|
|
|
LL | fn into_u16(&self) -> u16 {
|
|
| ^^^^^
|
|
|
|
|
= note: `-D clippy::wrong-self-convention` implied by `-D warnings`
|
|
|
|
error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:74:21
|
|
|
|
|
LL | fn to_something(self) -> u32 {
|
|
| ^^^^
|
|
|
|
error: methods called `new` usually take no self; consider choosing a less ambiguous name
|
|
--> $DIR/methods.rs:78:12
|
|
|
|
|
LL | fn new(self) -> Self {
|
|
| ^^^^
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:158:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | // Should lint even though this call is on a separate line.
|
|
LL | | .unwrap_or(0);
|
|
| |____________________________^
|
|
|
|
|
= note: `-D clippy::option-map-unwrap-or` implied by `-D warnings`
|
|
= note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:162:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | x + 1
|
|
LL | | }
|
|
LL | | ).unwrap_or(0);
|
|
| |____________________________^
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:166:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | .unwrap_or({
|
|
LL | | 0
|
|
LL | | });
|
|
| |__________________^
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:171:13
|
|
|
|
|
LL | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:173:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | Some(x + 1)
|
|
LL | | }
|
|
LL | | ).unwrap_or(None);
|
|
| |_____________________^
|
|
|
|
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:177:13
|
|
|
|
|
LL | let _ = opt
|
|
| _____________^
|
|
LL | | .map(|x| Some(x + 1))
|
|
LL | | .unwrap_or(None);
|
|
| |________________________^
|
|
|
|
|
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
|
|
|
|
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
|
--> $DIR/methods.rs:188:13
|
|
|
|
|
LL | let _ = Some("prefix").map(|p| format!("{}.", p)).unwrap_or(id);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `map(|p| format!("{}.", p)).unwrap_or(id)` with `map_or(id, |p| format!("{}.", p))`
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:192:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | // Should lint even though this call is on a separate line.
|
|
LL | | .unwrap_or_else(|| 0);
|
|
| |____________________________________^
|
|
|
|
|
= note: `-D clippy::option-map-unwrap-or-else` implied by `-D warnings`
|
|
= note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:196:13
|
|
|
|
|
LL | let _ = opt.map(|x| {
|
|
| _____________^
|
|
LL | | x + 1
|
|
LL | | }
|
|
LL | | ).unwrap_or_else(|| 0);
|
|
| |____________________________________^
|
|
|
|
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
|
--> $DIR/methods.rs:200:13
|
|
|
|
|
LL | let _ = opt.map(|x| x + 1)
|
|
| _____________^
|
|
LL | | .unwrap_or_else(||
|
|
LL | | 0
|
|
LL | | );
|
|
| |_________________^
|
|
|
|
error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:210:13
|
|
|
|
|
LL | let _ = opt.map_or(None, |x| Some(x + 1));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `opt.and_then(|x| Some(x + 1))`
|
|
|
|
|
= note: `-D clippy::option-map-or-none` implied by `-D warnings`
|
|
|
|
error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
|
--> $DIR/methods.rs:212:13
|
|
|
|
|
LL | let _ = opt.map_or(None, |x| {
|
|
| _____________^
|
|
LL | | Some(x + 1)
|
|
LL | | }
|
|
LL | | );
|
|
| |_________________^
|
|
help: try using and_then instead
|
|
|
|
|
LL | let _ = opt.and_then(|x| {
|
|
LL | Some(x + 1)
|
|
LL | });
|
|
|
|
|
|
|
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
|
--> $DIR/methods.rs:238:13
|
|
|
|
|
LL | let _ = v.iter().filter(|&x| *x < 0).next();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::filter-next` implied by `-D warnings`
|
|
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
|
|
|
|
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
|
--> $DIR/methods.rs:241:13
|
|
|
|
|
LL | let _ = v.iter().filter(|&x| {
|
|
| _____________^
|
|
LL | | *x < 0
|
|
LL | | }
|
|
LL | | ).next();
|
|
| |___________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:257:13
|
|
|
|
|
LL | let _ = v.iter().find(|&x| *x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::search-is-some` implied by `-D warnings`
|
|
= note: replace `find(|&x| *x < 0).is_some()` with `any(|&x| *x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:260:13
|
|
|
|
|
LL | let _ = v.iter().find(|&x| {
|
|
| _____________^
|
|
LL | | *x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:266:13
|
|
|
|
|
LL | let _ = v.iter().position(|&x| x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:269:13
|
|
|
|
|
LL | let _ = v.iter().position(|&x| {
|
|
| _____________^
|
|
LL | | x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:275:13
|
|
|
|
|
LL | let _ = v.iter().rposition(|&x| x < 0).is_some();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
|
|
|
|
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
|
--> $DIR/methods.rs:278:13
|
|
|
|
|
LL | let _ = v.iter().rposition(|&x| {
|
|
| _____________^
|
|
LL | | x < 0
|
|
LL | | }
|
|
LL | | ).is_some();
|
|
| |______________________________^
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:315:22
|
|
|
|
|
LL | with_constructor.unwrap_or(make());
|
|
| ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(make)`
|
|
|
|
|
= note: `-D clippy::or-fun-call` implied by `-D warnings`
|
|
|
|
error: use of `unwrap_or` followed by a call to `new`
|
|
--> $DIR/methods.rs:318:5
|
|
|
|
|
LL | with_new.unwrap_or(Vec::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:321:21
|
|
|
|
|
LL | with_const_args.unwrap_or(Vec::with_capacity(12));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::with_capacity(12))`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:324:14
|
|
|
|
|
LL | with_err.unwrap_or(make());
|
|
| ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| make())`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:327:19
|
|
|
|
|
LL | with_err_args.unwrap_or(Vec::with_capacity(12));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| Vec::with_capacity(12))`
|
|
|
|
error: use of `unwrap_or` followed by a call to `default`
|
|
--> $DIR/methods.rs:330:5
|
|
|
|
|
LL | with_default_trait.unwrap_or(Default::default());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a call to `default`
|
|
--> $DIR/methods.rs:333:5
|
|
|
|
|
LL | with_default_type.unwrap_or(u64::default());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:336:14
|
|
|
|
|
LL | with_vec.unwrap_or(vec![]);
|
|
| ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:341:21
|
|
|
|
|
LL | without_default.unwrap_or(Foo::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(Foo::new)`
|
|
|
|
error: use of `or_insert` followed by a function call
|
|
--> $DIR/methods.rs:344:19
|
|
|
|
|
LL | map.entry(42).or_insert(String::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(String::new)`
|
|
|
|
error: use of `or_insert` followed by a function call
|
|
--> $DIR/methods.rs:347:21
|
|
|
|
|
LL | btree.entry(42).or_insert(String::new());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(String::new)`
|
|
|
|
error: use of `unwrap_or` followed by a function call
|
|
--> $DIR/methods.rs:350:21
|
|
|
|
|
LL | let _ = stringy.unwrap_or("".to_owned());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
|
|
|
|
error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
|
|
--> $DIR/methods.rs:361:23
|
|
|
|
|
LL | let bad_vec = some_vec.iter().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::iter-nth` implied by `-D warnings`
|
|
|
|
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
|
|
--> $DIR/methods.rs:362:26
|
|
|
|
|
LL | let bad_slice = &some_vec[..].iter().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
|
|
--> $DIR/methods.rs:363:31
|
|
|
|
|
LL | let bad_boxed_slice = boxed_slice.iter().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
|
|
--> $DIR/methods.rs:364:29
|
|
|
|
|
LL | let bad_vec_deque = some_vec_deque.iter().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
|
|
--> $DIR/methods.rs:369:23
|
|
|
|
|
LL | let bad_vec = some_vec.iter_mut().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
|
|
--> $DIR/methods.rs:372:26
|
|
|
|
|
LL | let bad_slice = &some_vec[..].iter_mut().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
|
|
--> $DIR/methods.rs:375:29
|
|
|
|
|
LL | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
|
|
--> $DIR/methods.rs:387:13
|
|
|
|
|
LL | let _ = opt.unwrap();
|
|
| ^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::option-unwrap-used` implied by `-D warnings`
|
|
|
|
error: aborting due to 44 previous errors
|
|
|