mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-24 12:03:28 +00:00
39c8f84f3b
This splits up the needless_bool tests into `fixable.rs` and `simple.rs`. `simple.rs` contains the code that triggers the lint diagnostic without a suggestion.
111 lines
2.9 KiB
Text
111 lines
2.9 KiB
Text
error: this if-then-else expression returns a bool literal
|
|
--> $DIR/fixable.rs:39:5
|
|
|
|
|
LL | / if x {
|
|
LL | | true
|
|
LL | | } else {
|
|
LL | | false
|
|
LL | | };
|
|
| |_____^ help: you can reduce it to: `x`
|
|
|
|
|
= note: `-D clippy::needless-bool` implied by `-D warnings`
|
|
|
|
error: this if-then-else expression returns a bool literal
|
|
--> $DIR/fixable.rs:44:5
|
|
|
|
|
LL | / if x {
|
|
LL | | false
|
|
LL | | } else {
|
|
LL | | true
|
|
LL | | };
|
|
| |_____^ help: you can reduce it to: `!x`
|
|
|
|
error: this if-then-else expression returns a bool literal
|
|
--> $DIR/fixable.rs:49:5
|
|
|
|
|
LL | / if x && y {
|
|
LL | | false
|
|
LL | | } else {
|
|
LL | | true
|
|
LL | | };
|
|
| |_____^ help: you can reduce it to: `!(x && y)`
|
|
|
|
error: this if-then-else expression returns a bool literal
|
|
--> $DIR/fixable.rs:69:5
|
|
|
|
|
LL | / if x {
|
|
LL | | return true;
|
|
LL | | } else {
|
|
LL | | return false;
|
|
LL | | };
|
|
| |_____^ help: you can reduce it to: `return x`
|
|
|
|
error: this if-then-else expression returns a bool literal
|
|
--> $DIR/fixable.rs:77:5
|
|
|
|
|
LL | / if x {
|
|
LL | | return false;
|
|
LL | | } else {
|
|
LL | | return true;
|
|
LL | | };
|
|
| |_____^ help: you can reduce it to: `return !x`
|
|
|
|
error: this if-then-else expression returns a bool literal
|
|
--> $DIR/fixable.rs:85:5
|
|
|
|
|
LL | / if x && y {
|
|
LL | | return true;
|
|
LL | | } else {
|
|
LL | | return false;
|
|
LL | | };
|
|
| |_____^ help: you can reduce it to: `return x && y`
|
|
|
|
error: this if-then-else expression returns a bool literal
|
|
--> $DIR/fixable.rs:93:5
|
|
|
|
|
LL | / if x && y {
|
|
LL | | return false;
|
|
LL | | } else {
|
|
LL | | return true;
|
|
LL | | };
|
|
| |_____^ help: you can reduce it to: `return !(x && y)`
|
|
|
|
error: equality checks against true are unnecessary
|
|
--> $DIR/fixable.rs:101:8
|
|
|
|
|
LL | if x == true {};
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
|
= note: `-D clippy::bool-comparison` implied by `-D warnings`
|
|
|
|
error: equality checks against false can be replaced by a negation
|
|
--> $DIR/fixable.rs:105:8
|
|
|
|
|
LL | if x == false {};
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!x`
|
|
|
|
error: equality checks against true are unnecessary
|
|
--> $DIR/fixable.rs:115:8
|
|
|
|
|
LL | if x == true {};
|
|
| ^^^^^^^^^ help: try simplifying it as shown: `x`
|
|
|
|
error: equality checks against false can be replaced by a negation
|
|
--> $DIR/fixable.rs:116:8
|
|
|
|
|
LL | if x == false {};
|
|
| ^^^^^^^^^^ help: try simplifying it as shown: `!x`
|
|
|
|
error: this if-then-else expression returns a bool literal
|
|
--> $DIR/fixable.rs:125:12
|
|
|
|
|
LL | } else if returns_bool() {
|
|
| ____________^
|
|
LL | | false
|
|
LL | | } else {
|
|
LL | | true
|
|
LL | | };
|
|
| |_____^ help: you can reduce it to: `{ !returns_bool() }`
|
|
|
|
error: aborting due to 12 previous errors
|
|
|