mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-30 16:39:26 +00:00
4f4abf4e06
Warn about assignments where left-hand side place expression is the same
as right-hand side value expression. For example, warn about assignment in:
```rust
pub struct Event {
id: usize,
x: i32,
y: i32,
}
pub fn copy_position(a: &mut Event, b: &Event) {
a.x = b.x;
a.y = a.y;
}
```
70 lines
1.5 KiB
Text
70 lines
1.5 KiB
Text
error: self-assignment of `a` to `a`
|
|
--> $DIR/self_assignment.rs:12:5
|
|
|
|
|
LL | a = a;
|
|
| ^^^^^
|
|
|
|
|
= note: `-D clippy::self-assignment` implied by `-D warnings`
|
|
|
|
error: self-assignment of `*b` to `*b`
|
|
--> $DIR/self_assignment.rs:13:5
|
|
|
|
|
LL | *b = *b;
|
|
| ^^^^^^^
|
|
|
|
error: self-assignment of `s` to `s`
|
|
--> $DIR/self_assignment.rs:14:5
|
|
|
|
|
LL | s = s;
|
|
| ^^^^^
|
|
|
|
error: self-assignment of `s.a` to `s.a`
|
|
--> $DIR/self_assignment.rs:15:5
|
|
|
|
|
LL | s.a = s.a;
|
|
| ^^^^^^^^^
|
|
|
|
error: self-assignment of `s.b[5 + 5]` to `s.b[10]`
|
|
--> $DIR/self_assignment.rs:16:5
|
|
|
|
|
LL | s.b[10] = s.b[5 + 5];
|
|
| ^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: self-assignment of `s.c[0][1]` to `s.c[0][1]`
|
|
--> $DIR/self_assignment.rs:17:5
|
|
|
|
|
LL | s.c[0][1] = s.c[0][1];
|
|
| ^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: self-assignment of `s.b[a]` to `s.b[a]`
|
|
--> $DIR/self_assignment.rs:18:5
|
|
|
|
|
LL | s.b[a] = s.b[a];
|
|
| ^^^^^^^^^^^^^^^
|
|
|
|
error: self-assignment of `*s.e` to `*s.e`
|
|
--> $DIR/self_assignment.rs:19:5
|
|
|
|
|
LL | *s.e = *s.e;
|
|
| ^^^^^^^^^^^
|
|
|
|
error: self-assignment of `s.b[10 + a]` to `s.b[a + 10]`
|
|
--> $DIR/self_assignment.rs:20:5
|
|
|
|
|
LL | s.b[a + 10] = s.b[10 + a];
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: self-assignment of `t.1` to `t.1`
|
|
--> $DIR/self_assignment.rs:23:5
|
|
|
|
|
LL | t.1 = t.1;
|
|
| ^^^^^^^^^
|
|
|
|
error: self-assignment of `(t.0)` to `t.0`
|
|
--> $DIR/self_assignment.rs:24:5
|
|
|
|
|
LL | t.0 = (t.0);
|
|
| ^^^^^^^^^^^
|
|
|
|
error: aborting due to 11 previous errors
|
|
|