mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-26 21:13:31 +00:00
1ce3cbf9c4
There may be no sensible `Default` impl if the result of `new` depends on a type parameter.
86 lines
1.4 KiB
Rust
86 lines
1.4 KiB
Rust
#![feature(plugin, const_fn)]
|
|
#![plugin(clippy)]
|
|
|
|
#![allow(dead_code)]
|
|
#![warn(new_without_default, new_without_default_derive)]
|
|
|
|
pub struct Foo;
|
|
|
|
impl Foo {
|
|
pub fn new() -> Foo { Foo }
|
|
}
|
|
|
|
pub struct Bar;
|
|
|
|
impl Bar {
|
|
pub fn new() -> Self { Bar }
|
|
}
|
|
|
|
pub struct Ok;
|
|
|
|
impl Ok {
|
|
pub fn new() -> Self { Ok }
|
|
}
|
|
|
|
impl Default for Ok {
|
|
fn default() -> Self { Ok }
|
|
}
|
|
|
|
pub struct Params;
|
|
|
|
impl Params {
|
|
pub fn new(_: u32) -> Self { Params }
|
|
}
|
|
|
|
pub struct GenericsOk<T> {
|
|
bar: T,
|
|
}
|
|
|
|
impl<U> Default for GenericsOk<U> {
|
|
fn default() -> Self { unimplemented!(); }
|
|
}
|
|
|
|
impl<'c, V> GenericsOk<V> {
|
|
pub fn new() -> GenericsOk<V> { unimplemented!() }
|
|
}
|
|
|
|
pub struct LtOk<'a> {
|
|
foo: &'a bool,
|
|
}
|
|
|
|
impl<'b> Default for LtOk<'b> {
|
|
fn default() -> Self { unimplemented!(); }
|
|
}
|
|
|
|
impl<'c> LtOk<'c> {
|
|
pub fn new() -> LtOk<'c> { unimplemented!() }
|
|
}
|
|
|
|
pub struct LtKo<'a> {
|
|
foo: &'a bool,
|
|
}
|
|
|
|
impl<'c> LtKo<'c> {
|
|
pub fn new() -> LtKo<'c> { unimplemented!() }
|
|
// FIXME: that suggestion is missing lifetimes
|
|
}
|
|
|
|
struct Private;
|
|
|
|
impl Private {
|
|
fn new() -> Private { unimplemented!() } // We don't lint private items
|
|
}
|
|
|
|
struct Const;
|
|
|
|
impl Const {
|
|
pub const fn new() -> Const { Const } // const fns can't be implemented via Default
|
|
}
|
|
|
|
pub struct IgnoreGenericNew;
|
|
|
|
impl IgnoreGenericNew {
|
|
pub fn new<T>() -> Self { IgnoreGenericNew } // the derived Default does not make sense here as the result depends on T
|
|
}
|
|
|
|
fn main() {}
|