rust-clippy/tests/ui/shadow.rs
Max Niederman 008ba2b8bb
new lint: redundant_local
fix dogfood lints in `redundant_local`

keep `redundant_local` from running in proc macros

rewrite `redundant_local` as late pass

make redundant_local's `find_binding` more readable

pluralize `redundant_locals` name

add test for `redundant_locals` in macros

test `redundant_locals` in proc macros

use more destructuring in `redundant_locals`

fix: format redundant_locals.rs

ignore needless_pass_by_mut_ref in redundant_locals test
2023-07-21 18:14:03 -07:00

117 lines
2 KiB
Rust

//@aux-build:proc_macro_derive.rs:proc-macro
#![warn(clippy::shadow_same, clippy::shadow_reuse, clippy::shadow_unrelated)]
#![allow(clippy::let_unit_value, clippy::needless_if, clippy::redundant_locals)]
extern crate proc_macro_derive;
#[derive(proc_macro_derive::ShadowDerive)]
pub struct Nothing;
macro_rules! reuse {
($v:ident) => {
let $v = $v + 1;
};
}
fn shadow_same() {
let x = 1;
let x = x;
let mut x = &x;
let x = &mut x;
let x = *x;
}
fn shadow_reuse() -> Option<()> {
let x = ([[0]], ());
let x = x.0;
let x = x[0];
let [x] = x;
let x = Some(x);
let x = foo(x);
let x = || x;
let x = Some(1).map(|_| x)?;
let y = 1;
let y = match y {
1 => 2,
_ => 3,
};
None
}
fn shadow_reuse_macro() {
let x = 1;
// this should not warn
reuse!(x);
}
fn shadow_unrelated() {
let x = 1;
let x = 2;
}
fn syntax() {
fn f(x: u32) {
let x = 1;
}
let x = 1;
match Some(1) {
Some(1) => {},
Some(x) => {
let x = 1;
},
_ => {},
}
if let Some(x) = Some(1) {}
while let Some(x) = Some(1) {}
let _ = |[x]: [u32; 1]| {
let x = 1;
};
let y = Some(1);
if let Some(y) = y {}
}
fn negative() {
match Some(1) {
Some(x) if x == 1 => {},
Some(x) => {},
None => {},
}
match [None, Some(1)] {
[Some(x), None] | [None, Some(x)] => {},
_ => {},
}
if let Some(x) = Some(1) {
let y = 1;
} else {
let x = 1;
let y = 1;
}
let x = 1;
#[allow(clippy::shadow_unrelated)]
let x = 1;
}
fn foo<T>(_: T) {}
fn question_mark() -> Option<()> {
let val = 1;
// `?` expands with a `val` binding
None?;
None
}
pub async fn foo1(_a: i32) {}
pub async fn foo2(_a: i32, _b: i64) {
let _b = _a;
}
fn ice_8748() {
let _ = [0; {
let x = 1;
if let Some(x) = Some(1) { x } else { 1 }
}];
}
fn main() {}