mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 07:04:18 +00:00
c88cb08afc
When there is are multiple references where one of the references isn't mutable then this results in a false-positive for `mut_mutex_lock` as it only checks the mutability of the first reference level. Fix this by using `peel_mid_ty_refs_is_mutable` which correctly determines whether the reference is ultimately mutable and thus whether `Mutex::get_lock()` can actually be used. Fixes #9854
39 lines
1,017 B
Rust
39 lines
1,017 B
Rust
#![allow(dead_code, unused_mut)]
|
|
#![warn(clippy::mut_mutex_lock)]
|
|
|
|
use std::sync::{Arc, Mutex};
|
|
|
|
fn mut_mutex_lock() {
|
|
let mut value_rc = Arc::new(Mutex::new(42_u8));
|
|
let value_mutex = Arc::get_mut(&mut value_rc).unwrap();
|
|
|
|
let mut value = value_mutex.get_mut().unwrap();
|
|
*value += 1;
|
|
|
|
let mut value_mutex = Mutex::new(42_u8);
|
|
let mut_ref_mut_ref_mutex = &mut &mut value_mutex;
|
|
let mut value = mut_ref_mut_ref_mutex.get_mut().unwrap();
|
|
*value += 1;
|
|
}
|
|
|
|
fn no_owned_mutex_lock() {
|
|
let mut value_rc = Arc::new(Mutex::new(42_u8));
|
|
let mut value = value_rc.lock().unwrap();
|
|
*value += 1;
|
|
}
|
|
|
|
fn issue9415() {
|
|
let mut arc_mutex = Arc::new(Mutex::new(42_u8));
|
|
let arc_mutex: &mut Arc<Mutex<u8>> = &mut arc_mutex;
|
|
let mut guard = arc_mutex.lock().unwrap();
|
|
*guard += 1;
|
|
}
|
|
|
|
fn mut_ref_ref_mutex_lock() {
|
|
let mutex = Mutex::new(42_u8);
|
|
let mut_ref_ref_mutex = &mut &mutex;
|
|
let mut guard = mut_ref_ref_mutex.lock().unwrap();
|
|
*guard += 1;
|
|
}
|
|
|
|
fn main() {}
|