// run-rustfix #![warn(clippy::while_let_on_iterator)] #![allow(clippy::never_loop, unreachable_code, unused_mut, dead_code)] fn base() { let mut iter = 1..20; while let Option::Some(x) = iter.next() { println!("{}", x); } let mut iter = 1..20; while let Some(x) = iter.next() { println!("{}", x); } let mut iter = 1..20; while let Some(_) = iter.next() {} let mut iter = 1..20; while let None = iter.next() {} // this is fine (if nonsensical) let mut iter = 1..20; if let Some(x) = iter.next() { // also fine println!("{}", x) } // the following shouldn't warn because it can't be written with a for loop let mut iter = 1u32..20; while let Some(_) = iter.next() { println!("next: {:?}", iter.next()) } // neither can this let mut iter = 1u32..20; while let Some(_) = iter.next() { println!("next: {:?}", iter.next()); } // or this let mut iter = 1u32..20; while let Some(_) = iter.next() { iter = 1..20; } } // Issue #1188 fn refutable() { let a = [42, 1337]; let mut b = a.iter(); // consume all the 42s while let Some(&42) = b.next() {} let a = [(1, 2, 3)]; let mut b = a.iter(); while let Some(&(1, 2, 3)) = b.next() {} let a = [Some(42)]; let mut b = a.iter(); while let Some(&None) = b.next() {} /* This gives “refutable pattern in `for` loop binding: `&_` not covered” for &42 in b {} for &(1, 2, 3) in b {} for &Option::None in b.next() {} // */ } fn refutable2() { // Issue 3780 { let v = vec![1, 2, 3]; let mut it = v.windows(2); while let Some([x, y]) = it.next() { println!("x: {}", x); println!("y: {}", y); } let mut it = v.windows(2); while let Some([x, ..]) = it.next() { println!("x: {}", x); } let mut it = v.windows(2); while let Some([.., y]) = it.next() { println!("y: {}", y); } let mut it = v.windows(2); while let Some([..]) = it.next() {} let v = vec![[1], [2], [3]]; let mut it = v.iter(); while let Some([1]) = it.next() {} let mut it = v.iter(); while let Some([_x]) = it.next() {} } // binding { let v = vec![1, 2, 3]; let mut it = v.iter(); while let Some(x @ 1) = it.next() { println!("{}", x); } let v = vec![[1], [2], [3]]; let mut it = v.iter(); while let Some(x @ [_]) = it.next() { println!("{:?}", x); } } // false negative { let v = vec![1, 2, 3]; let mut it = v.iter().map(Some); while let Some(Some(_) | None) = it.next() { println!("1"); } } } fn nested_loops() { let a = [42, 1337]; loop { let mut y = a.iter(); while let Some(_) = y.next() { // use a for loop here } } } fn issue1121() { use std::collections::HashSet; let mut values = HashSet::new(); values.insert(1); while let Some(&value) = values.iter().next() { values.remove(&value); } } fn issue2965() { // This should not cause an ICE use std::collections::HashSet; let mut values = HashSet::new(); values.insert(1); while let Some(..) = values.iter().next() {} } fn issue3670() { let array = [Some(0), None, Some(1)]; let mut iter = array.iter(); while let Some(elem) = iter.next() { let _ = elem.or_else(|| *iter.next()?); } } fn issue1654() { // should not lint if the iterator is generated on every iteration use std::collections::HashSet; let mut values = HashSet::new(); values.insert(1); while let Some(..) = values.iter().next() { values.remove(&1); } while let Some(..) = values.iter().map(|x| x + 1).next() {} let chars = "Hello, World!".char_indices(); while let Some((i, ch)) = chars.clone().next() { println!("{}: {}", i, ch); } } fn issue6491() { // Used in outer loop, needs &mut let mut it = 1..40; while let Some(n) = it.next() { while let Some(m) = it.next() { if m % 10 == 0 { break; } println!("doing something with m: {}", m); } println!("n still is {}", n); } // This is fine, inner loop uses a new iterator. let mut it = 1..40; while let Some(n) = it.next() { let mut it = 1..40; while let Some(m) = it.next() { if m % 10 == 0 { break; } println!("doing something with m: {}", m); } // Weird binding shouldn't change anything. let (mut it, _) = (1..40, 0); while let Some(m) = it.next() { if m % 10 == 0 { break; } println!("doing something with m: {}", m); } // Used after the loop, needs &mut. let mut it = 1..40; while let Some(m) = it.next() { if m % 10 == 0 { break; } println!("doing something with m: {}", m); } println!("next item {}", it.next().unwrap()); println!("n still is {}", n); } } fn issue6231() { // Closure in the outer loop, needs &mut let mut it = 1..40; let mut opt = Some(0); while let Some(n) = opt.take().or_else(|| it.next()) { while let Some(m) = it.next() { if n % 10 == 0 { break; } println!("doing something with m: {}", m); } println!("n still is {}", n); } } fn issue1924() { struct S(T); impl> S { fn f(&mut self) -> Option { // Used as a field. while let Some(i) = self.0.next() { if i < 3 || i > 7 { return Some(i); } } None } fn f2(&mut self) -> Option { // Don't lint, self borrowed inside the loop while let Some(i) = self.0.next() { if i == 1 { return self.f(); } } None } } impl> S<(S, Option)> { fn f3(&mut self) -> Option { // Don't lint, self borrowed inside the loop while let Some(i) = self.0.0.0.next() { if i == 1 { return self.0.0.f(); } } while let Some(i) = self.0.0.0.next() { if i == 1 { return self.f3(); } } // This one is fine, a different field is borrowed while let Some(i) = self.0.0.0.next() { if i == 1 { return self.0.1.take(); } else { self.0.1 = Some(i); } } None } } struct S2(T, u32); impl> Iterator for S2 { type Item = u32; fn next(&mut self) -> Option { self.0.next() } } // Don't lint, field of the iterator is accessed in the loop let mut it = S2(1..40, 0); while let Some(n) = it.next() { if n == it.1 { break; } } // Needs &mut, field of the iterator is accessed after the loop let mut it = S2(1..40, 0); while let Some(n) = it.next() { if n == 0 { break; } } println!("iterator field {}", it.1); } fn issue7249() { let mut it = 0..10; let mut x = || { // Needs &mut, the closure can be called multiple times while let Some(x) = it.next() { if x % 2 == 0 { break; } } }; x(); x(); } fn main() { let mut it = 0..20; while let Some(..) = it.next() { println!("test"); } }