8 commits

Author	SHA1	Message	Date
Alex Macleod	461e219d1d	Allow using clippy::msrv as an outer attribute	2022-11-27 12:43:17 +00:00
Alex Macleod	4424aa444c	manual_split_once: lint manual iteration of SplitN	2022-04-21 18:33:54 +01:00
bors	5344236715	Auto merge of #8631 - Alexendoo:splitn-overlap, r=xFrednet ... Remove overlap between `manual_split_once` and `needless_splitn` changelog: Remove overlap between [`manual_split_once`] and [`needless_splitn`]. Fixes some incorrect `rsplitn` suggestions for [`manual_split_once`] Things that can trigger `needless_splitn` no longer trigger `manual_split_once`, e.g. ```rust s.[r]splitn(2, '=').next(); s.[r]splitn(2, '=').nth(0); s.[r]splitn(3, '=').next_tuple(); ``` Fixes some suggestions: ```rust let s = "should not match"; s.rsplitn(2, '.').nth(1); // old -> Some("should not match") Some(s.rsplit_once('.').map_or(s, |x| x.0)); // new -> None s.rsplit_once('.').map(|x| x.0); s.rsplitn(2, '.').nth(1)?; // old -> "should not match" s.rsplit_once('.').map_or(s, |x| x.0); // new -> early returns s.rsplit_once('.')?.0; ```	2022-04-10 17:45:19 +00:00
Alex Macleod	6fba89751b	Remove overlap between manual_split_once and needless_splitn ... Also fixes some incorrect suggestions for rsplitn	2022-04-10 17:05:07 +01:00
kyoto7250	a9511482d6	fix comments in test for split_once ... split_once was stabilized in 1.52	2022-04-09 20:34:43 +09:00
surechen	c051656c83	fixes: #7889 ... 1. Fix the problem of manual_split_once changing the original behavior. 2. Add a new lint needless_splitn. changelog: Fix the problem of manual_split_once changing the original behavior and add a new lint needless_splitn.	2021-11-17 08:38:45 +08:00
Jason Newcomb	4c1b6a28e4	Fix result order for manual_split_once when rsplitn is used	2021-09-10 13:05:09 -04:00
Jason Newcomb	a7f376fbd3	Add lint manual_split_once	2021-08-16 09:34:58 -04:00