Commit graph

4590 commits

Author SHA1 Message Date
Pascal Seitz
43549ebbf8 fixes #3151 by skipping the lint instead of crashing 2018-09-08 15:30:50 +02:00
mikerite
fdd830f52c
Merge pull request #3150 from matthiaskrgr/crate_vis_feat
clippy_lints: enable crate_visibility_modifier since it is used but no longer part of 2018 edition.
2018-09-08 09:28:38 +02:00
Matthias Krüger
160959d27f add tests for #3057 and #2651
Fixes #3057
Fixes #2651
2018-09-08 09:04:04 +02:00
Josh Mcguigan
9168746c38 Corrected explicit_counter_loop behavior with nested loops 2018-09-07 20:46:36 -07:00
Josh Mcguigan
53c262048c Fix #1219 false positive for explicit_counter_loop 2018-09-07 19:58:19 -07:00
Matthias Krüger
f6935be71e clippy_lints: enable crate_visibility_modifier since it is used but no longer part of 2018 edition.
Fixes build with https://github.com/rust-lang/rust/pull/53999
2018-09-08 01:32:40 +02:00
Philipp Krones
404dd8245e
Merge pull request #3146 from flip1995/fix-3145
Fix 3145
2018-09-07 20:30:05 +02:00
Matthias Krüger
a14155088b rustc_tools_util: add test 2018-09-07 19:18:45 +02:00
Matthias Krüger
202db3e09c rustc_tools_util: don't hardcode crate name 2018-09-07 18:03:03 +02:00
flip1995
90f7997771
Add regression test 2018-09-07 17:41:03 +02:00
flip1995
fa3e3cb6ea
Fix #3145 by removing assert 2018-09-07 17:18:00 +02:00
Josh Mcguigan
ce554267b8 Updated explicit_counter_loop tests based on discussion in #3135 2018-09-07 05:32:56 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
63a46b1e1a
Merge pull request #3129 from mipli/3091-numeric-typo
Add lint for misstyped literal casting
2018-09-07 09:54:43 +02:00
Philipp Hansch
cafef7b576
Merge pull request #3137 from matthiaskrgr/clippy_git_version
print git commit hash and commit date in version output
2018-09-06 18:21:14 +01:00
Philipp Hansch
5fca61409f
Merge pull request #3139 from matthiaskrgr/toml_clippy_dev_warn
Cargo.toml: remove clippy-dev entry referencing src/main.rs as its main.rs
2018-09-06 18:15:41 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
8af69273d0
Merge pull request #3138 from matthiaskrgr/3126__no_warn_multi_newline
print_with_newline / write_with_newline: don't warn about string with several `\n`s in them.
2018-09-06 17:41:23 +02:00
Michael A. Plikk
7bf8d8ba09 Simplified boolean expression for checking literal suffixes 2018-09-06 17:19:38 +02:00
Michael A. Plikk
986c772c24 Reduce number of split_at calls 2018-09-06 16:26:17 +02:00
Josh Mcguigan
edfa9feac2 Corrected explicit_counter_loop missing lints if variable used after loop 2018-09-06 06:20:25 -07:00
Matthias Krüger
fa11aad92a print git commit hash and commit date in version output
clippy 0.0.212 (964fcbe0 2018-09-06)
2018-09-06 14:45:12 +02:00
Matthias Krüger
86679e230c Cargo.toml: remove clippy-dev entry referencing src/main.rs as its main.rs.
Resolves warning:
warning: file found to be present in multiple build targets: ./src/main.rs
2018-09-06 13:03:38 +02:00
Matthias Krüger
a0f56edfc3 print_with_newline / write_with_newline: don't warn about string with several \ns in them.
Fixes #3126
2018-09-06 12:59:34 +02:00
Matthias Krüger
0a8ceaf8b0 rustfmt clippy_lints/src/write.rs 2018-09-06 12:33:00 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
3262f9283f
Merge pull request #3136 from mikerite/driver-rustc-arg-2
driver: Improve check for rustc arg
2018-09-06 09:26:11 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
dc164f4c46
Merge pull request #2985 from phansch/riir_update_lints
update_lints rewrite: Add structure and --print-only
2018-09-06 09:24:26 +02:00
Philipp Hansch
3bdc691a91
Pass by ref instead of value 2018-09-06 08:19:09 +02:00
Philipp Hansch
de36d42e80
More refactoring 2018-09-06 07:15:31 +02:00
Philipp Hansch
ca753c4af1
Merge pull request #3133 from matthiaskrgr/link
remove "clippy::" lint prefix from lint name in doc url.
2018-09-06 07:10:45 +02:00
Michael Wright
4f7a260472 driver: Improve check for rustc arg
The rustc arg might not be exactly "rustc". It may be any path to a rustc
executable (especially if the RUSTC environment variable is set when
executing cargo). Rather check that it is a path with 'rustc' file stem.
2018-09-06 07:01:56 +02:00
Josh Mcguigan
4b668159d2 Closes #1219 false positive for explicit_counter_loop 2018-09-05 19:14:01 -07:00
Matthias Krüger
554fe1ed5c remove "clippy::" lint prefix from lint name in doc url.
Fixes #3132
2018-09-06 00:45:57 +02:00
Michael A. Plikk
38d287fecd Add lint for misstyped literal casting 2018-09-05 19:46:49 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
ebb88a4208
Merge pull request #3131 from JoshMcguigan/ptr_arg-2293
Fix #2293 - ptr_arg
2018-09-05 16:22:03 +02:00
Josh Mcguigan
0f6d422817 Added test case for ptr_arg 2018-09-05 05:59:07 -07:00
Philipp Hansch
20836d3003
Remove duplicated .gitignore 2018-09-05 13:35:57 +02:00
Philipp Hansch
79bec036f8
Return impl Iterator instead of Vec<Lint>
This makes the API of `lib.rs` a bit more flexible.
2018-09-05 13:34:28 +02:00
Philipp Krones
ed38d9c79f
Merge pull request #3108 from daubaris/range-plus-one
range_plus_one suggestion should not remove braces fix
2018-09-04 21:13:30 +02:00
daubaris
009c29069c switched to ticks for chars 2018-09-04 18:56:48 +03:00
daubaris
db391c4613 Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy into range-plus-one 2018-09-04 18:52:18 +03:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
b7587d8176
Merge pull request #3125 from nrc/pub-conf
Make `Default` do what `default` used to do
2018-09-04 10:09:38 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
f5804dd906
Merge pull request #3124 from phansch/cleanup_old_min_version_stuff
Cleanup old min_version stuff
2018-09-04 10:09:10 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
df646a88a9
Merge pull request #3109 from shssoichiro/3034-needless-collect
Lint against needless uses of `collect()`
2018-09-04 10:07:11 +02:00
Josh Holmer
f7d2aeefe8 Delete needless file 2018-09-04 00:00:06 -04:00
Josh Holmer
ed9cd1530d More if_chain 2018-09-03 23:58:10 -04:00
Josh Holmer
48e6be42d7 Rustup 2018-09-03 23:50:24 -04:00
Josh Holmer
061b2f3057 Apply applicability 2018-09-03 23:29:44 -04:00
Josh Holmer
dfed9751bd Majority of PR changes 2018-09-03 23:29:44 -04:00
Josh Holmer
fbc93c0166 Lint against needless uses of collect()
Handles cases of `.collect().len()`, `.collect().is_empty()`, and
`.collect().contains()`. This lint is intended to be generic enough to
be added to at a later time with other similar patterns that could be
optimized.

Closes #3034
2018-09-03 23:29:44 -04:00
Nick Cameron
4050a68989 Make Default do what default used to do 2018-09-04 09:13:48 +12:00
Philipp Hansch
20318ebc22
Cleanup old min_version stuff
This cleans up a few leftover things after
https://github.com/rust-lang-nursery/rust-clippy/pull/3018
2018-09-03 22:27:35 +02:00