731 commits

Author	SHA1	Message	Date
Matt Kraai	de3bdf5826	Set show_code_when_inline to true ... Fixes #1902	2017-07-24 06:37:12 -07:00
Jay Hardee	f17def5801	Use if let over match.	2017-07-22 19:54:44 -04:00
Jay Hardee	83a6dbc828	Fix lint descriptions.	2017-07-22 19:49:47 -04:00
Jay Hardee	2abd1f73d9	Add lint for digit grouping.	2017-07-22 17:49:45 -04:00
Oliver Schneider	68948a5654	Fix various needless_range_loop false positives	2017-07-16 19:34:38 +02:00
Matt Kraai	7131fdad38	Use token_to_string instead of binop_to_string ... Fixes #1887	2017-07-13 08:27:57 -07:00
Oliver Schneider	e80d883bf1	Run rustfmt	2017-07-10 10:21:21 +02:00
Oliver Schneider	a82cd77b2b	Rustup to *rustc 1.20.0-nightly (d84693b93 2017-07-09)*	2017-07-10 10:17:40 +02:00
uHOOCCOOHu	14a1a08b5e	Search continue in return expr.	2017-07-05 15:57:29 +08:00
Oliver Schneider	1788f7bcde	Merge pull request #1847 from Manishearth/nested_while_let ... don't lint while_let_on_iterator on nested loops	2017-07-04 16:05:24 +02:00
Oliver Schneider	23b4ad501f	Run rustfmt	2017-06-29 16:07:43 +02:00
messense	8ac0388307	Fix compilation on rustc 1.20.0-nightly (69c65d296 2017-06-28)	2017-06-29 21:38:25 +08:00
Oliver Schneider	6a2525ccb8	Merge pull request #1536 from CBenoit/master ... Add lint `&ref x` patterns that could be just `x`	2017-06-28 18:45:51 +02:00
Oliver Schneider	d0650ae144	Update for latest master	2017-06-28 11:02:27 +02:00
Benoît CORTIER	e9964e762f	Improve needless_borrowed_ref lint doc.	2017-06-26 14:42:24 +02:00
Benoît CORTIER	1cae3366ea	Add needless borrowed ref lint (WIP).	2017-06-24 12:04:56 +02:00
Andre Bogus	88aa04dfa5	don't lint while_let_on_iterator on nested loops ... The problem is with a nested loop, the iterator may well be reused. This changeset introduces a false negative, when the iterator is initialized within the outer loop. A further PR could get rid of this false negative by checking if the iterator is indeed initialized within the outer loop.	2017-06-23 18:29:18 +02:00
Seo Sanghyeon	745233f3ab	Use span_lint_and_sugg	2017-06-22 03:04:04 +09:00
Oliver Schneider	38925a55b7	Replace Range::step_by checking with Iterator::step_by	2017-06-18 16:12:04 +02:00
mcarton	9881b15822	Ignore mix of {,non-}sugared doc in doc_markdown	2017-06-17 18:24:23 +02:00
mcarton	349b45bb99	Fix spans in all cases in doc_markdown	2017-06-17 18:23:37 +02:00
mcarton	aaf9bce905	Fix spans in doc_markdown in most cases	2017-06-17 18:23:37 +02:00
mcarton	d2ef1b318d	Rewrite doc_markdown to use pulldown-cmark	2017-06-17 18:23:37 +02:00
mcarton	9c9ad3e281	Add itertools and pulldown-cmark dependencies	2017-06-17 18:22:49 +02:00
messense	16a958b103	rustup to rustc 1.19.0-nightly (258ae6dd9 2017-06-15)	2017-06-16 11:57:44 +08:00
scott-linder	1ce3cbf9c4	Ignore new-without-default lint when new method has generic types ... There may be no sensible `Default` impl if the result of `new` depends on a type parameter.	2017-06-14 12:58:22 -04:00
Oliver Schneider	7056018335	Merge pull request #1501 from scott-linder/types-borrow-box ... Types borrow box	2017-06-13 11:30:52 +02:00
Erick Tryzelaar	8c235d19bc	in_macro check in NEEDLESS_RETURN ... This allows you to define a macro like `try!(...)` that embeds an early exit without emitting the "needless_return" warning. Closes #1271.	2017-06-12 19:06:37 -07:00
Andre Bogus	3a8e4c33bd	deal with multiple prefixed zeros in literals	2017-06-12 20:41:00 +02:00
scott-linder	1a50755f21	Document check_ty and its new is_local arg.	2017-06-12 08:43:02 -04:00
scott-linder	49bba315e4	Merge nested if into adjacent if_let_chain!	2017-06-12 08:38:29 -04:00
Cameron Steffen	1a453bf72c	fix another never_loop	2017-06-11 18:37:59 -05:00
Cameron Steffen	8b00f826d7	Merge branch 'master' into never_loop	2017-06-11 18:25:26 -05:00
scott-linder	74ebe6e69e	Add check_local to TypePass for BORROWED_BOX ... Adds a boolean flag to indicate whether the current type in `check_ty` is in a local declaration, as only the borrowed box lint should consider these types.	2017-06-11 12:20:20 -04:00
scott-linder	c29f5ea83b	Commit updated example stderr	2017-06-11 12:19:11 -04:00
scott-linder	deef81a3fc	Use span_suggestion in borrowed_box lint	2017-06-11 12:19:11 -04:00
scott-linder	e6eaa726e2	Recurse into inner type when not &Box<T>	2017-06-11 12:19:11 -04:00
scott-linder	80cb48ca1a	Actually fix the lint applied	2017-06-11 12:19:11 -04:00
scott-linder	a4c4da1c4b	Fix typo in types check	2017-06-11 12:19:11 -04:00
scott-linder	711cad188a	check for borrowed box types	2017-06-11 12:19:11 -04:00
Manish Goregaokar	55cb63adfe	Bump to 0.0.139	2017-06-10 22:07:09 -07:00
Eduard-Mihai Burtescu	50b3d7ee9d	Do not use .sty except for matching on it.	2017-06-11 06:24:13 +03:00
Eduard-Mihai Burtescu	e4ca0e515f	Remove uses of span_if_local.	2017-06-11 06:15:53 +03:00
Eduard-Mihai Burtescu	e073dfe9a2	Abide by the common rustc::ty conventions.	2017-06-11 05:57:25 +03:00
Eduard-Mihai Burtescu	cd89737b21	Update for rustc 1.19.0-nightly (4bf5c99af 2017-06-10).	2017-06-11 05:34:47 +03:00
Anders Kaseorg	00b43687e5	Pass extra parameter to CrateStore::item_children for rustc nightly ... rust-lang/rust#42507 Signed-off-by: Anders Kaseorg <andersk@mit.edu>	2017-06-10 01:41:17 -04:00
mcarton	bb0b597f05	Check for for loop desugaring in highering	2017-06-08 20:17:10 +02:00
Andre Bogus	a648cfeae1	better naming, Iterator::eq	2017-06-07 05:40:57 +02:00
Andre Bogus	8122d3e8cb	Check for AsRef/AsMut arguments in wrong_self_convention ... This fixes #451	2017-06-06 19:26:50 +02:00
mcarton	01cae3fd6d	Rustup to *rustc 1.19.0-nightly (0418fa9d3 2017-06-04)*	2017-06-05 21:49:26 +02:00
Eduard-Mihai Burtescu	010974fafe	Finish rustup.	2017-06-05 00:28:01 +03:00
mcarton	edef6c53c0	Continue work on rustup	2017-06-04 20:42:13 +02:00
messense	67cccc5c16	Try to fix compilation error on rustc 1.19.0-nightly (4ed2edaaf 2017-06-01)	2017-06-02 12:13:04 +08:00
Cameron Steffen	4f374824b1	fix never_loop	2017-06-01 21:31:42 -05:00
Cameron Steffen	a73edc0944	add tests and fixes	2017-06-01 00:06:45 -05:00
Cameron Steffen	20728fb0d0	fix never_loop	2017-05-30 22:46:02 -05:00
Manish Goregaokar	8d3c48601d	Rustup to rustc 1.19.0-nightly (557967766 2017-05-26)	2017-05-26 22:25:58 -07:00
Georg Brandl	3ba4e8b3fa	Demote the never_loop lint to Allow for now. ... Also add "known problem" to the description, with link to #1586.	2017-05-26 18:02:43 +02:00
Georg Brandl	06472ca651	Update to fix array_indexing failures: RangeInclusive::NonEmpty is gone	2017-05-26 16:54:07 +02:00
Oliver Schneider	ff873cc900	Rustup to rustc 1.19.0-nightly (5b13bff52 2017-05-23)	2017-05-24 14:19:30 +02:00
messense	30b94b0fb0	Fix build failure on rustc 1.19.0-nightly (0ed1ec9f9 2017-05-18)	2017-05-19 16:54:02 +08:00
Andre Bogus	e75d7ffd2d	distinguish debug_assert	2017-05-15 22:49:20 +02:00
mcarton	b6326121ab	Fix span in blacklisted_name	2017-05-14 14:58:16 +02:00
Oliver Schneider	4d5e25f31d	Update to rustc 1.19.0-nightly (826d8f385 2017-05-13) ... fixes #1759, #1758	2017-05-14 09:56:10 +02:00
Oliver Schneider	dfc7d2afd4	Run rustfmt	2017-05-12 12:09:52 +02:00
Oliver Schneider	29cb2f7eba	Fix various wrong uses of NestedVisitorMap::All	2017-05-12 12:02:42 +02:00
Oliver Schneider	672045689e	Fix #1730	2017-05-11 19:02:19 +02:00
Oliver Schneider	51f6aeae51	Reduce code duplication	2017-05-11 19:00:14 +02:00
Oliver Schneider	81b35d197b	Fixes #1735	2017-05-11 16:32:06 +02:00
Oliver Schneider	2cd3366817	Fixes #443	2017-05-10 13:42:19 +02:00
Oliver Schneider	5997fb952f	Fix a future compat lint that we triggered	2017-05-10 09:21:21 +02:00
Oliver Schneider	3b3e47f451	Merge pull request #1738 from Manishearth/serde ... Update serde to 1.0	2017-05-10 08:55:36 +02:00
Oliver Schneider	f48281b632	Split high-cyclomatic-complexity function into two	2017-05-09 17:15:28 +02:00
Oliver Schneider	a67774530f	Don't trigger some lints inside macros	2017-05-09 17:15:13 +02:00
Oliver Schneider	d2dab198fa	Forgot doc comments	2017-05-09 16:02:48 +02:00
Oliver Schneider	dee53fa1e2	Merge pull request #1728 from Manishearth/inspector ... Print type adjustments in the inspector	2017-05-09 15:26:01 +02:00
Oliver Schneider	31b2bf4ab9	Update our config reading to serde 1.0	2017-05-09 15:23:38 +02:00
Oliver Schneider	8225c23a33	Update to serde 1.0	2017-05-09 15:23:10 +02:00
Niklas Fiekas	956043e319	Add KiB to doc-valid-idents	2017-05-06 21:31:54 +02:00
Luis de Bethencourt	50b6dd43e2	fix typo in eval_order_dependence.rs ... Fixing a "the the" to "the".	2017-05-05 17:52:01 +01:00
Oliver Schneider	eb93058dd5	Also print type adjustments in the inspector	2017-05-05 14:25:54 +02:00
Tatsuyuki Ishi	7e514cb55f	Fix for rustc-1.19.0-nightly (2017-04-04)	2017-05-03 22:58:23 +09:00
Oliver Schneider	1522a4913f	Run rustfmt	2017-05-03 14:13:50 +02:00
Oliver Schneider	a6c8464dde	Update to rustc 1.19.0-nightly (6a5fc9eec 2017-05-02)	2017-05-03 12:51:47 +02:00
Oliver Schneider	b84e71c2b1	Update to latest nightly	2017-05-02 16:56:36 +02:00
Boris-Chengbiao Zhou	36f75e8015	Fix two doc comments	2017-05-01 16:57:27 +02:00
mcarton	76041b8ffa	Rustup to *rustc 1.19.0-nightly (06fb4d256 2017-04-30)*	2017-05-01 13:43:16 +02:00
Oliver Schneider	88d3898426	Fix dogfood tests	2017-04-28 18:13:09 +02:00
Oliver Schneider	e3084cc085	Fix #1698 (ICE regression in clippy's const eval)	2017-04-28 18:10:10 +02:00
Oliver Schneider	7aa42073f2	Fix op_ref false positives	2017-04-28 17:03:47 +02:00
Oliver Schneider	81a55330dc	Use utils::is_copy instead of hand-rolling it	2017-04-28 17:03:18 +02:00
Oliver Schneider	b8d577d82d	Rustup	2017-04-28 13:00:42 +02:00
Oliver Schneider	9abef6affd	Bump the version	2017-04-27 14:13:14 +02:00
Oliver Schneider	3b73663506	Update to latest rustc version	2017-04-27 14:00:35 +02:00
Oliver Schneider	fed8491476	Merge pull request #506 from yati-sagade/master ... Lint for pointing out needless continue statements, fixes #111	2017-04-25 12:37:24 +02:00
Trevor Spiteri	45bbff66cd	Add "MinGW" to doc-valid-idents	2017-04-25 11:38:37 +02:00
Oliver Schneider	68369e5d37	Merge remote-tracking branch 'origin/master' into yati_master	2017-04-25 10:31:40 +02:00
Oliver Schneider	216ce57fee	Update for changes in rustc	2017-04-24 13:35:14 +02:00
Bastian Köcher	4024f2ce5b	Fixes compilation error with latest nightly rust (1.18.0-nightly (9f2abadca 2017-04-18))	2017-04-19 12:17:12 +02:00
Mrmaxmeier	89f0f323bb	Rustup to 1.18.0-nightly (d5cf1cb64 2017-04-15)	2017-04-16 18:38:17 +02:00
Yati Sagade	cac15d24f9	needless_continue: Remove indentation of suggestion code. ... As per a suggestion by Oliver on the PR thread, maintaining indentation in the suggested code is futile because of the changes in the compiler and the messiness of real-world code. rustfmt will do the indentation if required, so we don't need to do it.	2017-04-13 21:48:52 +02:00
Oliver Schneider	5842463562	Run rustfmt	2017-04-12 11:06:32 +02:00
Oliver Schneider	7ee0d4f9c2	Dogfood tests	2017-04-12 10:55:34 +02:00
Oliver Schneider	679e98530a	Merge remote-tracking branch 'origin/master' into yati	2017-04-11 16:16:10 +02:00
Oliver Schneider	5f85ea8ef4	Add newline at end of file	2017-04-11 15:54:48 +02:00
Oliver Schneider	21d8fbd082	Don't lint for lifetime bounds required by traits	2017-04-11 15:44:13 +02:00
Oliver Schneider	856b1f1242	Remove now useless allow(unused_lifetimes) from clippy	2017-04-11 14:46:54 +02:00
Oliver Schneider	2eae102cd1	Don't lint lifetimes after trait objects	2017-04-11 14:29:58 +02:00
Oliver Schneider	8bb0a4d667	Fix more doc issues	2017-04-11 14:10:11 +02:00
Oliver Schneider	9a4c0a1c72	Don't lint about unused lifetimes if the lifetimes are used in the body of the function	2017-04-11 14:09:58 +02:00
Oliver Schneider	38b2215060	Dogfood	2017-04-10 15:14:54 +02:00
Oliver Schneider	03a0b18a85	Fix some doc errors	2017-04-10 15:10:29 +02:00
Oliver Schneider	b76ce176bb	Fix op_ref in case of nonexisting operations	2017-04-10 15:10:19 +02:00
Yati Sagade	8ea6d6a8d2	needless_continue: Refactor to use stuff from utils, and move some stuff to utils. ... I had my own implementation of what `trim_multiline()` seems to be doing, so I just started using `trim_multiline()`. Some other functions, like those block alignment, are general enough to be used elsewhere, so moved them to utils.	2017-04-09 14:07:11 +02:00
Yati Sagade	38238f576d	[needless_continue] Add comments explaining terminology used thoughout in the code.	2017-04-08 23:30:34 +02:00
Yati Sagade	9396120008	More dogfood test fixes.	2017-04-08 23:30:34 +02:00
Yati Sagade	7b4a12fd21	Fix lint warnings from dogfooding tests.	2017-04-08 23:30:34 +02:00
Yati Sagade	240471f926	Needless continue: This is a complete rewrite of this lint as an early-pass lint. ... The previous version had troubles computing suggestions without macro expansions creeping in. This fixes it by using original_sp, which works on AST nodes.	2017-04-08 23:30:34 +02:00
Oliver Schneider	c657d603ba	Bump the version	2017-04-07 11:25:00 +02:00
Oliver Schneider	f1e905f620	Reintroduce #768 so we can publish	2017-04-07 11:21:39 +02:00
Oliver Schneider	3052000c73	Merge pull request #1649 from ensch/master ... Fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30)	2017-04-07 11:13:44 +02:00
Oliver Schneider	a679f41fa3	Fix fallout	2017-04-06 16:49:13 +02:00
Oliver Schneider	6d921b4734	fix various rustup failures	2017-04-06 16:48:48 +02:00
Peter Gerber	71a788cbd7	correct error message for option_map_unwrap_or_else lint ... Remove erroneous "with " in suggested alternative call.	2017-04-01 15:54:27 +02:00
Enrico Schmitz	7a4f7c335b	Remove unused cs parameter for is_macro and friends	2017-04-01 00:14:04 +02:00
Enrico Schmitz	8aef64dfe8	Fix src/needless_bool.rs by using ExprBlock(block) = then	2017-03-31 23:46:08 +02:00
Enrico Schmitz	8297c19fcc	Fixing src/copies.rs and src/entries.rs by using ExprBlock(block) = then.node	2017-03-31 23:36:45 +02:00
Enrico Schmitz	8f9fb97eb6	First try for a fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30	2017-03-31 19:23:35 +02:00
Oliver Schneider	0ae1a77a2e	Do some additional cleanup around InternedString and Symbol	2017-03-30 10:21:13 +02:00
Oliver Schneider	d9e69a70df	Fix fallout	2017-03-30 09:46:04 +02:00
Oliver Schneider	5de367f793	Don't create additional references when invoking binary operators	2017-03-30 09:46:00 +02:00
Oliver Schneider	5547fbb770	Fix accidental newline in diagnostic and missing entries in lint_array!	2017-03-24 10:21:12 +01:00
Oliver Schneider	8ae82eb4ab	Merge remote-tracking branch 'origin/master' into 1537-drop_copy	2017-03-24 10:11:46 +01:00
Oliver Schneider	4f473f7f60	Merge pull request #1617 from sinkuu/proc_macro_pass_by_value ... Filter out proc_macro_derive functions	2017-03-24 10:10:24 +01:00
Oliver Schneider	b1b43da20a	Merge pull request #1627 from Manishearth/dont-panic ... Don't panic if traits not found	2017-03-24 10:09:59 +01:00
sinkuu	a712271df6	Filter out proc_macro_derive functions (fixes #1615)	2017-03-21 17:09:21 +09:00
Oliver Schneider	f2e8f526e6	Run rustfmt	2017-03-21 08:57:54 +01:00
Enrico Schmitz	fa0a670201	Simplify attr_is_cfg in returns.rs	2017-03-21 00:34:05 +01:00
Enrico Schmitz	f8df4aed0f	Fix for rustc 1.17.0-nightly (6eb9960d3 2017-03-19)	2017-03-21 00:22:19 +01:00
Andre Bogus	30e0c0fc96	fix typos	2017-03-17 21:21:32 +01:00
Andre Bogus	c2ff30375a	Don't panic if traits not found	2017-03-16 08:57:17 +01:00
Andre Bogus	bc934a3ed9	Rustup: Add ExprKind::Catch	2017-03-16 00:56:21 +01:00
Oliver Schneider	4c6e225830	Run rustfmt	2017-03-13 11:40:56 +01:00
Oliver Schneider	2d145b2ef5	don't lint macro_rules! in items_after_statements	2017-03-13 11:09:56 +01:00
Oliver Schneider	40d50fe8b2	Don't lint nan_cmp and zero_ptr in constants	2017-03-07 12:58:07 +01:00
Oliver Schneider	2a8fca599b	Mostly apply rustfmt	2017-03-05 10:27:20 +01:00
Enrico Schmitz	1f8b212298	CFG::new now wants Body instead of Expr	2017-03-05 02:15:39 +00:00
Oliver Schneider	ac48e09255	Simplify snippet body by forwarding to snippet_opt	2017-03-03 16:56:35 +01:00
Oliver Schneider	a33930f815	Fix single-match-else in the presence of macros expressions expanding to blocks	2017-03-03 16:56:16 +01:00
Oliver Schneider	a161d3f8f4	deduplicate single_match_else reporting	2017-03-03 15:44:23 +01:00