flip1995
b98e2ec527
Fix ICE in redundant_pattern_matching
2021-07-16 10:45:28 +02:00
flip1995
69fbd64e2a
Merge remote-tracking branch 'upstream/master' into rustup
2021-07-15 10:32:06 +02:00
bors
4acbff9eb0
Auto merge of #7437 - ebobrow:redundant-closure-move, r=flip1995
...
suggest `&mut` for redundant FnMut closures
fixes #6903
changelog: suggest `&mut` for redundant FnMut closures
2021-07-14 15:15:28 +00:00
Elliot Bobrow
4c398e07e0
suggest &mut for redundant FnMut closures
2021-07-14 07:56:27 -07:00
bors
8131445e53
Auto merge of #7446 - Y-Nak:fix-7445, r=xFrednet,flip1995
...
`default_numeric_fallback`: Fix FP with floating literal
Fix #7445
changelog: `default_numeric_fallback`: Fix FP with floating literal
2021-07-13 14:31:02 +00:00
Cameron Steffen
e6ab222b81
Refactor format macro parsing
2021-07-13 08:57:16 -05:00
Yoshitomo Nakanishi
4e8cd4d346
Fix NumericLiteral::format that may produce a invalid literal
2021-07-13 22:57:02 +09:00
Vadim Petrochenkov
075a28996c
rustc_span: Revert addition of proc_macro field to ExpnKind::Macro
...
The flag has a vague meaning and is used for a single diagnostic change that is low benefit and appears only under `-Z macro_backtrace`.
2021-07-10 23:03:35 +03:00
flip1995
d2c8f50bbe
Rename is_allowed -> is_lint_allowed
2021-07-09 15:06:12 +02:00
flip1995
5add651223
Remove lints_enabled function
...
This function was redundant with the is_allowed function. Now is_allowed
is used everywhere lints_enabled was used before.
2021-07-09 15:00:24 +02:00
flip1995
795868dd88
Rename run_lints -> lints_enabled
2021-07-08 15:45:19 +02:00
Aman Arora
f0f3b3acf8
Make type_implements_trait not a query
2021-07-06 14:38:10 -04:00
Mateusz Gacek
59a164e86c
Add new lint: strlen_on_c_strings
2021-07-05 11:10:45 +02:00
Niko Matsakis
26e57f05cc
revert broken formatting
2021-07-04 12:50:41 -04:00
Niko Matsakis
89f6c4cfe2
allow inference vars in type_implements_trait
2021-07-04 11:28:20 -04:00
bors
7cd0643eb2
Auto merge of #86782 - flip1995:clippyup, r=Manishearth
...
Update Clippy
Biweekly Clippy Update
r? `@Manishearth`
2021-07-02 02:56:45 +00:00
flip1995
ebe52869a3
Merge commit '61eb38aeda6cb54b93b872bf503d70084c4d621c' into clippyup
2021-07-01 18:17:38 +02:00
bjorn3
59cf7e3882
Rename all_crate_nums query to crates and remove useless wrapper
2021-07-01 16:51:11 +02:00
Mara Bos
38569c03eb
Don't suggest unstable and doc(hidden) variants.
2021-06-26 15:28:38 +02:00
Igor Aleksanov
28d3873ef5
Do not spawn blacklisted_name lint in test context
...
Fix detecting of the 'test' attribute
Update UI test to actually check that warning is not triggered in the test code
Fix approach for detecting the test module
Add nested test case
Remove code duplication by extracting 'is_test_module_or_function' into 'clippy_utils'
Cleanup the code
2021-06-25 12:36:22 +03:00
Alexander Melentyev
dab42cff02
Delete spaces
2021-06-21 12:11:37 +03:00
flip1995
8302eefacd
Bump Clippy version -> 0.1.55
2021-06-17 10:23:08 +02:00
flip1995
e3eede7b90
Merge remote-tracking branch 'upstream/master' into rustup
2021-06-17 10:21:47 +02:00
Ryan Levick
611b74e1fe
Add support for using qualified paths with structs in expression and pattern
...
position.
2021-06-10 13:18:41 +02:00
Cameron Steffen
b792bb301c
Factor out match_var
2021-06-09 09:47:42 -05:00
bors
da0538eaca
Auto merge of #7330 - xFrednet:0000-refactor-map-identity, r=flip1995
...
Refactoring identity function lints
I've noticed that we have several lints that all check for identity functions and each used their own check implementation. I moved the `is_expr_identity_function` function to `clippy_utils` and adapted all lints to reuse that one function. This should make the addition of new lints like this also easier in the future.
I've also moved the `map_identity` lint into the `methods` module. It's probably the best to review this PR by checking each commit individually. And that's it, have a great day 🙃
changelog: none
2021-06-09 08:27:05 +00:00
bors
07217e3370
Auto merge of #7262 - Jarcho:while_let_on_iter_closure, r=xFrednet,flip1995
...
fix `while_let_on_iterator` suggestion in a closure
fixes : #7249
A future improvement would be to check if the closure is being used as `FnOnce`, in which case the original suggestion would be correct.
changelog: Suggest `&mut iter` inside a closure for `while_let_on_iterator`
2021-06-08 15:52:40 +00:00
xFrednet
967d815a42
Extracting is_expr_identity_function into clippy_utils for reusability
2021-06-07 22:42:11 +02:00
Felix S. Klock II
b95e1f7b3d
Revert clippy's path to the copy intrinsics (part of reverting PR 81238).
2021-06-04 16:44:28 -04:00
Mara Bos
25639101dd
Don't treat cfg!() as a constant.
2021-06-04 10:47:03 +02:00
flip1995
6c27482115
Merge commit '3ae8faff4d46ad92f194c2a4b941c3152a701b31' into clippyup
2021-06-03 08:41:37 +02:00
Jason Newcomb
cfddf0927b
Fix type checks for manual_str_repeat
2021-05-31 09:37:13 -04:00
Jason Newcomb
97311f0906
Add lint manual_str_repeat
2021-05-30 23:26:48 -04:00
Cameron Steffen
f3e77a454a
Fix allow on some statement lints
2021-05-26 22:07:53 -05:00
mbartlett21
0c017ea058
Remove semicolons in clippy_utils
2021-05-25 02:12:27 +00:00
Cameron Steffen
7f340578cc
Hash Symbol directly
2021-05-24 10:51:40 -05:00
Cameron Steffen
9d61b4e081
Fix SpanlessEq for GenericArg::Const
2021-05-24 10:51:40 -05:00
Pietro Albini
91aa821745
remove cfg(bootstrap)
2021-05-24 11:07:48 -04:00
Cameron Steffen
0ebd5018bf
Add a short-circuiting case
2021-05-24 09:48:05 -05:00
Cameron Steffen
24743b3968
Use UnhashMap
2021-05-24 09:48:05 -05:00
Cameron Steffen
f21d909e62
Use FxHasher
2021-05-24 09:31:11 -05:00
Cameron Steffen
27ac647649
Use discriminant instead of stable_hash
2021-05-24 09:31:09 -05:00
Cameron Steffen
e027b6bc49
Minor SpanlessHash improvements
2021-05-24 09:30:52 -05:00
Jason Newcomb
7db0e4f791
Suggest &mut iter inside a closure for while_let_on_iterator
2021-05-21 12:27:40 -04:00
Jason Newcomb
f355aebf10
Move needless_borrow to style
2021-05-21 11:24:52 -04:00
Jason Newcomb
6d4dc35882
Improve needless_borrow lint
...
Suggest changing usages of ref bindings to match the new type
Split out some cases into new lint `ref_binding_to_reference`
2021-05-20 09:03:47 -04:00
flip1995
97705b7ea6
Merge commit '9e3cd88718cd1912a515d26dbd9c4019fd5a9577' into clippyup
2021-05-20 13:07:57 +02:00
flip1995
451ff5668b
Merge remote-tracking branch 'upstream/master' into rustup
2021-05-20 12:05:02 +02:00
flip1995
9586ddb046
Fix fallout from not ignoring warnings anymore
2021-05-18 11:08:19 +02:00
flip1995
ff452d5ba6
Deny warning in every main sub-crate
...
This enables the same warnings that are enabled in `clippy_lints` also
in `clippy_utils` and `clippy_dev`. Then it makes sure, that the
`deny-warnings` feature is passed down to `clippy_lints` and
`clippy_utils` when compiling Clippy.
2021-05-18 11:05:48 +02:00
