bors
5ead90f13a
Auto merge of #12150 - ithinuel:add_misleading_use_of_ok, r=y21
...
Add lint for `unused_result_ok`
This PR adds a lint to capture the use of `expr.ok();` when the result is not _really_ used.
This could be interpreted as the result being checked (like it is with `unwrap()` or `expect`) but
it actually only ignores the result.
`let _ = expr;` expresses that intent better.
This was also mentionned in #8994 (although not being the main topic of that issue).
changelog: [`misleading_use_of_ok`]: Add new lint to capture `.ok();` when the result is not _really_ used.
2024-08-06 19:01:41 +00:00
Jason Newcomb
4e57b2c46f
Use -D warnings instead of deny-warnings feature.
2024-08-06 10:46:39 -04:00
Jason Newcomb
c2186e14de
Make cargo dev deprecate require a reason
2024-08-05 09:17:46 -04:00
Jason Newcomb
2c34d58159
Store deprecated lints as an array of tuples.
...
Remove legacy deprecations.
Remove "View Source" link for deprecated lints.
2024-08-05 09:15:55 -04:00
Alex Macleod
943a8e0646
Remove some miscellaneous #[allow]s
2024-07-29 19:57:39 +00:00
Wilfried Chauveau
182c26891e
Add lint for unused_result_ok
2024-07-29 17:56:45 +01:00
Jason Newcomb
78a750e890
Sort the config list using dev fmt
2024-07-28 00:55:46 -04:00
Jason Newcomb
e34c6dbae5
Refactor for using config values:
...
* Construct lint passes by taking `Conf` by reference.
* Use `HashSet` configs in less places
* Move some `check_crate` code into the pass constructor when possible.
2024-07-17 14:05:49 -04:00
J-ZhengLi
dcb6a54b80
fix wrong msrv import in new_lint template
2024-06-21 12:03:40 +08:00
Philipp Krones
89037ea18f
Merge remote-tracking branch 'upstream/master' into rustup
2024-05-30 09:44:14 +02:00
Kevin Reid
0f5338cd90
For restriction lints, replace “Why is this bad?” with “Why restrict this?”
...
The `restriction` group contains many lints which are not about
necessarily “bad” things, but style choices — perhaps even style choices
which contradict conventional Rust style — or are otherwise very
situational. This results in silly wording like “Why is this bad?
It isn't, but ...”, which I’ve seen confuse a newcomer at least once.
To improve this situation, this commit replaces the “Why is this bad?”
section heading with “Why restrict this?”, for most, but not all,
restriction lints. I left alone the ones whose placement in the
restriction group is more incidental.
In order to make this make sense, I had to remove the “It isn't, but”
texts from the contents of the sections. Sometimes further changes
were needed, or there were obvious fixes to make, and I went ahead
and made those changes without attempting to split them into another
commit, even though many of them are not strictly necessary for the
“Why restrict this?” project.
2024-05-23 15:51:33 -07:00
Philipp Krones
537ab6cc87
Bump clap version -> 4.4
...
Same version as most other crates in rustc are using
2024-05-03 11:36:42 +02:00
Philipp Krones
a0d562a183
Type safe CLI implementation for clippy-dev
...
Use the derive feature of `clap` to generate CLI of clippy-dev. Adding new
commands will be easier in the future and we get better compile time checking
through exhaustive matching.
2024-05-03 11:36:42 +02:00
Alex Macleod
1fff3bef4d
Add cargo dev setup toolchain
2024-04-16 18:28:07 +00:00
xFrednet
24d20b4eae
Set RUSTC_ICE=0 in uitests and cargo dev lint
2024-04-01 17:05:55 +02:00
Alex Macleod
a24d12b7aa
Enable unused_qualifications lint
2024-03-22 15:58:29 +00:00
Guillaume Gomez
d57d001543
Update cargo dev update_lints command to fix new warning emitted by duplicated_attributes
2024-03-09 12:43:19 +01:00
klensy
cdaccd7fce
bump itertools to 0.12
2024-02-25 13:14:07 +03:00
Peter Jaszkowiak
a456300af5
Stabilize LazyCell and LazyLock (lazy_cell)
2024-02-20 20:55:13 -07:00
Philipp Krones
4363278c73
Merge commit '2efebd2f0c03dabbe5c3ad7b4ebfbd99238d1fb2' into clippy-subtree-update
2024-05-21 10:39:30 -07:00
Philipp Krones
a5aaf33422
Merge commit 'ca3b393750ee8d870bf3215dcf6509cafa5c0445' into clippy-subtree-update
2024-04-18 17:48:52 +02:00
Philipp Krones
0ae4a048c6
Merge commit '9725c4a162502a02c1c67fdca6b797fe09b2b73c' into clippy-subtree-update
2024-04-04 19:52:55 +02:00
Philipp Krones
0e62b18435
Merge commit '9d6f41691ed9dbfaec2a2df2661c42451f2fe0d3' into clippy-subtree-update
2024-03-21 22:20:40 +01:00
Philipp Krones
7be6e2178e
Merge commit '10136170fe9ed01e46aeb4f4479175b79eb0e3c7' into clippy-subtree-update
2024-02-27 15:50:17 +01:00
Matthias Krüger
57f63a3a85
Rollup merge of #120345 - flip1995:clippy-subtree-update, r=Manishearth
...
Clippy subtree update
r? `@Manishearth`
Closes https://github.com/rust-lang/rust-clippy/issues/12148
2024-01-26 14:43:32 +01:00
Philipp Krones
798865c593
Merge commit '66c29b973b3b10278bd39f4e26b08522a379c2c9' into clippy-subtree-update
2024-01-25 19:17:36 +01:00
Nicholas Nethercote
9cbc5829a8
Rename the unescaping functions.
...
`unescape_literal` becomes `unescape_unicode`, and `unescape_c_string`
becomes `unescape_mixed`. Because rfc3349 will mean that C string
literals will no longer be the only mixed utf8 literals.
2024-01-25 12:28:11 +11:00
Philipp Krones
aa220c7ee7
Merge commit '26ac6aab023393c94edf42f38f6ad31196009643'
2024-01-11 17:27:03 +01:00
Philipp Krones
3596d44988
Merge commit 'a859e5cc1ce100df22346a1005da30532d04de59' into clippyup
2023-12-16 14:12:50 +01:00
Philipp Krones
c9a43b18f1
Merge commit 'f0cdee4a3f094416189261481eae374b76792af1' into clippy-subtree-sync
2023-12-01 18:21:58 +01:00
Nicholas Nethercote
fa7cd2548c
Update itertools to 0.11.
...
Because the API for `with_position` improved in 0.11 and I want to use
it.
2023-11-22 08:13:21 +11:00
Philipp Krones
6246f0446a
Merge commit 'edb720b199083f4107b858a8761648065bf38d86' into clippyup
2023-11-16 19:13:24 +01:00
Philipp Krones
77c1e3aaa1
Merge commit '09ac14c901abc43bd0d617ae4a44e8a4fed98d9c' into clippyup
2023-11-02 17:35:56 +01:00
Philipp Krones
8ebed4cc1a
Merge commit 'b105fb4c39bc1a010807a6c076193cef8d93c109' into clippyup
2023-10-06 17:35:45 +02:00
Philipp Krones
cc61aeea54
Merge commit '080b587854a73f2a8cbaecff1884860a78e2ff37' into clippyup
2023-08-24 21:32:12 +02:00
Philipp Krones
f730a2655a
Merge commit '1e8fdf492808a25d78a97e1242b835ace9924e4d' into clippyup
2023-08-11 14:05:13 +02:00
Philipp Krones
b0e64a9c09
Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup
2023-07-31 23:53:53 +02:00
Philipp Krones
d6d530fd0b
Merge commit 'd9c24d1b1ee61f276e550b967409c9f155eac4e3' into clippyup
2023-07-17 10:22:32 +02:00
Philipp Krones
cb3ecf7b79
Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup
2023-07-02 14:59:02 +02:00
Philipp Krones
e6dc0efc00
Merge commit '30448e8cf98d4754350db0c959644564f317bc0f' into clippyup
2023-06-02 11:41:57 +02:00
Philipp Krones
7e9abb311d
Merge commit '371120bdbf58a331db5dcfb2d9cddc040f486de8' into clippyup
2023-05-05 17:45:49 +02:00
Philipp Krones
a1b75c5108
Merge commit 'a3ed905928a03b6e433d0b429190bf3a847128b3' into clippyup
2023-04-23 13:28:56 +02:00
Philipp Krones
6b95029f17
Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup
2023-04-11 15:31:08 +02:00
Trevor Gross
4cf5bdc60c
Stabilize a portion of 'once_cell'
...
Move items not part of this stabilization to 'lazy_cell' or 'once_cell_try'
2023-03-29 18:04:44 -04:00
Jason Newcomb
0413fb35ba
Merge commit '149392b0baa4730c68f3c3eadf5c6ed7b16b85a4' into clippyup
2023-02-25 19:28:50 -05:00
Philipp Krones
e7fe1f9c14
Merge commit '0f7558148c22e53cd4608773b56cdfa50dcdeac3' into clippyup
2023-02-10 14:01:19 +01:00
Philipp Krones
d21616737b
Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyup
2023-01-12 19:48:13 +01:00
Philipp Krones
d05e2865a0
Merge commit 'd822110d3b5625b9dc80ccc442e06fc3cc851d76' into clippyup
2022-12-01 18:29:38 +01:00
Matthias Krüger
268d230231
Rollup merge of #104873 - RalfJung:therefore, r=Dylan-DPC
...
RefCell::get_mut: fix typo
and fix the same typo in a bunch of other places
2022-11-25 10:44:40 +01:00
Ralf Jung
424ae23958
RefCell::get_mut: fix typo
...
and fix the same typo in a bunch of other places
2022-11-25 08:52:06 +01:00
