Laura Peskin
74f4fd32e9
attempt to add check for mutation of range bound within loop; compiles but doesn't work as intended. pushed for feedback
2017-09-24 15:40:16 -04:00
Laura Peskin
319f12a4c4
implement lint for mutable range bound
2017-09-24 15:40:16 -04:00
Laura Peskin
b091fb9b24
add lint declaration and example that should trigger the lint
2017-09-24 15:40:16 -04:00
Oliver Schneider
4ab2223e59
Merge pull request #2060 from mrecachinas/feature/int-plus-one
...
Addresses #1955 - Suggests >= y + 1 become > y
2017-09-24 13:57:56 +02:00
Michael Recachinas
f571cf0b5e
Change rtype of int_plus_one detection to Option<String>
2017-09-24 12:31:12 +01:00
Michael Recachinas
9437d2909c
Change to returning Option<(bool, Option<String>)>
2017-09-24 10:30:29 +01:00
Michael Recachinas
fff35736e4
Remove old return-value
2017-09-24 09:58:58 +01:00
Manish Goregaokar
3509b0b40c
Merge pull request #2082 from rust-lang-nursery/rustup
...
Rust upgrade to rustc 1.22.0-nightly (14039a42a 2017-09-22)
2017-09-23 13:47:07 -07:00
Manish Goregaokar
a822cab01f
fix docs
2017-09-23 13:36:40 -07:00
Manish Goregaokar
287e997b1e
Bump to 0.0.163
2017-09-23 13:36:18 -07:00
Manish Goregaokar
50e410e796
Update test expectations
2017-09-23 13:35:06 -07:00
Manish Goregaokar
e3c4ec74d7
Rust upgrade to rustc 1.22.0-nightly (14039a42a 2017-09-22)
2017-09-23 13:30:29 -07:00
Michael Recachinas
21e9a1285d
Use span_lint_and_then as per feedback
2017-09-23 19:32:11 +01:00
Andre Bogus
1e0268fda8
avoid linting ptr_arg if .capacity() is called. Also suggest removing .as_str() where applicable.
...
THis fixes #2070 .
Also fixes a few formatting mishaps
2017-09-20 23:59:23 +02:00
Chris Emerson
9a0a8a0010
Move has_drop to the utils module.
2017-09-19 21:38:35 +01:00
Manish Goregaokar
c3df3bc681
Merge pull request #2069 from rust-lang-nursery/rustup
...
Rust upgrade to rustc 1.22.0-nightly (0701b37d9 2017-09-18)
2017-09-18 20:36:34 -07:00
Manish Goregaokar
31489d75a3
Bump to 0.0.162
2017-09-18 20:27:24 -07:00
Manish Goregaokar
35fa4429e3
Rust upgrade to rustc 1.22.0-nightly (0701b37d9 2017-09-18)
2017-09-18 20:23:08 -07:00
Martin Carton
0b64222a68
Fix case in doc_valid_idents
...
BibTeX and BibLaTeX use the usual capitalization of TeX tools:
- https://www.ctan.org/pkg/bibtex
- https://www.ctan.org/pkg/biblatex
2017-09-18 22:40:00 +02:00
Martin Carton
5d115c085e
Merge pull request #2066 from lucab/ups/doc-markdown
...
lints/doc_markdown: add two more entries
2017-09-18 22:34:43 +02:00
Chris Emerson
f680eb164d
Update unnecessary_operation and no_effect to not suggest removing
...
structs/enums wrappers when that type implements Drop as noted
in #2061 .
2017-09-18 20:07:33 +01:00
Luca Bruno
62ae6d2251
lints/doc_markdown: add two more entries
2017-09-18 14:44:28 +00:00
Michael Recachinas
bb40bd68a4
Add tests for 'int_plus_one'
2017-09-17 17:27:40 +01:00
Michael Recachinas
535302efda
Register 'int_plus_one' lint case in clippy_lints
2017-09-17 17:27:16 +01:00
Michael Recachinas
d7ea6addf0
( #1955 ): Suggests x > y over x >= y + 1 for ints
...
This module handles the following cases:
- `... >= ... + 1` and `... >= 1 + ...`
- `... - 1 >= ...` and `-1 + ... >= ...`
- `... + 1 <= ...` and `... + 1 <= ...`
- `... <= ... - 1` and `... <= -1 + ...`
Note: this only goes 1 level deep (i.e., does not constant-fold) and
does not currently simplify expressions. Examples of these
cases include:
```rust
let x = 1;
y >= y + x; // won't catch this case or any permutation
x + 1 >= y + 2; // won't catch this case
x + 1 - 1 >= y - 1 + 1; // WILL catch this case when it likely shouldn't
```
2017-09-17 17:18:12 +01:00
Oliver Schneider
2bb8efdb4d
Merge pull request #2058 from rust-lang-nursery/ptr_arg-vs-clone
...
add suggestions for .clone() in ptr_arg fns
2017-09-17 15:37:21 +02:00
llogiq
b3d8192e27
Merge pull request #2059 from marcusklaas/manual-slice-clone4
...
Also detect manual slice cloning
2017-09-17 10:21:43 +02:00
Marcus Klaas
48ed3c058f
Extend MANUAL_MEMCPY lint so that it also detects manual clones between slices
2017-09-16 19:17:22 -04:00
Marcus Klaas
a6206cc5f8
Add test for manual slice clones
2017-09-16 18:53:55 -04:00
Marcus Klaas
e461e3f915
Format loops.rs with latest stable rustfmt
2017-09-16 18:45:28 -04:00
llogiq
708a818094
Merge pull request #2057 from topecongiro/issue-1818
...
Enhance CHARS_*_CMP lint
2017-09-16 09:16:55 +02:00
llogiq
013b1f5923
Merge pull request #2056 from topecongiro/issue-1851
...
Add suggestion to needless_borrow
2017-09-16 09:13:13 +02:00
Andre Bogus
72be166756
add suggestions for .clone() in ptr_arg fns
2017-09-16 09:10:26 +02:00
topecongiro
d5d300c034
Update tests
2017-09-16 14:50:30 +09:00
topecongiro
81f5c69131
Enhance CHARS_*_CMP lint
2017-09-16 14:50:07 +09:00
topecongiro
d8afe2ccbc
Update tests
2017-09-16 11:27:46 +09:00
topecongiro
197664e989
Add suggestion to needless_borrow
2017-09-16 11:27:24 +09:00
Oliver Schneider
f64bae4ae3
Merge pull request #2052 from topecongiro/issue-1990
...
Add ExprLoop to contains_continue_expr()
2017-09-15 09:21:46 +02:00
Seiichi Uchida
0215a1acb0
Update a test
2017-09-14 22:27:29 +09:00
Seiichi Uchida
1f6801dd6a
Add ExprLoop to contains_continue_expr()
2017-09-14 22:26:59 +09:00
Seiichi Uchida
9f0cc93ac6
Bump version
2017-09-14 22:24:00 +09:00
Oliver Schneider
86d609fdf6
Version bump
2017-09-14 09:13:54 +02:00
Oliver Schneider
33e4b3b552
Merge pull request #2049 from topecongiro/rustc-fix
...
rustc fix
2017-09-14 09:11:10 +02:00
topecongiro
49d388d4ec
Remove '\t' from .stderr
...
to make cargo test pass
2017-09-14 13:18:34 +09:00
topecongiro
86e178e786
Add a missing argument
2017-09-14 13:18:08 +09:00
Oliver Schneider
b2c88b0a35
Merge remote-tracking branch 'origin/master' into rustup
2017-09-13 15:41:09 +02:00
Oliver Schneider
32a9394490
Rustup
2017-09-13 15:34:04 +02:00
llogiq
916f2f9f71
Merge pull request #2046 from siiptuo/small-doc-fixes
...
Small documentation fixes
2017-09-12 20:12:48 +02:00
Tuomas Siipola
d768fe8c16
Fix link in trivial_regex
2017-09-12 19:08:25 +03:00
Tuomas Siipola
6d3db724b7
Fix empty documentation in unit_expr
2017-09-12 19:08:25 +03:00
