flip1995
dae5c9c685
AbsolutePathBuffer -> AbsolutePathPrinter
2019-03-16 11:17:36 +01:00
flip1995
2d8618e95c
Remove ty::TyKind from eta_reduction and replace it with ty::Ty
2019-03-16 11:10:33 +01:00
flip1995
8eadbfd35b
parent_def_id -> parent
2019-03-15 23:44:04 +01:00
flip1995
dcbd3aefa2
item_path_str -> def_path_str
2019-03-15 23:43:42 +01:00
flip1995
31435cd7f5
Reimplement AbsolutePathBuffer
2019-03-15 23:42:46 +01:00
bors
54e20519d2
Auto merge of #3886 - phansch:rustfix_useless_asref, r=flip1995
...
Enable rustfix for `useless_asref` lint tests
cc #3630
2019-03-15 09:43:29 +00:00
Philipp Hansch
0019ca5e4f
Enable rustfix for useless_asref lint tests
2019-03-15 07:29:12 +01:00
bors
e7806413c6
Auto merge of #3883 - daxpedda:missing_docs_in_private_items, r=phansch
...
Add `doc(include = ...)` detection to `missing_docs_in_private_items`
The whole `missing documentation in crate` part doesn't have any tests. If I should add test cases tell me.
2019-03-15 06:18:28 +00:00
daxpedda
9061fd3199
Another test for missing crate documentation.
2019-03-14 19:38:41 +01:00
daxpedda
e1096e3310
Add a test for doc(include)
...
Tiny code improvement.
2019-03-14 19:33:06 +01:00
daxpedda
177b3b27c4
Add doc(include = ...) detection to missing_docs_in_private_items
2019-03-14 18:32:39 +01:00
bors
bb41b16423
Auto merge of #3879 - phansch:rustfix_string_lit_as_bytes, r=flip1995
...
Run rustfix for string_lit_as_bytes tests
This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.
cc #3603 , #2038
2019-03-14 17:29:19 +00:00
bors
9df38117d9
Auto merge of #3877 - rink1969:3842, r=flip1995
...
casting integer literal to float is unnecessary
fix issue https://github.com/rust-lang/rust-clippy/issues/3842
2019-03-14 16:32:15 +00:00
rink1969
d9dd008e44
casting integer literal to float is unnecessary
2019-03-14 15:53:08 +08:00
bors
729892961c
Auto merge of #3880 - phansch:uicleanup9001, r=oli-obk
...
UI test cleanup: Extract manual_memcpy tests
cc #2038
2019-03-14 07:52:00 +00:00
Philipp Hansch
5e4a7eb1fc
UI test cleanup: Extract manual_memcpy tests
2019-03-14 07:26:47 +01:00
Philipp Hansch
67aad6c180
Run rustfix for string_lit_as_bytes tests
...
This moves the `string_lit_as_bytes` tests into a new file and enables
rustfix tests for them.
2019-03-14 06:59:30 +01:00
bors
99fdf2607e
Auto merge of #3873 - phansch:hiridification, r=flip1995
...
Some more HirId-ification
* 8a59f81a457258
2019-03-13 08:45:23 +00:00
Philipp Hansch
bf86c1b989
cargo fmt
2019-03-13 06:51:57 +01:00
bors
8fc0a738e3
Auto merge of #3869 - taiki-e:use_self, r=flip1995
...
Fix `use_self` false positive on nested functions
Related to https://github.com/rust-lang/rust-clippy/pull/3640
The current `use_self` warns the following code.
```rust
#![warn(clippy::use_self)]
struct Foo {}
impl Foo {
fn bar() {
fn baz() -> Foo { //^ warning: unnecessary structure name repetition
Foo {} //^ warning: unnecessary structure name repetition
}
}
}
```
2019-03-12 12:09:56 +00:00
bors
6e2b8fa8ca
Auto merge of #3872 - phansch:some_feature_cleanup, r=oli-obk
...
Remove some unused features and `error-pattern`s
None
2019-03-12 09:34:04 +00:00
bors
3d31c2157a
Auto merge of #3794 - mikerite:fix-3739, r=phansch
...
Fix `boxed_local` suggestion
Don't warn about an argument that is moved into a closure.
ExprUseVisitor doesn't walk into nested bodies so use a new
visitor that collects the variables that are moved into closures.
Fixes #3739
2019-03-12 07:43:14 +00:00
Philipp Hansch
a457258132
Use HirId instead of NodeId for lookup
2019-03-12 08:21:22 +01:00
Philipp Hansch
c730de955e
Remove some unused features and error-patterns
2019-03-12 08:15:50 +01:00
bors
75bfa29533
Auto merge of #3871 - taiki-e:needless_continue, r=phansch
...
Fix `needless_continue` false positive
If the `continue` has a label, check it matches the label of the loop.
Fixes https://github.com/rust-lang/rust-clippy/issues/2329
2019-03-12 07:04:44 +00:00
Philipp Hansch
8a59f81180
Rename span_lint_node* functions to span_lint_hir*
...
Because they now take a `hir_id` instead of a `node_id` argument.
2019-03-12 08:01:21 +01:00
bors
b586d76b43
Auto merge of #3865 - phansch:run_more_doc_tests, r=flip1995
...
Run more doc tests
This executes some more doc tests that were ignored before.
2019-03-12 06:22:00 +00:00
Michael Wright
6937d5581a
Merge branch 'master' into fix-3739
2019-03-12 08:13:44 +02:00
bors
94a8d9cbcd
Auto merge of #3868 - taiki-e:needless_pass_by_value, r=phansch
...
Filter out proc_macro and proc_macro_attribute
Related to https://github.com/rust-lang/rust-clippy/pull/1617
Fixes https://github.com/rust-lang/rust-clippy/issues/3067 (this issue has already been closed, but in fact the false positive in `#[proc_macro]` and `#[proc_macro_attribute]` has not been fixed yet)
2019-03-12 06:01:00 +00:00
Philipp Hansch
9ca34e37fa
Run more doc tests
...
This executes some more doc tests that were ignored before.
2019-03-12 06:53:25 +01:00
Taiki Endo
1bc7da2fec
Fix needless_continue false positive
2019-03-12 03:40:30 +09:00
Taiki Endo
187ce4c5ab
Fix use_self false positive on nested functions
2019-03-11 23:24:49 +09:00
Taiki Endo
4896b259eb
Filter out proc_macro and proc_macro_attribute
2019-03-11 20:45:57 +09:00
bors
1cdac4a9c7
Auto merge of #3767 - alexreg:cosmetic-2, r=flip1995
...
Various cosmetic improvements
Related to the larger effort of https://github.com/rust-lang/rust/pull/58036 .
2019-03-10 23:21:48 +00:00
flip1995
72aeaa891b
Fix/Ignore doc tests
2019-03-10 23:01:56 +01:00
flip1995
44c46d2059
Run rustfmt
2019-03-10 22:12:26 +01:00
flip1995
3282955238
Update tests
2019-03-10 22:07:10 +01:00
Alexander Regueiro
a7c0800938
Reblessed test outputs.
2019-03-10 18:13:15 +00:00
Alexander Regueiro
d2b85323ad
Addressed points raised in review.
2019-03-10 18:06:28 +00:00
Alexander Regueiro
d43966a176
Various cosmetic improvements.
2019-03-10 18:06:28 +00:00
bors
016d92d6ed
Auto merge of #3733 - Zoxc:rustc-interface, r=oli-obk
...
Use the new rustc interface
Shows the changes required to compile with https://github.com/rust-lang/rust/pull/56732
2019-03-10 14:26:31 +00:00
John Kåre Alsaker
1388f2488e
rustfmt
2019-03-10 12:00:17 +01:00
John Kåre Alsaker
0d4a19c0d1
Use the new rustc interface
2019-03-10 11:10:05 +01:00
bors
9308df7507
Auto merge of #3863 - rust-lang:get_unwrap, r=oli-obk
...
Move get_unwrap to restriction
fixes #3862
r? @oli-obk
2019-03-10 08:52:24 +00:00
Manish Goregaokar
038ec7f5d8
Move get_unwrap to restriction
...
fixes #3862
2019-03-09 13:48:06 -08:00
bors
920112d723
Auto merge of #3824 - phansch:adding_lints, r=phansch
...
Add lint writing documentation
[Rendered](https://github.com/phansch/rust-clippy/blob/adding_lints/doc/adding_lints.md )
This adds a new documentation page that explains how to write Clippy
lints. It guides the reader through creating a `foo` function lint.
I plan to iterate a bit more on the prose of some sections, but I think the
general structure is fine now, so I'm looking forward to feedback =)
One thing I'm not sure about: I felt like this is too big for CONTRIBUTING.md
so I put it into a new `doc/` directory. I can imagine having more
documentation in the future, so we might even want to create a book using
mdbook instead? Or should everything go into CONTRIBUTING.md?
Further things left to do:
- [x] Link from CONTRIBUTING.md
- [x] Remove things covered in this guide from CONTRIBUTING.md
- [x] Section about `clippy::author` attribute
- [x] Run `remark-lint` on CI over the `doc` directory and fix things
2019-03-09 15:05:38 +00:00
bors
ccfbfb8097
Auto merge of #3860 - phansch:refactor_out_opt_def_id, r=flip1995
...
Refactor: Remove utils::opt_def_id
This removes some indirection. Probably this method was uplifted to
rustc at some point?
2019-03-09 12:05:41 +00:00
bors
8213d252ae
Auto merge of #3861 - flip1995:rollup, r=flip1995
...
Rollup of 3 pull requests
Successful merges:
- #3851 (Refactor: Extract `trait_ref_of_method` function)
- #3852 (Refactor: Cleanup one part of assign_ops lint)
- #3857 (Document match_path, improve match_qpath docs)
Failed merges:
r? @ghost
2019-03-09 11:41:26 +00:00
Philipp Krones
c32135a87f
Rollup merge of #3857 - phansch:document_path_qpath, r=flip1995
...
Document match_path, improve match_qpath docs
Inching towards enabling `#[deny(missing_docs)]` in utils 📜
2019-03-09 12:24:44 +01:00
Philipp Krones
f69351e995
Rollup merge of #3852 - phansch:refactor_assign_ops, r=flip1995
...
Refactor: Cleanup one part of assign_ops lint
Removes a lot of indentation and separates lint emission from lint
logic. Only touches the `hir::ExprKind::AssignOp` part of the lint.
2019-03-09 12:24:43 +01:00
