Nathan Weston
6b57924e81
Improve lint message
...
Remove trailing period and include snippet of loop argument.
2015-09-15 09:41:25 -04:00
Nathan Weston
1e320b38c1
Add is_integer_literal utility function
...
Replaces is_lit_zero and is_lit_one which were used in a couple of
places.
2015-09-15 09:41:25 -04:00
Nathan Weston
f87dd31f30
New lint: loop with explicit counter variable ( fixes #159 )
...
Avoiding false positives here turns out to be fairly complicated.
2015-09-15 09:41:25 -04:00
llogiq
d2a10db7bc
Merge pull request #332 from Manishearth/step_by
...
added fp test against negative .step_by(_)
2015-09-15 09:16:49 +02:00
llogiq
5c5d103405
added fp test against negative .step_by(_)
2015-09-15 09:12:58 +02:00
Manish Goregaokar
29904b9810
Merge pull request #331 from swgillespie/empty-range
...
implement iterating over an empty range lint as described in #330
2015-09-15 11:06:30 +05:30
swgillespie
bc7d252856
use the constant folder to generalize the lint a little bit and clean up the code. Add additional tests for things that should not be linted
2015-09-14 22:20:56 -07:00
swgillespie
82c524b774
implement empty range lint as described in #330
2015-09-14 17:19:05 -07:00
Manish Goregaokar
b86ebad0e7
Merge pull request #328 from Manishearth/falsepositives
...
less false positives for approx_const and float_cmp
2015-09-11 19:31:36 +05:30
llogiq
03af82afd1
removed expensive crate check from approx_const
2015-09-11 15:59:19 +02:00
llogiq
681bce925f
less false positives for approx_const and float_cmp
2015-09-11 15:30:08 +02:00
llogiq
aefad45ee7
Merge pull request #326 from Manishearth/fix-323
...
additional macro check + more tests
2015-09-10 08:55:14 +02:00
llogiq
0e1bc74683
additional macro check + more tests
2015-09-10 08:51:14 +02:00
llogiq
d82c13d92b
Merge pull request #325 from durka/patch-1
...
add warning about different rustc versions
2015-09-10 08:44:45 +02:00
Alex Burka
7b13a7b5e6
link to wiki
2015-09-10 02:26:15 -04:00
Alex Burka
f7ec0ef16c
add warning about different rustc versions
...
Ref #322 .
2015-09-10 02:06:52 -04:00
Manish Goregaokar
ce6ea58de0
add cargo clippy link
2015-09-10 07:01:28 +05:30
llogiq
6d58e36995
Merge pull request #321 from Manishearth/fix-319
...
made shadow_unrelated allow, added previous binding span note,
2015-09-08 13:33:24 +02:00
llogiq
4835372df5
made shadow_unrelated allow, added previous binding span note, fixed #319
2015-09-08 11:50:04 +02:00
llogiq
b5d953bf7d
Merge pull request #316 from Manishearth/mutmut
...
Fix mut_mut false positive, make Allow (fixes #309 )
2015-09-07 23:22:30 +02:00
Manish Goregaokar
0e658afc1b
Fix mut_mut false positive, make Allow ( fixes #309 )
2015-09-08 02:29:13 +05:30
llogiq
54932dee1c
Merge pull request #312 from Manishearth/pub_convention
...
split wrong_self_convention in pub/default visibility part
2015-09-07 11:54:47 +02:00
llogiq
e43f2d7e54
damn autocorrect
2015-09-07 11:49:35 +02:00
llogiq
c79d884450
replace if let by equality check
2015-09-07 11:46:04 +02:00
llogiq
92b04cd75d
split wrong_self_convention in pub/default visibility part
2015-09-07 09:17:45 +02:00
Manish Goregaokar
f4c28f8521
Merge pull request #310 from Manishearth/len_zero
...
fix false positive len_zero in is_empty()
2015-09-07 00:39:24 +05:30
Andre Bogus
468b410d04
de-closured the item name getter
2015-09-06 21:03:09 +02:00
Andre Bogus
87e6099ad7
fix false positive len_zero in is_empty()
2015-09-06 20:57:06 +02:00
llogiq
1569fd8c55
Merge pull request #308 from Manishearth/unit_cmp
...
macro check for unit_cmp
2015-09-06 19:46:21 +02:00
Andre Bogus
391a5135e8
fixed build
2015-09-06 19:44:54 +02:00
Andre Bogus
0c74304f7b
macro check for unit_cmp
2015-09-06 19:41:09 +02:00
Manish Goregaokar
459ef55b25
Merge pull request #304 from Manishearth/bit_mask
...
fixed bad_bit_mask false positive
2015-09-06 20:04:43 +05:30
Andre Bogus
b76ad366ab
fixed bad_bit_mask false positive
2015-09-06 16:09:35 +02:00
llogiq
dc32092ee4
Merge pull request #303 from inrustwetrust/master
...
Don't show the explicit_iter_loop lint for arrays with more than 32 elements
2015-09-06 13:49:04 +02:00
inrustwetrust
efd553c8a9
Don't show the explicit_iter_loop lint for arrays with more than 32 elements
...
The IntoIterator trait is currently not implemented for arrays with more than
32 elements, so for longer arrays, the iter() or iter_mut() methods must be
used.
2015-09-06 13:36:21 +02:00
llogiq
1a7db7892d
Merge pull request #302 from Manishearth/macro
...
More strict macro check
2015-09-06 12:55:15 +02:00
Andre Bogus
55729b7caa
dogfooding a newly caught problem
2015-09-06 10:59:06 +02:00
Andre Bogus
54393f0ef5
More strict macro check
2015-09-06 10:53:55 +02:00
Manish Goregaokar
d9ecd0b965
bump
2015-09-06 05:47:51 +05:30
llogiq
8be8d84fa0
Merge pull request #300 from Manishearth/minmax
...
new lint: min_max
2015-09-05 16:27:09 +02:00
llogiq
79bf820170
added test against const lookup
2015-09-05 16:24:41 +02:00
llogiq
b66bccc45a
update_lints
2015-09-05 14:22:33 +02:00
llogiq
3848756be0
Made min_max Warn by default
2015-09-05 14:20:35 +02:00
llogiq
b90e4c7bd5
hir naming, removed lookup, match full path
2015-09-05 13:15:18 +02:00
llogiq
cd91110ec0
new lint: min_max
2015-09-05 12:46:34 +02:00
llogiq
0c50d763fc
Merge pull request #299 from Manishearth/unicode_str
...
Unicode lints, second attempt: Lint whole strings, help with replacement
This fixes #85
2015-09-04 14:27:26 +02:00
llogiq
28212e4981
fixed dogfood by using snippet instead of the (escaped) literal string
2015-09-04 14:24:49 +02:00
Manish Goregaokar
fb148a50b2
Add false positive checks to unicode test
2015-09-04 16:27:53 +05:30
llogiq
e11fd49b1c
Unicode lints, second attempt: Lint whole strings, help with replacement
2015-09-04 16:18:46 +05:30
Manish Goregaokar
af4d7f9b60
Merge pull request #298 from birkenfeld/as_mut
...
methods: allow &mut self for as_ methods
2015-09-04 16:16:58 +05:30
