bors
5b8b01e8dc
Auto merge of #3519 - phansch:brave_newer_ui_tests, r=flip1995
...
Integrate rustfix into Clippy test suite
Once the [PR to compiletest-rs](https://github.com/laumann/compiletest-rs/pull/151 ) is reviewed and merged this fixes #2376 .
I will create a separate tracking issue for adding `run-rustfix` to all tests.
2019-01-03 15:08:47 +00:00
Philipp Hansch
ec1395aafb
Update to latest compiletest-rs release
2019-01-03 15:42:59 +01:00
bors
baec524fac
Auto merge of #3617 - matthiaskrgr:3462_test, r=phansch
...
add testcase for #3462
2019-01-03 11:23:57 +00:00
Matthias Krüger
24ff813f54
add testcase for #3462
2019-01-03 11:40:10 +01:00
bors
e6aff691d3
Auto merge of #3615 - matthiaskrgr:rtuVbump, r=phansch
...
deps: bump rustc_tools_util version from 0.1.0 to 0.1.1 just in case...
I'm surprised there is no warning since the root cargo.toml specifies 0.1.0 but the subcrate toml actually states 0.1.1.
I should have noticed this in previous pull request but oh well...
2019-01-03 07:20:23 +00:00
Matthias Krüger
a49ed381bd
deps: bump rustc_tools_util version from 0.1.0 to 0.1.1 just in case...
2019-01-03 03:19:15 +01:00
bors
0a6593cd1b
Auto merge of #3603 - xfix:random-state-lint, r=phansch
...
random_state lint
2019-01-03 02:00:46 +00:00
bors
5277a1fb6c
Auto merge of #3614 - matthiaskrgr:rustc_tool_utils, r=phansch
...
rustc_tool_utils: fix failure to create proper non-repo version string when used in crates on crates.io, bump version
2019-01-03 01:06:53 +00:00
bors
84aa027888
Auto merge of #3607 - detrumi:limit_infinite_iter_to_known_types, r=phansch
...
Only trigger `infinite_iter` lint for infinitely allocating `collect()` calls
Fixes #3538
~Oh, I guess this should actually check other methods like `count` as well, not only `collect()`.~
Never mind, `collect` is the only of these functions that allocates a data structure.
2019-01-03 00:12:02 +00:00
Philipp Hansch
a5d3f37c5a
Use compiletest's aux-build header instead of include macro
2019-01-02 22:48:44 +01:00
Matthias Krüger
31d96300ef
rustc_tool_utils: fix failure to create proper non-repo version string when used in crates on crates.io, bump version
2019-01-02 20:12:15 +01:00
bors
0fc5857d0b
Auto merge of #3609 - codeworm96:fix_test, r=phansch
...
Fix test for rust-lang/rust#57250
Part of rust-lang/rust#57250 .
~~Do not merge. Waiting a nightly with that PR merged.~~
2019-01-02 16:40:10 +00:00
bors
3de9a3de54
Auto merge of #3612 - phansch:copies_cleanup, r=flip1995
...
UI test cleanup: Extract ifs_same_cond tests
cc #2038
2019-01-02 13:20:38 +00:00
bors
51c77c1cd2
Auto merge of #3611 - phansch:some_for_loop_cleanup, r=flip1995
...
UI test cleanup: Extract for_kv_map lint tests
cc #2038
2019-01-02 12:12:09 +00:00
Philipp Hansch
c84a894ed7
rustfmt
2019-01-02 08:15:32 +01:00
Philipp Hansch
3b035373b2
UI test cleanup: Extract ifs_same_cond tests
2019-01-02 07:59:48 +01:00
Philipp Hansch
0c54913afe
Extract IteratorFalsePositives into option_helpers.rs
...
This was previously duplicated in #3605
2019-01-02 07:49:28 +01:00
Philipp Hansch
b38a2d7ce9
UI test cleanup: Extract for_kv_map lint tests
2019-01-02 07:42:04 +01:00
Philipp Hansch
eaaee23847
UI test cleanup: Extract lint from methods.rs test
2019-01-02 07:23:00 +01:00
Yuning Zhang
5f9a65ffd6
Fix test for rust-lang/rust#57250
2019-01-01 20:34:02 -05:00
Wilco Kusee
f38fb56baf
Limit infinite_iter collect() check to known types
2018-12-31 13:38:31 +01:00
bors
85ba5f0f17
Auto merge of #3608 - phansch:improve_util_docs, r=oli-obk
...
Some improvements to util documentation
None
2018-12-31 12:03:28 +00:00
Philipp Hansch
cc76384807
Some improvements to util documentation
2018-12-31 12:12:50 +01:00
bors
f2fd8e71e9
Auto merge of #3606 - detrumi:blacklisted_name_hashset, r=phansch
...
Use hashset in `blacklisted_name` lint
2018-12-31 10:22:06 +00:00
Wilco Kusee
d1dfd3e96f
Use hashset for name blacklist
2018-12-31 10:44:27 +01:00
bors
6f3912850a
Auto merge of #3590 - jorpic:i3559-if_same_then_else, r=phansch
...
Fix if_same_then_else false positive
This fixes false positive in #3559 .
The problem was that `SpanlessEq` does not check patterns in declarations. So this two blocks considered equal.
```rust
if true {
let (x, y) = foo();
} else {
let (y, x) = foo();
}
```
Not sure if the proposed change is safe as `SpanlessEq` is used extensively in other lints, but I tried hard to come up with counterexample and failed.
2018-12-31 09:25:18 +00:00
bors
529f698c23
Auto merge of #3599 - xfix:use-hash-set-for-valid-idents, r=oli-obk
...
Use an FxHashSet for valid idents in documentation lint
2018-12-30 17:46:01 +00:00
bors
39bd84494f
Auto merge of #3605 - phansch:small_methods_ui_test_improvement, r=flip1995
...
UI test cleanup: Extract iter_skip_next from methods.rs
cc #2038
2018-12-30 16:00:15 +00:00
Konrad Borowski
11b957e18d
Reformat random_state tests
2018-12-30 14:29:43 +01:00
Philipp Hansch
8c4c458ee9
UI test cleanup: Extract iter_skip_next from methods.rs
...
cc #2038
2018-12-30 13:46:21 +01:00
Konrad Borowski
978e3ac2cf
Use node_id_to_type_opt instead of node_it_to_type in random_state
2018-12-30 13:40:27 +01:00
bors
61bfb39e3f
Auto merge of #3593 - mikerite:readme-syspath-2, r=phansch
...
Update README local run command to remove syspath
Since #3257 was reverted, including the sysroot in RUSTFLAGS gives the
error `Option 'sysroot' given more than once`
2018-12-30 11:45:38 +00:00
bors
735607c1f9
Auto merge of #3588 - detrumi:tuple_struct_use_self, r=phansch
...
`use_self` for tuple structs
Fixes #3498
2018-12-30 11:12:55 +00:00
Max Taldykin
911a752561
Check pattern equality while checking declaration equality
2018-12-30 14:01:56 +03:00
Konrad Borowski
1130bbc26f
Merge branch 'master' of https://github.com/rust-lang/rust-clippy into random-state-lint
2018-12-30 11:43:20 +01:00
bors
aee138a7cf
Auto merge of #3597 - xfix:match-ergonomics, r=phansch
...
Match ergonomics (lints from A to B)
2018-12-30 10:40:36 +00:00
bors
ad2a4ef4bb
Auto merge of #3602 - matthiaskrgr:rustup, r=phansch
...
rustup https://github.com/rust-lang/rust/pull/56225/
item.name -> item.ident.name
2018-12-30 09:55:09 +00:00
Wilco Kusee
259ec2dc0e
Update test output after rebase
2018-12-30 08:23:39 +01:00
Wilco Kusee
1d10de66de
Remove false negatives from known problems
2018-12-30 08:23:39 +01:00
Wilco Kusee
ab42ba4f54
Implement use_self for tuple structs
2018-12-30 08:23:38 +01:00
Wilco Kusee
0f3dcdc3aa
Document known problems
2018-12-30 08:20:49 +01:00
Konrad Borowski
a6c4eaa93c
random_state lint
2018-12-30 02:45:34 +01:00
Matthias Krüger
e590025f61
rustup https://github.com/rust-lang/rust/pull/56225/
...
item.name -> item.ident.name
2018-12-30 01:09:24 +01:00
Konrad Borowski
815e434a1f
Move constant write checks to temporary_assignment lint
...
They make more sense here
2018-12-30 00:25:09 +01:00
bors
ece8b8e7d6
Auto merge of #3598 - xfix:apply-cargo-fix-edition-idioms, r=phansch
...
Apply cargo fix --edition-idioms fixes
2018-12-29 19:04:11 +00:00
bors
6cba3da727
Auto merge of #3558 - russelltg:new_without_default_merge, r=flip1995
...
Merge new_without_default_derive into new_without_default
Closes #3525 , deprecating new_without_default_derive and moving both lints into new_without_default.
2018-12-29 17:31:35 +00:00
Konrad Borowski
ab70e0e742
Use an FxHashSet for valid idents in documentation lint
2018-12-29 18:08:53 +01:00
Konrad Borowski
177c639e65
Remove unnecessary use
statements after cargo fix
2018-12-29 17:48:21 +01:00
Konrad Borowski
0edb49792f
Apply cargo fix --edition-idioms fixes
2018-12-29 17:46:25 +01:00
Konrad Borowski
aeabb890d6
Use match ergonomics for booleans lint
2018-12-29 17:38:15 +01:00