1382 commits

Author	SHA1	Message	Date
sinkuu	627d24c80f	Fix suggestion for let <pat>	2017-02-21 00:27:12 +09:00
sinkuu	f1b0b774e7	Support non-moving usages at match ... This `match` is not moving the `String`: ```rust fn foo(x: Option<String>) -> i32 { match x { Some(_) => 1, None => 2, } } ``` With this change, it will be linted and suggested to add `*` to deref it. ```rust fn foo(x: &Option<String>) -> i32 { match *x { Some(_) => 1, None => 2, } } ```	2017-02-20 16:45:37 +09:00
sinkuu	0a6bc6031a	Rename lint to needless_take_by_value ... And fixes false-positives for generics and `match`	2017-02-20 16:02:48 +09:00
Phil Ellison	d6a4d2cb18	Fix typo	2017-02-19 15:39:40 +00:00
Phil Ellison	0396756098	Add test that adding allow attribute on impl block containing len silences len_without_is_empty. Add extra impl block to PubOne to check that this doesn't get flagged@	2017-02-19 15:36:17 +00:00
Phil Ellison	2dd45b7317	Use span of impl/trait in len_without_is_empty error message, rather than the span of the len method	2017-02-19 15:14:30 +00:00
sinkuu	d81d961ba7	Lint needless take-by-value	2017-02-19 07:59:44 +09:00
Bood Qian	97d46232b4	Merge branch 'master' of github.com:Manishearth/rust-clippy	2017-02-18 11:12:13 +08:00
sinkuu	8cb2ec804d	Support generic type	2017-02-18 10:14:25 +09:00
sinkuu	6bb426b0e3	Add should_assert_eq lint (fixes #641)	2017-02-18 10:13:56 +09:00
Andre Bogus	505eb53d29	New never loop lint ... This lint detects loops that unconditionally break or return. Closes #257	2017-02-17 04:53:14 +01:00
Ben Boeckel	84509ca48a	typos: coma -> comma	2017-02-16 11:23:28 -05:00
Bood Qian	2f00ea3a07	Suppress lint for unsuffixed number casts	2017-02-16 22:55:41 +08:00
Bood Qian	afce85e96d	Add lint for unnecessary casts (cast to same type)	2017-02-15 22:20:20 +08:00
Andre Bogus	d904a01140	fix windows tests ... Windows has a different error message than POSIX, so the ui tests fail for the clippy-config-fail tests. This commit splits those tests up in target-os specific subdirectories and extends compile-test.rs to run either of them based on the target os. Here's hope we'll get a green appveyor build.	2017-02-14 17:30:55 +01:00
Oliver Schneider	8b3ad61dd3	update ui tests	2017-02-13 11:57:14 +01:00
Oliver Schneider	2265babe6a	Merge remote-tracking branch 'origin/master' into clonedCollect	2017-02-13 11:40:02 +01:00
Oliver Schneider	637a4590f6	Merge remote-tracking branch 'origin/master'	2017-02-13 11:15:12 +01:00
Martin Carton	9a7597d5af	Merge pull request #1528 from Manishearth/mut-from-ref ... New `mut_from_ref` lint	2017-02-12 16:01:15 +01:00
Andre Bogus	21d226e7d2	fixed multi-span test	2017-02-12 15:10:25 +01:00
Andre Bogus	36b8554cf1	add notes for immutable inputs	2017-02-12 13:53:30 +01:00
f001	b3570db094	update via comments	2017-02-12 20:40:38 +08:00
f001	98aa0db0ac	Add a lint for slice.iter().cloned().collect() ... If one uses `slice.iter().cloned().collect()` to create a new `Vec`, it should be `slice.to_owned()`. Fix #1292	2017-02-12 17:03:09 +08:00
Bood Qian	64d2f8af8e	Lint on panic! only	2017-02-11 21:42:42 +08:00
Bood Qian	a2d752807a	Lint on Err(_) arm of a match	2017-02-11 14:57:50 +08:00
Owen Sanchez	2a8ce7c458	Update large_enum_variant test	2017-02-10 21:04:19 -07:00
Owen Sanchez	1938904fcd	Change large_enum_variant to lint against size differences rather than size	2017-02-10 18:12:32 -07:00
Andre Bogus	673ee4800d	fix test	2017-02-11 01:41:49 +01:00
Andre Bogus	bff4c30ac7	added test, fixed message & description, rustfmt	2017-02-11 00:32:12 +01:00
Andre Bogus	5650a599a8	New mut_from_ref lint ... This fixes #1507.	2017-02-10 19:39:03 +01:00
Oliver Schneider	1f2c97a291	remove all //~ from tests	2017-02-08 14:58:07 +01:00
Oliver Schneider	fd1351f6e3	rustup and compile-fail -> ui test move	2017-02-07 21:05:30 +01:00