Commit graph

3264 commits

Author SHA1 Message Date
Andre Bogus
88aa04dfa5 don't lint while_let_on_iterator on nested loops
The problem is with a nested loop, the iterator may well be reused. This
changeset introduces a false negative, when the iterator is initialized
within the outer loop. A further PR could get rid of this false negative
by checking if the iterator is indeed initialized within the outer loop.
2017-06-23 18:29:18 +02:00
Martin Carton
06ec3d310f Merge pull request #1841 from sanxiyn/span-lint-and-sugg
Use span_lint_and_sugg
2017-06-22 10:39:48 +02:00
Seo Sanghyeon
745233f3ab Use span_lint_and_sugg 2017-06-22 03:04:04 +09:00
llogiq
88101d5b78 Merge pull request #1839 from Manishearth/rustup-tests
Fix the test suite after cargo update
2017-06-19 23:19:51 +02:00
mcarton
74d4842c5f Fix the test suite after cargo update 2017-06-19 22:11:12 +02:00
Martin Carton
22c986f684 Merge pull request #1837 from Manishearth/step_by
Replace `Range::step_by` checking with `Iterator::step_by`
2017-06-18 17:09:14 +02:00
Oliver Schneider
38925a55b7 Replace Range::step_by checking with Iterator::step_by 2017-06-18 16:12:04 +02:00
Martin Carton
27727c4aff Merge pull request #1799 from Manishearth/docs
Rewrite `doc_markdown` to use `pulldown-cmark`
2017-06-17 19:24:33 +02:00
mcarton
898dafba1d Fix links in change log 2017-06-17 18:27:28 +02:00
mcarton
34a899cf18 Don't depend explicitly on pulldown-cmark
Use the one from `rustc`'s, which avoids "multiple matching crate"
errors.
2017-06-17 18:24:23 +02:00
mcarton
94cf93c39c Don't use default features for pulldown-cmark 2017-06-17 18:24:23 +02:00
mcarton
9881b15822 Ignore mix of {,non-}sugared doc in doc_markdown 2017-06-17 18:24:23 +02:00
mcarton
81b0efa094 Add a new doc_markdown test from issue comments 2017-06-17 18:24:23 +02:00
mcarton
1a297f008c Log that doc_markdown has been rewritten
I hope this will fix most false positives, and maybe some true
negatives, and won't introduce too much new FP.
2017-06-17 18:24:23 +02:00
mcarton
349b45bb99 Fix spans in all cases in doc_markdown 2017-06-17 18:23:37 +02:00
mcarton
aaf9bce905 Fix spans in doc_markdown in most cases 2017-06-17 18:23:37 +02:00
mcarton
d2ef1b318d Rewrite doc_markdown to use pulldown-cmark 2017-06-17 18:23:37 +02:00
mcarton
9c9ad3e281 Add itertools and pulldown-cmark dependencies 2017-06-17 18:22:49 +02:00
Oliver Schneider
6c587004b5
Bump the version 2017-06-16 18:45:07 +02:00
Oliver Schneider
35b8867225 CHANGELOG is ordered after Cargo 2017-06-16 18:44:41 +02:00
Oliver Schneider
50a1fd1ae4 Merge pull request #1833 from messense/feature/fix-nightly-06-16
rustup to rustc 1.19.0-nightly (258ae6dd9 2017-06-15)
2017-06-16 18:42:24 +02:00
messense
faf7bf6a3e
Update ui tests 2017-06-16 11:57:45 +08:00
messense
16a958b103
rustup to rustc 1.19.0-nightly (258ae6dd9 2017-06-15) 2017-06-16 11:57:44 +08:00
Martin Carton
3873c61347 Merge pull request #1830 from scott-linder/generic-new-without-default
Ignore new-without-default lint when `new` method has generic types
2017-06-15 00:12:46 +02:00
scott-linder
1ce3cbf9c4 Ignore new-without-default lint when new method has generic types
There may be no sensible `Default` impl if the result of `new` depends
on a type parameter.
2017-06-14 12:58:22 -04:00
Oliver Schneider
7056018335 Merge pull request #1501 from scott-linder/types-borrow-box
Types borrow box
2017-06-13 11:30:52 +02:00
llogiq
92fac4ac1a Merge pull request #1827 from erickt/master
`in_macro` check in `NEEDLESS_RETURN`
2017-06-13 06:53:17 +02:00
Erick Tryzelaar
8c235d19bc in_macro check in NEEDLESS_RETURN
This allows you to define a macro like `try!(...)` that embeds an
early exit without emitting the "needless_return" warning.

Closes #1271.
2017-06-12 19:06:37 -07:00
Oliver Schneider
c6f5c89b93 Merge pull request #1826 from Manishearth/multi-zero-prefix
deal with multiple prefixed zeros in literals
2017-06-12 22:06:51 +02:00
Andre Bogus
3a8e4c33bd deal with multiple prefixed zeros in literals 2017-06-12 20:41:00 +02:00
scott-linder
5db8647c5e Test for trait method decl/impl for borrowed box. 2017-06-12 08:44:08 -04:00
scott-linder
1a50755f21 Document check_ty and its new is_local arg. 2017-06-12 08:43:02 -04:00
scott-linder
49bba315e4 Merge nested if into adjacent if_let_chain! 2017-06-12 08:38:29 -04:00
Oliver Schneider
b1e9c1b7e7 Merge pull request #1804 from camsteffen/never_loop
fix never_loop
2017-06-12 08:08:19 +02:00
Cameron Steffen
1a453bf72c fix another never_loop 2017-06-11 18:37:59 -05:00
Cameron Steffen
8b00f826d7 Merge branch 'master' into never_loop 2017-06-11 18:25:26 -05:00
scott-linder
54b52054c9 Test for local types in LINKEDLIST and BOX_VEC
Add negative tests for types in local declarations in the `LINKEDLIST`
and `BOX_VEC` lints. They share a pass with `BORROWED_BOX` which does
check local delclarations.
2017-06-11 12:30:48 -04:00
scott-linder
74ebe6e69e Add check_local to TypePass for BORROWED_BOX
Adds a boolean flag to indicate whether the current type in `check_ty`
is in a local declaration, as only the borrowed box lint should consider
these types.
2017-06-11 12:20:20 -04:00
scott-linder
c29f5ea83b Commit updated example stderr 2017-06-11 12:19:11 -04:00
scott-linder
deef81a3fc Use span_suggestion in borrowed_box lint 2017-06-11 12:19:11 -04:00
scott-linder
663688f70d Move old-style test to examples 2017-06-11 12:19:11 -04:00
scott-linder
c061464f20 Add more exhaustive tests for borrow_box 2017-06-11 12:19:11 -04:00
scott-linder
e6eaa726e2 Recurse into inner type when not &Box<T> 2017-06-11 12:19:11 -04:00
scott-linder
80cb48ca1a Actually fix the lint applied 2017-06-11 12:19:11 -04:00
scott-linder
a4c4da1c4b Fix typo in types check 2017-06-11 12:19:11 -04:00
scott-linder
711cad188a check for borrowed box types 2017-06-11 12:19:11 -04:00
Manish Goregaokar
55cb63adfe Bump to 0.0.139 2017-06-10 22:07:09 -07:00
Manish Goregaokar
4e151a4eab Bump the version 2017-06-10 21:45:53 -07:00
Manish Goregaokar
7535afc0fa Merge pull request #1823 from eddyb/nightly-magic
Update for rustc 1.19.0-nightly (4bf5c99af 2017-06-10) and some cleanups.
2017-06-10 21:43:41 -07:00
Eduard-Mihai Burtescu
50b3d7ee9d Do not use .sty except for matching on it. 2017-06-11 06:24:13 +03:00