Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-22 11:03:16 +00:00
Code Issues Projects Releases Packages Wiki Activity
8080 commits 4 branches 212 tags 142 MiB
Commit graph

8080 commits

This branch
This branch
All branches
Author SHA1 Message Date
bors
100a24d9d8 Auto merge of #5364 - flip1995:useless_transmute_quarantine, r=Manishearth 
Move useless_transmute to nursery

cc #5343

@rust-lang/clippy anyone against moving this to nursery?

changelog: Move [`useless_transmute`] to nursery
 2020-03-23 20:52:57 +00:00
bors
d3989eef2d Auto merge of #5319 - 1tgr:master, r=flip1995 
Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them

changelog: Add `redundant_pub_crate` lint

Closes #5274.
 2020-03-23 20:35:49 +00:00
mgr-inz-rafal
ff9602515e Code clean-up and formatting 2020-03-23 21:21:18 +01:00
mgr-inz-rafal
3d3af07845 Provide appropriate suggestion 2020-03-23 21:00:02 +01:00
flip1995
13fcee51e7
Move useless_transmute to nursery 2020-03-23 20:32:04 +01:00
mgr-inz-rafal
12796cd688 Initial lint without suggestion 2020-03-23 20:29:12 +01:00
Tim Robinson
870b9e8139 nursery group -> style 2020-03-23 16:45:31 +00:00
bors
1ff81c1b6d Auto merge of #5350 - ThibsG:FixSingleBindingClosure, r=flip1995 
Fix single binding closure

Fix the `match_single_binding` lint when triggered inside a closure.

Fixes: #5347

changelog: Improve suggestion for [`match_single_binding`]
 2020-03-23 15:17:09 +00:00
bors
43bdee034f Auto merge of #5361 - matthiaskrgr:rustup_37, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69968/

changelog: none
 2020-03-23 14:41:57 +00:00
Matthias Krüger
0f319513d2 rustup https://github.com/rust-lang/rust/pull/69968/ 2020-03-23 15:21:46 +01:00
bors
89303daf6c Auto merge of #5353 - flip1995:conf_doc, r=Manishearth 
Fix documentation generation for configurable lints

In #5135, the configuration macro changed, but the documentation generation script wasn't updated. This PR catches up on this.

[Preview](https://flip1995.github.io/rust-clippy/master/index.html)

r? @Manishearth

changelog: Document configuration options of lints again.
 2020-03-22 18:54:58 +00:00
flip1995
a1dc609f21
Fix documentation generation for configurable lints 2020-03-22 18:15:06 +01:00
ThibsG
badfbbbbde Fix single binding in closure 2020-03-22 10:31:30 +01:00
Tim Robinson
de9092438d Update for PR feedback 2020-03-20 22:52:53 +00:00
bors
0e5e2c4365 Auto merge of #5323 - rabisg0:fix/5284, r=flip1995 
Improvement: Don't show function body in needless_lifetimes

Changes the span on which the lint is reported to point to only the
function return type instead of the entire function body.
Fixes #5284

changelog: none
 2020-03-20 12:45:30 +00:00
bors
d8e6e4cfcd Auto merge of #5342 - flip1995:rollup-77s2pmt, r=flip1995 
Rollup of 4 pull requests

Successful merges:

 - #5326 (rustup https://github.com/rust-lang/rust/pull/69838)
 - #5333 (rustup https://github.com/rust-lang/rust/pull/69189)
 - #5336 (rustup https://github.com/rust-lang/rust/pull/69920/)
 - #5341 (Rustup to rust-lang/rust#66131)

Failed merges:

r? @ghost

changelog: none
 2020-03-19 15:26:41 +00:00
flip1995
e4fc9316cd
Get integration test binary from deps dir 
cc rust-lang/cargo#7965
 2020-03-19 16:10:33 +01:00
Philipp Krones
606e3285b2
Rollup merge of #5341 - flip1995:rustup, r=flip1995 
Rustup to rust-lang/rust#66131

changelog: none
 2020-03-19 15:00:32 +01:00
Philipp Krones
a46675f229
Rollup merge of #5336 - matthiaskrgr:rustup_35, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69920/

changelog: none
 2020-03-19 15:00:31 +01:00
Philipp Krones
983d195bb5
Rollup merge of #5333 - matthiaskrgr:rustup_34, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69189

rustups https://github.com/rust-lang/rust/pull/69189 which is part of https://github.com/rust-lang/rust/pull/70085
(at least I think this is the only pr that changes clippy test stdout)

changelog: none
 2020-03-19 15:00:30 +01:00
Philipp Krones
027706630b
Rollup merge of #5326 - matthiaskrgr:rustup_33, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69838

changelog: none
 2020-03-19 15:00:29 +01:00
flip1995
21aeb21b8a
Rustup to rust-lang/rust#66131 2020-03-19 14:33:10 +01:00
Matthias Krüger
b9d6bf3bfb rustup https://github.com/rust-lang/rust/pull/69920/ 2020-03-19 09:14:53 +01:00
Rabi Guha
0812a0af4c Improvement: Don't show function body in needless_lifetimes 
Changes the span on which the lint is reported to point to only the
function return type instead of the entire function body.
Fixes #5284
 2020-03-19 12:03:02 +05:30
bors
c036c4f4a5 Auto merge of #5335 - flip1995:changelog, r=Manishearth 
Update changelog to 1.43.0 beta

In the beta changelog update, I accidentally used the commit of the 1.43.0 beta, instead of the 1.42.0 beta. I fixed this in this PR.

[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md)

r? @Manishearth

changelog: none
 2020-03-18 20:34:58 +00:00
bors
e004b9431d Auto merge of #5329 - matthiaskrgr:int_arith_on_ref_5328, r=flip1995 
integer_arithmetic: detect integer arithmetic on references.

changelog: integer_arithmetic fix false negatives with references on integers

Fixes #5328
 2020-03-18 14:56:05 +00:00
Matthias Krüger
ec1dcde46b tests: arithmetic: split into integer_arithmetic and float_arithmetic files. 2020-03-18 15:50:01 +01:00
bors
08fc39813f Auto merge of #5331 - matthiaskrgr:lint_docs1, r=flip1995 
clean up a few lint docs

changelog: none
 2020-03-18 14:34:34 +00:00
flip1995
f041dcdb4e
Fix limit-stderr-files test 2020-03-18 15:27:25 +01:00
flip1995
a808779441
Split up checked_unwrap test further 2020-03-18 15:26:24 +01:00
bors
89cffe18b1 Auto merge of #5330 - matthiaskrgr:newlint_expl, r=flip1995 
new_lint.rs: encourage authors to write more detailed code samples in lint descriptions (linted as well as fixed code)

changelog: none
 2020-03-18 13:58:41 +00:00
flip1995
552768f092
Update changelog to 1.43.0 beta 2020-03-18 14:55:44 +01:00
Matthias Krüger
c7c7ab23aa integer_arithmetic: detect integer arithmetic on references. 
Also fixes the same for float_arithmetic.

changelog: integer_arithmetic,float_arithmetic: fix false negatives with references on integers

Fixes #5328
 2020-03-18 14:52:01 +01:00
flip1995
ba7a1a4cbf
Merge remote-tracking branch 'upstream/rust-1.43.0' into backport_remerge 2020-03-18 11:54:58 +01:00
Matthias Krüger
b875c53d2c rustup https://github.com/rust-lang/rust/pull/69189 
rustups https://github.com/rust-lang/rust/pull/69189 which is part of https://github.com/rust-lang/rust/pull/70085
(at least I think this is the only pr that changes clippy test stdout)
 2020-03-18 03:27:05 +01:00
Matthias Krüger
2204bf20ae clean up a few lint docs 2020-03-18 02:50:39 +01:00
Matthias Krüger
7545925ffe new_lint.rs: encourage authors to write more detailed code samples in lint descriptions (linted as well as fixed code) 
changelog: none
 2020-03-18 01:43:39 +01:00
bors
204bb9b54b Auto merge of #5314 - ehuss:remove-git2, r=flip1995 
Remove git2 dependency.

This removes the `git2` dependency (used in the integration test).  Updating git2 is awkward because both cargo and clippy have to be updated in sync, so this removes that requirement. It didn't look like it was using the git2 library for any particular reason, so this just launches the `git` executable, which should be available more or less everywhere.

This unblocks updating Cargo.

changelog: none
 2020-03-17 10:00:05 -07:00
Matthias Krüger
b8effecee1 rustup https://github.com/rust-lang/rust/pull/69838 2020-03-17 10:18:22 +01:00
bors
23549a8c36 Auto merge of #5324 - matthiaskrgr:rustup_32, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69738

changelog: none
 2020-03-16 17:44:54 +00:00
Matthias Krüger
a97f60b8e3 rustup https://github.com/rust-lang/rust/pull/69738 2020-03-16 18:38:30 +01:00
bors
24f6d643fe Auto merge of #5322 - phansch:or_patterns, r=matthiaskrgr 
Make use of `or_patterns` feature

changelog: none
 2020-03-16 12:41:04 +00:00
Tim Robinson
52208f3cf3 Lint for pub(crate) items that are not crate visible due to the visibility of the module that contains them 
Closes #5274.
 2020-03-16 12:21:00 +00:00
bors
d556bb73df Auto merge of #5321 - matthiaskrgr:rustup_31, r=phansch 
rustup https://github.com/rust-lang/rust/pull/68944

changelog: none
 2020-03-16 12:11:00 +00:00
Matthias Krüger
ba0884bee3 rustup https://github.com/rust-lang/rust/pull/68944 2020-03-16 11:36:17 +01:00
Philipp Hansch
548c417ec4
Make use of or_patterns feature 2020-03-16 07:25:09 +01:00
bors
d8bcdac9de Auto merge of #5318 - matthiaskrgr:rustup_30, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69589/

changelog: none
 2020-03-15 20:57:14 +00:00
Matthias Krüger
4d8ed5a842 rustup https://github.com/rust-lang/rust/pull/69589/ 2020-03-15 18:23:43 +01:00
bors
c1a138cdd9 Auto merge of #5316 - lzutao:osstr, r=phansch 
Don't convert Path to lossy str

changelog: none
 2020-03-15 12:57:30 +00:00
bors
8fd7e31d1b Auto merge of #5317 - JohnTitor:rustup, r=matthiaskrgr 
Rustup to rust-lang/rust#69076

changelog: none
 2020-03-14 21:45:38 +00:00