Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-22 11:03:16 +00:00
Code Issues Projects Releases Packages Wiki Activity
7228 commits 4 branches 212 tags 142 MiB
Commit graph

7228 commits

This branch
This branch
All branches
Author SHA1 Message Date
bors
87536f00e3 Auto merge of #4675 - lzutao:improve-shellscript, r=phansch 
build: improve script and travis config

* fix a diff failure on windows

See https://travis-ci.com/rust-lang/rust-clippy/jobs/245971932#L1625
for an example.

* use cmp instead of diff > /dev/null

* clone single branch instead of clone then checking out

* do not decrypt key if have no diff change

changelog: none
 2019-10-24 05:20:45 +00:00
bors
850dfdae60 Auto merge of #4680 - hellow554:debug_assert_mut_call, r=flip1995 
Add lint for debug_assert_with_mut_call

closes #1526

**What does not work:**

* detecting a mut call in the format string itself, e.g. `debug_assert!(false, "{}", vec![1].pop())`
* detecting `*mut T` usage (pointer)

---

changelog: add new lint `debug_assert_with_mut_call`
 2019-10-23 20:58:14 +00:00
bors
087e5eaea5 Auto merge of #4691 - HMPerson1:suggest_iter, r=phansch 
Fix suggestion of `explicit_counter_loop`

changelog: In the suggestion of `explicit_counter_loop`, if the `for` loop argument doesn't implement `Iterator`, then we suggest `x.into_iter().enumerate()` (or `x.iter{_mut}()` as appropriate). Also, the span of the suggestion has been corrected.

Fixes #4678
 2019-10-23 20:12:14 +00:00
bors
1bce252859 Auto merge of #4718 - matthiaskrgr:cargo_metadata, r=phansch 
deps: update cargo_metadata from 0.8.0 to 0.9.0

changelog: none
 2019-10-23 19:09:40 +00:00
Matthias Krüger
b5f73dad90 deps: update cargo_metadata from 0.8.0 to 0.9.0 2019-10-23 17:30:24 +02:00
bors
9a2e500928 Auto merge of #4715 - rust-lang:rustup, r=phansch 
Rustup to rust-lang/rust#65647

cc rust-lang/rust#65647

waiting on rust-lang/rust#65690

changelog: none
 2019-10-23 10:35:17 +00:00
flip1995
e8d5a9e95c
Use StableHasher in SpanlessHasher 2019-10-22 14:57:44 +02:00
flip1995
ef18ece564
Don't hash spans in SpanlessHasher 2019-10-22 11:17:16 +02:00
Lzu Tao
088d528be9 build: remove needless BASE_TESTS env 2019-10-22 16:16:01 +07:00
Lzu Tao
629b4d5a82 Early exit if errors in integration tests 2019-10-22 16:16:01 +07:00
Lzu Tao
ba673d020b build: remove travis_wait 
Now the travis CI build time is fast enough to not cause build timeout.
 2019-10-22 16:16:01 +07:00
Lzu Tao
049800d304 nit: ! is not on a condition and skips errexit 2019-10-22 16:16:01 +07:00
Lzu Tao
f3ace5e71d build: use shared target dir 2019-10-22 16:16:01 +07:00
Marcel Hellwig
5572476a36 Add lint for debug_assert_with_mut_call 
This lint will complain when you put a mutable function/method call
inside a `debug_assert` macro, because it will not be executed in
release mode, therefore it will change the execution flow, which is not
wanted.
 2019-10-22 10:39:55 +02:00
Lzu Tao
abafec5640 macos: symlink rustc dev libs to /usr/local/lib 
Due to System Integrity Protection (SIP), exporting
LD_LIBRARY_PATH will not work on macOS systems.
Therefore, rather than disable SIP, we could symlink
those rust dev libs to /usr/local/bin.
I already tried install_name_tool(1) but couldn't make
clippy-driver work on CI for whatever reasons.
 2019-10-22 10:14:39 +07:00
Lzu Tao
b869eeb2a4 build: improve script and travis config 
* fix a diff failure on windows

See https://travis-ci.com/rust-lang/rust-clippy/jobs/245971932#L1625
for an example.

* use cmp instead of diff > /dev/null

* clone single branch instead of clone then checking out

* do not decrypt key if have no diff change
 2019-10-22 10:14:39 +07:00
bors
1d0f62570b Auto merge of #4702 - lzutao:build/debug-integration-clippy, r=phansch 
build: use clippy's debug build in integration test

changelog: none
 2019-10-20 11:02:36 +00:00
Lzu Tao
d4fef9f4d0 build: use clippy's debug build in integration test 2019-10-19 21:09:16 +07:00
bors
cbedd97b3a Auto merge of #4692 - lzutao:use-opt-profile-rtim, r=phansch 
build: use release build of RTIM

rustup-toolchain-install-master on Travis Windows builds is
unexpectedly slower compared to when run on other OSes.
This commit tries to use release build of RTIM as a mean to
improve performance there.

changelog: none
 2019-10-19 09:14:29 +00:00
bors
dbc40400de Auto merge of #4700 - lzutao:rustup-65535, r=phansch 
rustup https://github.com/rust-lang/rust/pull/65535

cc https://github.com/rust-lang/rust/issues/65585
changelog: none
 2019-10-19 05:41:18 +00:00
Lzu Tao
4c7387e965 rustup https://github.com/rust-lang/rust/pull/65535 2019-10-19 12:27:21 +07:00
bors
850ad526df Auto merge of #4696 - rust-lang:need-not-use-proc-macro, r=phansch 
Omit proc macros from `must_use_candidate`

This fixes #4684.

changelog: none
 2019-10-18 19:40:45 +00:00
HMPerson1
a9cb2b9001
Fix suggestion for ranges 2019-10-18 12:11:15 -04:00
Andre Bogus
d723b35aee Omit proc macros from must_use_candidate 2019-10-18 15:54:25 +02:00
bors
c0b2411f06 Auto merge of #4657 - Licenser:additional-restrictions, r=flip1995 
Additional restrictions

Add restriction lints for `panic!`, `unreachable!`, `todo!` and `.expect(...)`

changelog: Add 5 new `restriction` lints: `panic`, `unreachable`, `todo`, `option_expect_used`, `result_expect_used`
 2019-10-18 10:32:01 +00:00
Lzu Tao
7d7451a67a build: use release build of RTIM 
rustup-toolchain-install-master on Travis Windows builds is
unexpectedly slower when it was running on other OSes.
This commit tries to use release build of RTIM as a mean to
improve performance there.
 2019-10-18 14:58:26 +07:00
Heinz N. Gies
7f454d8d06 Split out tests 2019-10-18 07:40:48 +02:00
Heinz N. Gies
a7ad78f3eb Add expect 
Co-Authored-By: Philipp Krones <hello@philkrones.com>
 2019-10-18 07:37:58 +02:00
Heinz N. Gies
98dc3aabea Add todo and tests 2019-10-18 07:37:58 +02:00
Heinz Gies
8d911fe988 add restirction for unreachable and panic 2019-10-18 07:35:25 +02:00
HMPerson1
4578e5e15e
Fix suggestion span in explicit_counter_loop 2019-10-18 01:15:54 -04:00
bors
ee6fc1bead Auto merge of #4687 - lzutao:before-cache-appveyor, r=Manishearth 
appveyor: on_finish run after saving cache

According to <https://www.appveyor.com/docs/build-configuration/#build-pipeline>
on_finish step runs after saving cache step, we should use after_test instead.

changelog: none
 2019-10-18 04:53:16 +00:00
HMPerson1
72f3439346
Suggest calling iter if needed in explicit_counter_loop 2019-10-18 00:03:27 -04:00
bors
77092a54d7 Auto merge of #4685 - HMPerson1:patch-1, r=Manishearth 
Update adding_lints.md

changelog: none
 2019-10-18 02:51:04 +00:00
bors
feb7e624bb Auto merge of #4686 - lzutao:fix-travis-windows-stuck, r=Manishearth 
travis: Windows build might be stuck as non-supported languages

See <https://docs.travis-ci.com/user/reference/windows/#supported-languages>
for list of Windows supported languages.

I'm sorry for making Travis Windows build stuck.

changelog: none
 2019-10-18 01:02:08 +00:00
bors
14a0f36617 Auto merge of #4683 - HMPerson1:inefficient_to_string, r=Manishearth 
Add `inefficient_to_string` lint

Closes #4586

changelog: Add `inefficient_to_string` lint, which checks for calling `to_string` on `&&str`, which would bypass the `str`'s specialization
 2019-10-17 23:48:55 +00:00
Michael Zhang
2106a23966
Update help text in inefficient_to_string 
Co-Authored-By: Manish Goregaokar <manishsmail@gmail.com>
 2019-10-17 19:13:32 -04:00
bors
e979eb4cc5 Auto merge of #4689 - Manishearth:rustup, r=Yaahc 
Rustup to rustc 1.40.0-nightly (fa0f7d008 2019-10-17)

changelog: none
 2019-10-17 23:00:08 +00:00
Manish Goregaokar
fcad3cb9ea syntax::ext -> syntax_expand 2019-10-17 15:57:48 -07:00
Lzu Tao
607f795349 appveyor: on_finish run after saving cache 
Use after_test instead
 2019-10-18 01:09:37 +07:00
Lzu Tao
c6159961ae travis: Windows build might be stuck as non-supported languages 
See <https://docs.travis-ci.com/user/reference/windows/#supported-languages>
for list of Windows supported languages.
 2019-10-18 01:09:32 +07:00
bors
4a388e1fd5 Auto merge of #4659 - lzutao:caching, r=phansch 
Cache cargo binaries

changelog: none
 2019-10-17 17:16:36 +00:00
HMPerson1
ffb53e7457
Add run-rustfix to inefficient_to_string 2019-10-17 12:41:45 -04:00
Michael Zhang
3328cb25ce
Update adding_lints.md 2019-10-17 12:33:42 -04:00
HMPerson1
106a72592c
Dogfood for inefficient_to_string 2019-10-16 17:12:41 -04:00
HMPerson1
76b44f34b9
Add inefficient_to_string lint 2019-10-16 15:54:20 -04:00
Lzu Tao
d81191e87d Use CI caching and cargo feature install-upgrade 
* do not force to install rustfmt
* use cargo-cache
* disable bash trace
* clone single branch
 2019-10-16 13:14:24 +07:00
bors
07c06738b7 Auto merge of #4669 - lzutao:minimal-rustup, r=phansch 
build: use rustup minimal profile to speed up Rust installation time

changelog: none
 2019-10-16 04:13:38 +00:00
bors
52cebb1f8f Auto merge of #4673 - Manishearth:rustup, r=phansch 
Rustup to rustc 1.40.0-nightly (237d54ff6 2019-10-15)

changelog: none
 2019-10-15 19:58:52 +00:00
Lzu Tao
7de7d0c97b build: use rustup minimal profile to speed up Rust installation time 2019-10-16 02:38:31 +07:00