Matthias Krüger
39f39d5405
match_like_matches_macro: strip refs in suggestion
...
fixes #6503
changelog: match_like_matches_macro: strip refs in suggestion (#6503 )
2021-01-03 20:28:46 +01:00
Jason Newcomb
7b5f54954a
Fix docs: use type inference
2021-01-03 14:04:05 -05:00
bors
4bd77a19f3
Auto merge of #6537 - flip1995:beta, r=ebroto
...
[beta] Backport of #6375 - field_reassign_with_default fix
With the pinned nightly we can test backports to our beta branch now 🎉
cc #6515
changelog: beta 1.50: Backport of private fields fix in [`field_reassign_with_default`] lints
2021-01-03 14:38:43 +00:00
bors
a02806e00d
Auto merge of #6518 - ThibsG:CopyException, r=ebroto
...
Ensure `Copy` exception in trait definition for `wrong_self_conventio…
Add a test case to ensure `Copy` exception is preserved also in trait definition, when passing `self` by value.
Follow up of #6316
changelog: none
2021-01-02 23:51:49 +00:00
bors
592f7eb7eb
Auto merge of #6531 - matthiaskrgr:6522, r=ebroto
...
field_reassign_with_default: don't expand macros in suggestion
fixes #6522
changelog: field_reassign_with_default: don't expand macros in lint suggestion (#6522 )
2021-01-02 23:38:23 +00:00
Jason Newcomb
d37ee6ffa0
Fix lint errors
2021-01-02 14:31:21 -05:00
Jason Newcomb
9427e0356b
Fix clone_on_copy test
2021-01-02 14:15:11 -05:00
Cameron Steffen
fa75f63690
Fix field_reassign_with_default for private fields
2021-01-02 18:25:40 +01:00
Cameron Steffen
f74e2001b9
Remove redundant shadow check
...
There is already an assertion that consecutive lines assign to a struct
field.
2021-01-02 18:25:40 +01:00
Cameron Steffen
173e1ba966
Fix default initialized fields in suggestion
...
The default value for a field type does not necessarily match the
default value for that field in the struct Default.
2021-01-02 18:25:39 +01:00
flip1995
053afe4907
Use bootstrap rustc for versioncheck in Clippy
2021-01-02 18:12:28 +01:00
bors
78f6009878
Auto merge of #6520 - phansch:update-changelog, r=flip1995
...
Update CHANGELOG for Rust 1.50
changelog: none
r? `@flip1995`
2021-01-02 16:13:24 +00:00
Jason Newcomb
1853f8b228
Add lint
2021-01-02 11:08:56 -05:00
flip1995
ba4bf4f9c5
Merge commit '1fcc74cc9e03bc91eaa80ecf92976b0b14b3aeb6' into clippyup
2021-01-02 16:29:43 +01:00
bors
1fcc74cc9e
Auto merge of #6536 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2021-01-02 15:28:08 +00:00
flip1995
e4fbc5f423
Bump Clippy version to 0.1.51
2021-01-02 16:26:10 +01:00
flip1995
106ca96653
Use rustc --version in versioncheck
2021-01-02 16:20:43 +01:00
flip1995
db268f8ef8
Bump nightly version to 2021-01-02
2021-01-02 16:05:54 +01:00
flip1995
d93692efa2
Merge remote-tracking branch 'upstream/master' into rustup
2021-01-02 16:03:26 +01:00
bors
b1965283fd
Auto merge of #6530 - m-ou-se:2021, r=phansch
...
Initial support for Rust 2021.
Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with `==` instead of `>=`. This fixes that, such that 2018-specific things are also enabled for 2021.
changelog: Added support for Rust 2021.
2021-01-02 13:12:15 +00:00
Matthias Krüger
5d48b91b40
field_reassign_with_default: don't expand macros in suggestion
...
fixes #6522
changelog: field_reassign_with_default: don't expand macros in lint suggestion (#6522 )
2021-01-01 17:01:09 +01:00
Mara Bos
e5a1f22f48
Initial support for Rust 2021.
...
Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with
`==` instead of `>=`. This fixes that, such that 2018-specific things
are also enabled for 2021.
2021-01-01 16:21:31 +01:00
Julian Knodt
48dec842f2
first pass at default values for const generics
...
- Adds optional default values to const generic parameters in the AST
and HIR
- Parses these optional default values
- Adds a `const_generics_defaults` feature gate
2021-01-01 10:55:10 +01:00
bors
60919e416d
Auto merge of #6526 - matthiaskrgr:version, r=Manishearth
...
make clippy version number correspond to rustc version number.
clippy 0.1.50 corresponds to rustc 1.50.x
This bumps the clippy version number from 0.0.212 to 0.1.50
Fixes #6499
Notes:
I used `cargo --version` because that way we can honour the version set in the `rust-toolchain` file.
When we bump the bootstrap compiler from 1.50 to 1.51, the version numbers will have to be changed to 1.51 or the test will fail.
---
changelog: make clippy version number correspond to rustc version number (rust 1.50.0 -> clippy 0.1.50)
2021-01-01 09:01:32 +00:00
Matthias Krüger
59397d6abb
make clippy version number correspond to rustc version number.
...
clippy 0.1.50 corresponds to rustc 1.50.x
This bumps the clippy version number from 0.0.212 to 0.1.50
Fixes #6499
2020-12-31 16:29:26 +01:00
Philipp Hansch
69090550cb
s/test_dir/test_suite_dir
...
This should make the code slightly more understandable
2020-12-31 12:53:29 +01:00
Philipp Hansch
6b37932268
Fix blessing of test output in subdirectories
...
The core issue was the usage of `reference_file_path.file_name()`, which
provided a non-existent path if the file to be updated was in a
subdirectory.
Instead we have to provide the whole path after 'tests/ui/' as the
'filename'. This part of the path is called `test_name` in the code now.
2020-12-31 12:49:43 +01:00
Mara Bos
7f44f1d038
Rollup merge of #80495 - jyn514:rename-empty, r=petrochenkov
...
Rename kw::Invalid -> kw::Empty
See https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Is.20there.20a.20symbol.20for.20the.20empty.20string.3F/near/220054471
for context.
r? `@petrochenkov`
2020-12-30 20:56:58 +00:00
Philipp Hansch
b81111bc35
Address review comments
2020-12-30 17:29:15 +01:00
Philipp Hansch
0afe2dbad8
Update CHANGELOG for Rust 1.50
2020-12-30 17:10:07 +01:00
Joshua Nelson
5479bbaf72
Rename kw::Invalid -> kw::Empty
...
See https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Is.20there.20a.20symbol.20for.20the.20empty.20string.3F/near/220054471
for context.
2020-12-30 09:50:02 -05:00
ThibsG
af480a67be
Ensure Copy exception in trait definition for wrong_self_convention lint
2020-12-30 12:02:26 +01:00
Aaron Hill
6fd18f95ca
Remove unnecessary semicolon from Clippy test
2020-12-29 17:16:04 -05:00
nahuakang
275988cb73
Add additional lint doc to known problems section
2020-12-28 20:45:56 +01:00
nahuakang
83a458acf1
Enable never type in empty enum ui test; run cargo dev bless
2020-12-28 20:18:27 +01:00
bors
0d8a27a6f6
Auto merge of #6510 - alex-700:fix-ptr-arg-lint, r=llogiq
...
don't ignore expression after first not matched method call in PtrCloneVisitor
fixes #6509
changelog: none
2020-12-28 19:04:30 +00:00
nahuakang
469281c0dd
Check if never type feature is enabled by TyCtxt before suggesting empty enum lint
2020-12-28 18:59:35 +01:00
Aleksei Latyshev
203715aa4e
don't ignore expression after first not matched method call in PtrCloneVisitor
2020-12-28 01:09:04 +03:00
bors
61a3ee7935
Auto merge of #6506 - alex-700:add-path-buf-to-ptr-arg-lint, r=Manishearth
...
Lint "&PathBuf instead of &Path" in PTR_ARG
fixes #6502
changelog: lint "`&PathBuf` instead of `&Path`" in `PTR_ARG`
2020-12-27 17:59:52 +00:00
bors
3661848997
Auto merge of #6375 - camsteffen:reassign-default-private, r=flip1995
...
Reassign default private
changelog: fix field_reassign_with_default false positive
* Fix #6344
* Fix assumption that `field: Default::default()` is the same as `..Default::default()`
* Cleanup some redundant logic
2020-12-27 16:20:47 +00:00
bors
015496579d
Auto merge of #6495 - matthiaskrgr:FN_FP_issue_templates, r=flip1995
...
ISSUE_TEMPLATE: add templates for false negative and false positive tickets.
These will add the correct labels automatically so we don't have to do that ourselves :)
changelog: none
2020-12-27 12:53:04 +00:00
bors
b1e0d15d58
Auto merge of #6505 - giraffate:fix_style_of_texts_in_map_err_ignore, r=phansch
...
Fix a style of texts in `map_err_ignore`
It's a small fix of texts.
changelog: none
2020-12-25 15:47:31 +00:00
Aleksei Latyshev
dfaea9c967
lint &PathBuf instead of &Path in PTR_ARG
...
- extract get_only_generic_arg_snippet to improve readability
2020-12-25 15:06:34 +03:00
Takayuki Nakata
e1743ef525
Fix a style of texts in map_err_ignore
2020-12-25 08:59:34 +09:00
bors
02399f4b25
Auto merge of #6504 - matthiaskrgr:cifix, r=matthiaskrgr
...
fix ci on master branch; run the --fix test in the correct directory
Turned out the --fix test was run in the wrong directory.
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: none
2020-12-24 13:37:08 +00:00
Matthias Krüger
2218dd6554
ci: run cargo clippy --fix -Zunstable-options in the correct directory.
2020-12-24 13:57:39 +01:00
Matthias Krüger
3687de2159
ISSUE_TEMPLATE: add templates for false negative and false positive tickets.
2020-12-23 12:28:16 +01:00
flip1995
88491e2a51
Special sync of 'e89801553ddbaccdeb2eac4db08900edb51ac7ff'
2020-12-23 10:57:35 +01:00
bors
5c981359a8
Auto merge of #6483 - xFrednet:5386-github-ticket-search, r=killercup
...
Website issue tracker link and better search performance
This PR implements some improvements to the website:
1. Added a "Search on Github" link to the "Known problems" section (Closes #5386 )
<details>
<summary>Another mock up I created with the GitHub logo</summary>
</details>
2. Only starting the search after three letters and improving the search performance in general. (Followup #6477 )
### Testing
These changes can be tested locally by:
1. Clone this branch
2. Download the current lint index from the [gh-pages branch](https://github.com/rust-lang/rust-clippy/blob/gh-pages/master/lints.json )
3. Put it next to the `util/gh-pages/index.html` and open the html file. Make sure that it can load the lint data. (Browsers can be a bit iffy when opening a local html page and loading data)
### Sources for search performance:
1. [A stackoverflow about angular filter performance](https://stackoverflow.com/questions/26876514/optimize-angular-filter-performance )
* I selected a search debounce of 50ms that's fast enough to catch fast deletion and typing but responsive enough to not bother the user
2. [A stackoverflow about string comparison speeds](https://stackoverflow.com/questions/5296268/fastest-way-to-check-a-string-contain-another-substring-in-javascript )
3. [JS benchmarks for string search performance (`indexOf` seams to be the best)](https://jsben.ch/9cwLJ )
Note: The performance is still a bit poor when going from a specific lint to no search filter. I suspect that angular is recreating all lint items when the filter is cleared causing a major lag spike. The filter functions is at least optimized for little to no search.
---
changelog: Added a "Search on GitHub" link to the website
2020-12-23 00:25:05 +00:00
bors
971e5b33da
Auto merge of #6496 - matthiaskrgr:test_fix, r=Manishearth
...
ci: test cargo clippy --fix -Zunstable-options
Make sure we catch cases like https://github.com/rust-lang/rust-clippy/issues/6487 in CI in the future.
---
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: none
2020-12-22 22:59:21 +00:00
