Commit graph

2621 commits

Author SHA1 Message Date
Oliver Schneider
8e1f6dce40 enum detection by style convention 2016-12-02 19:30:00 +01:00
Oliver Schneider
ff2487b30e permit more equalities 2016-12-02 19:23:30 +01:00
Oliver Schneider
cf1fa94be1 down to for-loops not comparing as equal 2016-12-02 19:19:52 +01:00
Oliver Schneider
16aab71688
enum glob use and copies left 2016-12-02 17:38:31 +01:00
Wim Looman
919feaaec5 Allow allow(deprecated) attribute on use items
fixes #1372
2016-12-01 22:36:35 +01:00
Oliver Schneider
59b0077565 WIP compiles and doesn't crash (much) but tests are failing 2016-12-01 22:31:56 +01:00
Manish Goregaokar
f9fe50da1e Merge pull request #1369 from durka/no-service
fix travis config for clippy.bashy.io
2016-11-28 16:03:36 -08:00
Alex Burka
c5187ef0d9 travis: ping correct repo for clippy.bash.io 2016-11-28 18:59:23 -05:00
Alex Burka
33ec3bc8cf don't advertise clippy.bashy.io 2016-11-28 18:59:15 -05:00
Oliver Schneider
aac4c3f654 Merge pull request #1367 from Manishearth/rustup
rustup to rustc 1.15.0-nightly (d5814b03e 2016-11-23)
2016-11-25 19:33:53 +01:00
Oliver Schneider
31e482403c rustup to rustc 1.15.0-nightly (d5814b03e 2016-11-23) 2016-11-25 19:24:55 +01:00
Phil Turnbull
0ee6128e27 Convert DEREF_ADDROF to EarlyLintPass 2016-11-25 10:33:21 -05:00
Phil Turnbull
8d04038c56 Make deref_addrof suggestions stricter
SUGGESTION matches a substring so 'aref' in the testcases can match
'let b = *aref', 'let b = **aref', 'let b = *&aref' etc, which are
all wrong.
2016-11-25 10:33:01 -05:00
Martin Carton
11ca07c8ad Merge pull request #1360 from Manishearth/rustup
Rustup to *rustc 1.15.0-nightly (3bf2be9ce 2016-11-22)* and bump to 0.0.102
2016-11-24 18:12:20 +01:00
Oliver Schneider
9717b9585d Merge pull request #1363 from hdhoang/patch-2
useless_format: fix typo
2016-11-24 11:20:52 +01:00
Oliver Schneider
84d9872785 Merge pull request #1362 from hdhoang/patch-1
let_if_seq: fix rewrite example
2016-11-24 11:19:57 +01:00
Hoàng Đức Hiếu
f5ccc2fe6f useless_format: fix typo 2016-11-24 16:10:22 +07:00
Hoàng Đức Hiếu
4215292793 let_if_seq: fix rewrite example 2016-11-24 16:09:09 +07:00
mcarton
9a92ed4e3e
Bump to 0.0.102 2016-11-23 22:45:00 +01:00
mcarton
c7e3cc1e27
Rustup to *rustc 1.15.0-nightly (3bf2be9ce 2016-11-22)* 2016-11-23 22:44:00 +01:00
Martin Carton
0b7de0d01f Merge pull request #1357 from Manishearth/rustup
Rustup to *rustc 1.15.0-nightly (7b3eeea22 2016-11-21)* and bump to 0.0.101
2016-11-23 21:39:12 +01:00
mcarton
338690b4e9
Bump to 0.0.101 2016-11-23 21:31:59 +01:00
mcarton
c35f82b823
Rustup to *rustc 1.15.0-nightly (7b3eeea22 2016-11-21)* 2016-11-23 21:31:55 +01:00
Phil Turnbull
a9f5b90f0f Lint usage of *& and *&mut
fixes #1316
2016-11-22 21:06:20 -05:00
Martin Carton
530083c3b9 Merge pull request #1349 from philipturnbull/extend-chars
Lint `.extend(s.chars())` (closes #792)
2016-11-22 18:21:30 +01:00
Phil Turnbull
8705f3d11c Remove mention of .push_str(s) being faster
For the `.push_str(str.chars())` case the compiler will inline `push_str` and
call `extend_from_slice` on the underlying vector, so this isn't actually
faster.
2016-11-20 17:28:14 -05:00
Phil Turnbull
e9f3911899 Suggest &s instead of s.as_str() 2016-11-20 11:19:36 -05:00
Oliver Schneider
e2908dfc82 Merge pull request #1347 from sinkuu/conditional_returns
Allow explicit returns with cfg attributes
2016-11-20 09:21:25 +01:00
Daniel S Poulin
e40cb6a9dd Further clarify recommended usage
Pushed the section on hard dependency installation to the bottom of the usage methods to further discourage its use. Also included a note in that section warning that it is not the recommended method. Lastly, changed what was said in the opening paragraph of the Usage section to reflect the multitude of options.
2016-11-19 22:16:36 -05:00
sinkuu
5d40965b50 Fix #1346 2016-11-20 10:15:40 +09:00
sinkuu
1973e94550 Allow explicit returns with cfg attributes 2016-11-20 10:02:41 +09:00
Martin Carton
501ff22402 Merge pull request #1351 from Manishearth/rustup-2016-11-18
Rustup to *rustc 1.15.0-nightly (ac635aa95 2016-11-18)* and bump to 0.0.100
2016-11-20 00:19:38 +01:00
mcarton
40fcae112d
Bump to 0.0.100 2016-11-20 00:14:25 +01:00
mcarton
be799bc085
Rustup to *rustc 1.15.0-nightly (ac635aa95 2016-11-18)* 2016-11-20 00:13:08 +01:00
Phil Turnbull
73a73638c0 Add lint for string.extend(string.chars())
fixes #792
2016-11-19 14:55:47 -05:00
Phil Turnbull
fa78b09fa7 Add lint for string.extend("str".chars())
fixes #792
2016-11-19 14:55:02 -05:00
Phil Turnbull
0ab7e6c598 Factor out lint_vec_extend 2016-11-19 14:44:32 -05:00
Daniel S Poulin
5a415f67de Clarify recco to install as a soft dependency
On IRC it was mentioned that clippy is not meant to be installed as a hard dependency.
As it was, the README placed the hard dependency instructions first and did not
mention the recommendation, misleading users into making it a hard dependency. A
quick survey of the dependent crates on crates.io reveals the reach of this issue.
2016-11-18 22:46:12 -05:00
Martin Carton
276e85b700 Merge pull request #1344 from Manishearth/rustup
[WIP] Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14)
2016-11-18 13:47:07 +01:00
mcarton
1176242b72 Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14) 2016-11-18 13:40:53 +01:00
mcarton
7140eac484 Cleanup 2016-11-18 13:40:44 +01:00
Oliver Schneider
f39c6278e1
fix the inspector 2016-11-18 13:21:07 +01:00
mcarton
945c027768
Handle closure with single expression blocks 2016-11-17 19:44:18 +01:00
mcarton
19c5f5394b
Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14) 2016-11-16 23:05:26 +01:00
Manish Goregaokar
bad26a5aca Merge pull request #1339 from dereckson/patch-1
Recognize quux as a metasyntactic variable
2016-11-10 21:20:13 -08:00
Sébastien Santoro
0e6807e86b Recognize quux as a metasyntactic variable
quux is another metasyntactic variable like foo and so
should be detected by the blacklisted names linter.
2016-11-11 05:57:29 +01:00
Martin Carton
3edf712434 Merge pull request #1337 from oli-obk/master
fix ice in `len_zero` lint when type has no inherent impls at all
2016-11-10 18:51:08 +01:00
Oliver 'ker' Schneider
cfae1e9fda fix ice in len_zero lint when type has no inherent impls at all
fixes #1336
2016-11-10 17:06:39 +01:00
Oliver Schneider
2cfe1e7b64 Merge pull request #1328 from Machtan/master
Add '--version' flag and allow version and help flags when called as 'cargo-clippy'
2016-11-09 10:49:16 +01:00
Jakob Lautrup Nysom
2d9386f86d Remove unnecessary #[allow] 2016-11-09 10:44:55 +01:00