Nathan Whitaker
a1bb10e9b8
Remove lint from clippy
2020-10-26 18:19:48 -04:00
dvermd
6212950ceb
Explain why 'run-rustfix' is not defined
2020-10-26 23:00:10 +01:00
dvermd
8337c467e9
Change Applicability to MaybeIncorrect
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-26 22:34:43 +01:00
dvermd
ffddb669e0
clippy_lint: run after changing category to pendantic
2020-10-26 22:34:43 +01:00
dvermd
db40a07665
Update clippy_lints/src/ref_option_ref.rs
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-26 22:34:43 +01:00
dvermd
7fd74c6bf6
clippy_lint: Add Known Problems message
2020-10-26 22:34:43 +01:00
dvermd
1566db704d
Update clippy_lints/src/ref_option_ref.rs
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-26 22:34:43 +01:00
dvermd
8e26004a5f
Update clippy_lints/src/ref_option_ref.rs doctest
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-26 22:34:43 +01:00
dvermd
2270ff4d16
clippy_lint: Add test cases
2020-10-26 22:34:43 +01:00
dvermd
b41b38cb7f
clippy_lint: Refactor 'ref_option_ref'
2020-10-26 22:34:42 +01:00
dvermd
bdd76a9d1c
clippy_lint: Allow 'ref_option_ref' for 'option_if_let_else'
2020-10-26 22:34:42 +01:00
dvermd
c1f3bab6b1
clippy_lint: Add 'ref_option_ref' remove unused import
2020-10-26 22:34:42 +01:00
dvermd
469b2fc781
clippy_lint: Add 'ref_option_ref' move to check_ty and add type alias test
2020-10-26 22:34:42 +01:00
dvermd
d1baa25f04
clippy_lint: Add 'ref_option_ref' refactor code
2020-10-26 22:34:42 +01:00
dvermd
213dbf7aac
clippy_lint: Add 'ref_option_ref'
2020-10-26 22:34:40 +01:00
ThibsG
c0dd1f9f76
Fix tests for map_unwrap_or*
2020-10-26 11:15:01 +01:00
ThibsG
e2d86b5b80
Move fixable filter_next and filter_map_next cases to rustfixed tests
2020-10-26 11:02:07 +01:00
ThibsG
2a3ae11485
Move fixable map_unwrap_or cases to rustfixed test
2020-10-26 11:02:07 +01:00
ThibsG
3fec6f568d
Improve some suggestions for filter_map_next, filter_next and map_unwrap_or lints
2020-10-26 11:02:07 +01:00
ThibsG
2911d9c7de
Use better placeholders for some methods lint messages
2020-10-26 11:02:07 +01:00
ThibsG
bab338685f
No lint in external macro for toplevel_ref_arg
2020-10-26 10:14:03 +01:00
HMPerson1
f0cf3bdca1
Add lint for replacing .map().collect() with .try_for_each()
2020-10-25 21:20:57 -04:00
Urcra
45aa3ef8dd
Remove unnecesary format
2020-10-26 01:55:44 +01:00
Urcra
4532dd9e43
run cargo fmt
2020-10-26 01:31:13 +01:00
Urcra
4cf5b5ff70
Run update lints
2020-10-26 01:21:34 +01:00
Urcra
deecfb5d13
Add description to lint
2020-10-26 01:02:10 +01:00
Urcra
4417af801d
Revert changes to Cargo.toml file
2020-10-26 00:53:51 +01:00
Urcra
7f7faa1ccf
Move implementation into len_zero.rs
2020-10-26 00:51:18 +01:00
Urcra
de5a6d3420
Initial implementation of comparison_to_empty
2020-10-26 00:31:25 +01:00
bors
afbac8906e
Auto merge of #6225 - rust-lang:flip1995-patch-1, r=flip1995
...
Update triagebot.toml
r? `@ghost`
changelog: none
2020-10-25 20:35:17 +00:00
Philipp Krones
80b21682bf
Update triagebot.toml
2020-10-25 21:34:46 +01:00
bors
83bb5ecec8
Auto merge of #6202 - giraffate:fix_invalid_suggestion_in_needless_collect_test, r=flip1995
...
Fix an invalid suggestion in `needless_collect` test
A test, https://github.com/rust-lang/rust-clippy/blob/master/tests/ui/needless_collect_indirect.rs#L11-L12 , suggests following codes, but the suggested codes don't work. An example is here: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6947d9f2806a83f41cc5eb8e39b09d0b .
```
error: avoid using `collect()` when not needed
--> $DIR/needless_collect_indirect.rs:11:5
|
LL | / let indirect_contains = sample.iter().collect::<VecDeque<_>>();
LL | | indirect_contains.contains(&&5);
| |____^
|
help: Check if the original Iterator contains an element instead of collecting then checking
|
LL |
LL | sample.iter().any(|x| x == &&5);
```
changelog: none
2020-10-25 17:35:33 +00:00
bors
15f6fb99e4
Auto merge of #6194 - giraffate:remove_an_extra_blank_line, r=flip1995
...
Remove an extra blank line in doc examples
It seems to be an extra blank line in doc example.
changelog: none
<img width="1141" alt="スクリーンショット 2020-10-19 10 32 21" src="https://user-images.githubusercontent.com/17407489/96392372-d0583200-11f6-11eb-9aab-f7e8f87eb04e.png ">
2020-10-25 17:15:42 +00:00
bors
eceebc3448
Auto merge of #6183 - cgm616:hex_bin_digit_grouping, r=flip1995
...
Hex bin digit grouping
This revives and updates an old pr (#3391 ) for the current API.
Closes #2538 .
---
*Please keep the line below*
changelog: Add [`unusual_byte_groupings`] lint.
2020-10-25 16:40:14 +00:00
bors
4242ef8ecd
Auto merge of #6224 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2020-10-25 15:45:12 +00:00
flip1995
77746b9060
Merge remote-tracking branch 'upstream/master' into rustup
2020-10-25 16:43:53 +01:00
cgm616
312bbff696
Integrate suggestions from code review
2020-10-25 11:31:24 -04:00
Takayuki Nakata
2f5d418011
Add test case
2020-10-26 00:01:20 +09:00
Takayuki Nakata
3ce820bf83
Fix an invalid suggestion in needless_collect test
2020-10-25 23:58:14 +09:00
cgm616
e7e4b35bdf
Fix logic mistake
2020-10-25 09:34:46 -04:00
cgm616
0c0f8db347
Remove accidental test inclusion
2020-10-25 09:19:58 -04:00
cgm616
f5a88b6de5
Allow hex literals to pass w/ groups of 2
2020-10-25 09:18:38 -04:00
Florian Hartwig
db8380c4a0
Add lint for unusually-grouped hex/binary literals
2020-10-25 09:18:38 -04:00
bors
9c9aa2db52
Auto merge of #6222 - JohnTitor:redundant-local-def-id, r=flip1995
...
Remove redundant `expect_local()` call
The field `owner` of `HirId` is `LocalDefId` and `hir_id.owner.to_def_id().expect_local()` is redundant. I wonder they were introduced in some rustups.
changelog: none
2020-10-25 11:58:51 +00:00
bors
718bb28f68
Auto merge of #6211 - ThibsG:NeedlessBoolCfg, r=flip1995
...
No lint with `cfg!` and fix sugg for macro in `needless_bool` lint
Don't lint if `cfg!` macro is one of the operand.
Fix suggestion when the span originated from a macro, using `hir_with_macro_callsite`.
Fixes : #3973
changelog: none
2020-10-25 11:37:18 +00:00
bors
38be214724
Auto merge of #6198 - montrivo:needless-lifetime, r=flip1995
...
needless-lifetime / multiple where clause predicates regression
Closes #6159 .
changelog: fix regression in needless-lifetimes
2020-10-25 11:15:01 +00:00
bors
90cb25d3f6
Auto merge of #6177 - rust-lang:manual-range-contains, r=flip1995
...
New lint: manual-range-contains
This fixes #1110 , at least for the contains-suggesting part.
- \[x] Followed [lint naming conventions][lint_naming]
- \[x] Added passing UI tests (including committed `.stderr` file)
- \[x] `cargo test` passes locally
- \[x] Executed `cargo dev update_lints`
- \[x] Added lint documentation
- \[x] Run `cargo dev fmt`
---
changelog: new lint: manual-range-contains
2020-10-25 10:35:46 +00:00
Yuki Okushi
d5713898ac
Remove redundant expect_local() call
2020-10-25 19:30:00 +09:00
bors
399732bf79
Auto merge of #6103 - FrancisMurillo:mut_mutex_lock, r=flip1995
...
Add lint for `&mut Mutex::lock`
Fixes #1765
changelog: Add lint [`mut_mutex_lock`] for `&mut Mutex::lock` and suggests using `&mut Mutex::get_mut` instead.
2020-10-25 10:16:23 +00:00
bors
fd62c180fe
Auto merge of #6162 - josephlr:empty-loop-no-std, r=flip1995
...
Update empty_loop documentation/message.
Originally part of #6161 , but now this PR only deals with `std` crates
This change:
- Updates the `std` message .
- Updates the docs to mention how the busy loops should be fixed
- Gives examples of how to do this for `no_std` targets
- Updates the tests/stderr files to test this change.
changelog: Update `empty_loop` lint documentation
2020-10-25 09:56:16 +00:00
