Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-23 11:33:19 +00:00
Code Issues Projects Releases Packages Wiki Activity
5634 commits 4 branches 212 tags 144 MiB
Commit graph

5634 commits

This branch
This branch
All branches
Author SHA1 Message Date
Kampfkarren
985eba08a5 Line length fix 2018-12-13 10:46:21 -08:00
Kampfkarren
db00c3320f Remove references to sized for end users 2018-12-13 10:18:17 -08:00
Kampfkarren
9fc914cf4d Remove DUMMY_SP 2018-12-13 09:37:00 -08:00
Kampfkarren
616395f40b Add suggestion for replacement 2018-12-13 09:34:16 -08:00
Kampfkarren
e5ea5395b9 Update lint definitions 2018-12-13 09:14:01 -08:00
Kampfkarren
ab070508be Lint for Vec<Box<T: Sized>> - Closes #3530 2018-12-13 07:43:13 -08:00
bors
379c934f3f Auto merge of #3535 - sinkuu:fixes, r=phansch 
Fix some problems

Fixes #2892, #3199, #2841, #3476
 2018-12-12 19:17:09 +00:00
bors
777c9099e7 Auto merge of #3510 - phansch:fix_doc_markdown_mixed_case, r=flip1995 
Fix doc_markdown mixed case false positive

Fixes #2343
 2018-12-12 18:36:38 +00:00
Philipp Hansch
778723630c
Fix doc_markdown mixed case false positive 2018-12-12 19:25:27 +01:00
bors
7c823cabab Auto merge of #3450 - phansch:structured_sugg_for_explicit_write, r=flip1995 
Add suggestion for explicit_write lint

Closes #2083
 2018-12-12 18:11:13 +00:00
bors
2f467ac6f0 Auto merge of #3544 - flip1995:rollup, r=flip1995 
Rollup of 3 pull requests

Successful merges:

 - #3509 (Fix doc_markdown off by one issue)
 - #3539 (Fix rvm/gpg bug in travis osx build)
 - #3540 (rustup https://github.com/rust-lang/rust/pull/56092)

Failed merges:

r? @ghost
 2018-12-12 17:45:55 +00:00
Philipp Krones
b7a431ea1d
Rollup merge of #3540 - matthiaskrgr:rustup, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/56092

fix ui test cast_alignment failure by adding #![feature(rustc_private)]
 2018-12-12 18:17:01 +01:00
Philipp Krones
0cabbbdbb8
Rollup merge of #3539 - flip1995:travis_osx_fix, r=oli-obk 
Fix rvm/gpg bug in travis osx build

Apparently this workaround isn't needed anymore ([travis](https://travis-ci.org/flip1995/rust-clippy/jobs/467027571)) and fixes the latest osx failures: [travis](https://travis-ci.org/rust-lang/rust-clippy/jobs/467013498#L152)
 2018-12-12 18:17:00 +01:00
Philipp Krones
c974ccaf40
Rollup merge of #3509 - phansch:fix_doc_markdown_bugs, r=flip1995 
Fix doc_markdown off by one issue

Fixes #2210
 2018-12-12 18:16:59 +01:00
Matthias Krüger
016c996e16 rustup https://github.com/rust-lang/rust/pull/56092 
fix ui test cast_alignment failure by adding #![feature(rustc_private)]
 2018-12-12 17:23:07 +01:00
flip1995
5527edd956
Fix rvm/gpg bug in travis osx build 2018-12-12 15:37:31 +01:00
bors
f5d6aca197 Auto merge of #3537 - matthiaskrgr:fix_script_2, r=matthiaskrgr 
base-tests: don't print all commands to stdout during the loop

Fixes thinko in #3529
 2018-12-12 09:56:38 +00:00
Matthias Krüger
591738c35a base-tests: don't print all commands to stdout during the loop 2018-12-12 10:27:13 +01:00
Shotaro Yamada
eba44e1c67 question_mark: Suggest Some(opt?) for if-else 2018-12-12 18:13:21 +09:00
Shotaro Yamada
eb54c1a9a0 redundant_field_names: Do not trigger on path with type params 
Fixes #3476
 2018-12-12 17:41:52 +09:00
Shotaro Yamada
28635ff04b question_mark: Lint only early returns 2018-12-12 17:41:51 +09:00
Shotaro Yamada
05d07155b7 question_mark: Fix applicability 2018-12-12 17:40:25 +09:00
bors
921d4da103 Auto merge of #3536 - matthiaskrgr:fix_script, r=oli-obk 
fix typo in script
 2018-12-12 08:27:12 +00:00
Matthias Krüger
7fe39c9c6e fix typo in script 2018-12-12 09:17:43 +01:00
Philipp Hansch
1cfbadb029
Fix doc_markdown off by one issue 2018-12-12 08:21:13 +01:00
Shotaro Yamada
d2e5a8ccf5 Remove obsolete comment 2018-12-12 16:08:06 +09:00
Shotaro Yamada
bcbbb4d09b new_without_default, partialeq_ne_impl: Use span_lint_node 
Fixes #2892, fixes #3199
 2018-12-12 16:08:05 +09:00
bors
f26c39bab7 Auto merge of #3533 - phansch:add_to_doc_valid_idents, r=phansch 
Add 'CamelCase' to doc_valid_idents

Fixes #2395
 2018-12-12 06:46:21 +00:00
Philipp Hansch
194acaf8e7
Update .stderr after rebase 2018-12-12 07:33:23 +01:00
Philipp Hansch
499aad1e04
cargo fmt and remove stabilized feature 2018-12-12 07:31:04 +01:00
Philipp Hansch
752724546a
Make suggestion Applicability::MachineApplicable 2018-12-12 07:31:04 +01:00
Philipp Hansch
9a6216ed05
Address review feedback 
* Fix typo
* Handle None value instead of using `unwrap()`
* `pop()` instead of `x.truncate(x.len() - 1)`
 2018-12-12 07:31:04 +01:00
Philipp Hansch
5f007a88b4
Extract method 2018-12-12 07:31:04 +01:00
Philipp Hansch
7e7a33c726
Check array lengths to prevent OOB access 2018-12-12 07:31:04 +01:00
Philipp Hansch
c4c9d9fc62
Add suggestion for explicit_write lint 2018-12-12 07:31:01 +01:00
bors
e2608fc272 Auto merge of #3529 - matthiaskrgr:rustfmt_tests, r=phansch 
rustfmt tests

also fails CI if tests turn out to not be formatted properly.
 2018-12-12 05:57:31 +00:00
Matthias Krüger
36266b3e6c test reformatting: revert more questionable changes done by rustfmt and add #[rustfmt::skip] 2018-12-11 20:50:55 +01:00
Philipp Hansch
ee2abc36a3
Add 'CamelCase' to doc_valid_idents 2018-12-11 19:37:43 +01:00
bors
82e6dbb07c Auto merge of #3532 - maxencefrenette:fix-contributing-md, r=oli-obk 
Remove dead link in CONTRIBUTING.md

I don't think there was an issue for this, but this is just removing a dead link in CONTRIBUTING.md. The _Linting Clippy with your local changes_ section seems to have been removed without updating the table of contents.

I'm not sure if I should have opened an issue, but it seemed like a trivial fix to me.
 2018-12-11 11:55:59 +00:00
Maxence Frenette
804729cdaa Remove dead link in CONTRIBUTING.md 2018-12-11 05:10:41 -05:00
bors
d6db67793e Auto merge of #3527 - phansch:update_readme2, r=matthiaskrgr 
readme: tool lints are stable now

None
 2018-12-11 06:55:48 +00:00
Michael Wright
c6505aa160 Fix write_with_newline escaping false positive 
Fixes #3514
 2018-12-11 08:44:49 +02:00
Matthias Krüger
743e9e3561 Merge branch 'master' into rustfmt_tests 2018-12-11 01:42:38 +01:00
Matthias Krüger
625ca772b5 tests: fix more cases where rustfmt would have hurt the tests 2018-12-11 01:31:04 +01:00
Matthias Krüger
f1d5194e3d tests: revert some changs and add further rustfmt::skip attributes. 2018-12-11 00:59:59 +01:00
Philipp Hansch
0c93e4cdb2
s/clippy/Clippy in readme 2018-12-10 22:30:16 +01:00
Philipp Hansch
d4da776ea7
Also add note about using -W clippy::lint_group 2018-12-10 22:22:57 +01:00
Philipp Hansch
04e251f623
readme: tool lints are stable now 2018-12-10 22:04:27 +01:00
bors
0fd7fe9a77 Auto merge of #3511 - phansch:remove_allow_doc_markdown, r=phansch 
Remove allow(doc_markdown) in excessive_precision.rs

Closes #3299
 2018-12-10 19:21:25 +00:00
bors
ada0b2b095 Auto merge of #3518 - sinkuu:redundant_clone_tw, r=phansch 
Lint redundant clone of fields

Makes `redundant_clone` warn on unnecessary `foo.field.clone()` sometimes (it can detect an unnecessary clone only if the base of projection, `foo` in this case, is not used at all after that). This is enough for cases like `returns_tuple().0.clone()`.
 2018-12-10 18:55:49 +00:00