Oliver Schneider
0e4c49b145
Handfix dogfood issues with the rustfmt changes
2017-08-14 09:43:26 +02:00
Oliver Schneider
b25b6b3355
Rustfmt
2017-08-14 09:43:26 +02:00
Arnavion
d3bdec216b
Canonicalize --manifest-path argument before comparing it to cargo metadata.
...
Before this change, a relative path like `--manifest-path=./Cargo.toml` would
fail to find a matching package in the cargo metadata. With this change,
both the argument and the cargo metadata path are canonicalized before
comparison.
2017-07-28 15:22:31 -07:00
Arnavion
db7a5c69f1
Fix logic that determines closest parent crate when invoked from a subdirectory.
...
The previous logic incorrectly matches the deepest child of the current
directory that is a crate.
2017-07-27 00:04:17 -07:00
Oliver Schneider
e88c29cf34
Merge pull request #1860 from Vurich/master
...
Allow cargo-clippy to work in subdirectories
2017-07-04 19:32:09 +02:00
Oliver Schneider
01bb0f9e51
ignore needless_lifetimes false positive
2017-07-04 16:07:33 +02:00
Oliver Schneider
b8ecdc1cef
Merge pull request #1852 from Manishearth/notrans
...
Use `--emit=metadata` instead of `-Zno-trans`
2017-07-03 09:29:54 +02:00
messense
edadbff4ea
Fix compilation on rustc 1.20.0-nightly (067971139 2017-07-02)
2017-07-03 12:26:03 +08:00
Vurich
956a98c0c7
Allow cargo-clippy to work in subdirectories
2017-06-29 12:57:28 +02:00
Oliver Schneider
22dd3eef0b
Use --emit=metadata
instead of -Zno-trans
...
fixes #1500
2017-06-26 14:49:30 +02:00
Oliver Schneider
5842463562
Run rustfmt
2017-04-12 11:06:32 +02:00
Oliver Schneider
8f88ead7d6
Remove some legacy code
2017-03-27 14:51:37 +02:00
Techcable
9aebb59a68
Fix compilation on latest nightly
...
The ability for plugins to add MIR passes was removed as of 4ca9c97ac.
Luckily, we don't use this feature at all and can safely ignore it.
Fixes #1618
2017-03-12 20:13:20 -07:00
Oliver Schneider
a78ca9e955
Run rustfmt
2017-02-28 14:29:06 +01:00
Oliver Schneider
5c2549482a
Get cargo clippy working on 64 bit windows again
...
fixes #1244
2017-02-28 12:47:48 +01:00
Ben Boeckel
1b0749a6d0
main: end error messages with a newline
2017-02-16 13:18:00 -05:00
Andre Bogus
ad01fa9b57
Remove stabilized feature flag
2017-02-11 01:42:14 +01:00
Oliver Schneider
4a70a46d2d
run rustfmt
2017-01-26 11:31:26 +01:00
Oliver Schneider
26e8558d8a
remove rustc-serialize dependency and factor util::cargo
out into a crate
2017-01-26 11:31:26 +01:00
Andre Bogus
94c97d2ec9
formatting
2017-01-15 01:12:16 +01:00
Andre Bogus
dbde3b8e1c
dogfood fallout
2017-01-15 00:33:29 +01:00
Oliver Schneider
0553de8573
run rustfmt on clippy, not only on clippy_lints
2016-12-21 12:36:25 +01:00
Oliver Schneider
ed9d71f2c9
remove nondeterminism by adjusting thresholds
2016-12-21 10:25:14 +01:00
Oliver Schneider
0a7ae5fec8
run rustfmt
2016-12-20 10:20:41 +01:00
mcarton
7dd3679ac3
Fix a couple warnings
2016-12-19 20:31:39 +01:00
Oliver Schneider
2cfe1e7b64
Merge pull request #1328 from Machtan/master
...
Add '--version' flag and allow version and help flags when called as 'cargo-clippy'
2016-11-09 10:49:16 +01:00
Jakob Lautrup Nysom
2d9386f86d
Remove unnecessary #[allow]
2016-11-09 10:44:55 +01:00
debris
d16cc47ae8
fixed #1331
2016-11-08 21:50:35 +01:00
Machtan
e5a5a95a10
Add '--version' flag and use version and help flags when called as 'cargo-clippy'
2016-11-08 14:28:46 +01:00
Machtan
3800bff4de
Add '--version' flag and allow version and help flags when called as 'cargo-clippy'
2016-11-08 13:54:08 +01:00
Oliver 'ker' Schneider
6a73c8f8e3
--sysroot isn't necessary anymore for the outer cargo clippy call
2016-11-08 11:35:26 +01:00
Epicat Supercell
e25b010847
fixed callback changes from rustc 1.14.0-nightly (7c69b0d5a 2016-11-01)
2016-11-02 21:27:42 +02:00
mcarton
ec893a198f
Fix small nits on the help message
2016-10-25 15:09:56 +02:00
mcarton
da943f5ec8
Allow --help
to be any argument
...
Also dogfoog.
2016-10-24 16:29:36 +02:00
mcarton
409b8e7343
Revert "Revert "Automatically defines the clippy
feature""
...
This reverts commit e4dceef7e7
.
2016-10-24 16:04:00 +02:00
mcarton
4923415930
Be more helping with cargo clippy --help
2016-10-24 15:31:11 +02:00
Arnavion
604694bc0b
Use .expect() for extracting the current_dir.
2016-10-23 12:29:33 -07:00
Arnavion
2315a817ce
Changed signature of cargo::metadata according to review comment.
2016-10-23 12:24:16 -07:00
Arnavion
ebbd00b1ab
Don't assume the first package in the result of cargo metadata
is the current crate.
...
Instead find the one with the manifest path that matches the --manifest-path argument or the current directory.
Fixes #1247
2016-10-22 18:15:42 -07:00
mcarton
eec5425b34
Rustup to *rustc 1.14.0-nightly (289f3a4ca 2016-09-29)*
2016-09-30 22:03:21 +02:00
Oliver Schneider
c89c5d21c1
Merge remote-tracking branch 'origin/master' into examples
2016-09-19 15:38:38 +02:00
mcarton
c090c3df21
Rustup to *rustc 1.13.0-nightly (cbe4de78e 2016-09-05)*
2016-09-06 19:04:38 +02:00
mcarton
36d8ca04a1
Add a MISSING_DOCS_IN_PRIVATE_ITEMS
lint
2016-08-23 18:28:39 +02:00
Oliver Schneider
7b717d3152
fallout
2016-08-17 18:35:25 +02:00
Oliver Schneider
59c31d319a
plugin mode still needs to work
2016-08-17 18:26:58 +02:00
Oliver Schneider
e3723cb938
running cargo clippy on a crate that has the clippy plugin enabled errors out due to duplicate lints
2016-08-17 18:09:35 +02:00
Oliver Schneider
0dab78b3e6
unify "test", "bench", "example" and "bin" into one branch
2016-08-17 18:09:35 +02:00
Oliver Schneider
32a0069f67
no println output
2016-08-17 18:09:35 +02:00
Oliver Schneider
6d7269a675
also run clippy on examples
2016-08-17 18:09:35 +02:00
Manish Goregaokar
f006805c4a
Bump to 0.0.82
2016-08-17 09:20:20 +05:30
Sascha Hanse
9aa7701262
make clippy compile again with the latest nightly after rust-lang/rust@65eb024542
2016-08-17 00:21:58 +02:00
Oliver Schneider
871f8dcab3
don't run clippy on dependencies when running cargo clippy
2016-07-04 13:33:48 +02:00
mcarton
3c4af49662
Rustup to ea0dc9297283daff6486807f43e190b4eb561412
2016-07-01 17:44:17 +02:00
mcarton
e4dceef7e7
Revert "Automatically defines the clippy
feature"
...
This reverts commit d7ba66bf44
.
It was causing problems with crates with:
```rust
#![cfg_attr(feature="clippy", plugin(clippy))]
```
2016-06-29 14:29:25 +02:00
Oliver Schneider
36c5026c48
fix cargo clippy when using with --manifest-path
2016-06-21 12:31:30 +02:00
Manish Goregaokar
5b1d849c7e
Revert "fix cargo clippy when using with --manifest-path
"
...
This reverts commit b31bebeea4
.
2016-06-21 15:24:04 +05:30
Oliver Schneider
b31bebeea4
fix cargo clippy when using with --manifest-path
2016-06-21 11:35:34 +02:00
mcarton
489576437d
Cleanup dependencies and features
2016-06-10 00:09:17 +02:00
mcarton
11665a0d79
Dogfood
2016-06-10 00:08:14 +02:00
mcarton
90453fd893
Run rustfmt
...
Only partially apply suggestions.
2016-06-10 00:08:14 +02:00
mcarton
d7ba66bf44
Automatically defines the clippy
feature
2016-06-08 21:53:58 +02:00
Oliver Schneider
8d5524f1da
clippy should work on all systems
2016-06-06 16:43:58 +02:00
Oliver Schneider
a81181b758
don't abort after successfully linting a target
2016-06-06 11:28:09 +02:00
Oliver Schneider
078cc68c52
no indexing
2016-06-02 17:39:28 +02:00
Oliver Schneider
7bb8ba4631
process more kinds of metadata
2016-06-02 17:29:25 +02:00
Oliver Schneider
80e81d351d
add version check to the unit tests
2016-05-30 12:47:04 +02:00
Oliver Schneider
e6a089efa9
dogfood
2016-05-30 11:32:02 +02:00
Oliver Schneider
0818e70497
don't require cargo clippy
to pass a --lib
or --bin x
argument
2016-05-30 11:32:02 +02:00
Oliver Schneider
bf227f4729
split clippy into lints, plugin and cargo-clippy
2016-05-27 13:03:58 +02:00
Oliver Schneider
5eca09793e
needless_borrow reported on &&T when only &T implements Trait and &Trait is required
2016-05-27 12:12:38 +02:00
mcarton
8ac545d0fe
Fix documentation
2016-05-26 00:08:31 +02:00
llogiq
4c347320be
Merge pull request #955 from Manishearth/regexes
...
Regexes
2016-05-26 00:00:07 +02:00
mcarton
51d166f17a
Support RegexBuilder
2016-05-25 21:36:51 +02:00
mcarton
4f11f84dee
Lint binary regexes
2016-05-25 21:14:14 +02:00
Oliver Schneider
bb69e60b30
fix no_effect lint
2016-05-25 18:51:35 +02:00
Oliver Schneider
e90a0be923
simplify mut_mut
lint
2016-05-25 10:40:25 +02:00
Andre Bogus
9cfc42275d
Split new_without_default
and new_without_default_derive
.
...
This is still very slow, because we do a trait lookup for each field.
Perhaps storing the visited types in a set to reuse types would improve
performance somewhat. Also we may want to pre-decide some known types
(e.g. `Vec<T>`, `Option<T>`).
2016-05-24 18:22:18 +02:00
Benoît Zugmeyer
7a9dac4e1c
Let cargo-clippy exit with a code > 0 if some error occured
2016-05-23 22:35:00 +02:00
mcarton
ac2e175c1b
Rustup to *1.10.0-nightly (476fe6eef 2016-05-21)*
2016-05-23 16:36:10 +02:00
mcarton
6dd608e53e
Rustup to *1.10.0-nightly (764ef92ae 2016-05-19)*
2016-05-23 16:11:28 +02:00
mcarton
2a5416d662
Rustup to *1.10.0-nightly (9c6904ca1 2016-05-18)*
2016-05-23 16:11:19 +02:00
Manish Goregaokar
973ae82d72
Merge branch 'pr-942'
2016-05-18 13:13:35 +05:30
mcarton
ca05e93c10
Rustup to *1.10.0-nightly (cd6a40017 2016-05-16)*
2016-05-17 23:25:20 +02:00
Manish Goregaokar
6a309af2f3
Don't panic if cargo rustc fails
2016-05-16 23:13:47 +05:30
Manish Goregaokar
f2f5fefd00
Allow invalid upcast comparisons
2016-05-16 22:52:22 +05:30
Martin Carton
4c4b1af03c
Merge pull request #928 from oli-obk/unnecessary_operation
...
add a companion lint to `no_effect` with suggestions for partially (in-)effective statements
2016-05-13 17:45:58 +02:00
Oliver Schneider
1e897f1552
add a companion lint to no_effect
with suggestions for partially effective statements
2016-05-13 16:43:47 +02:00
Martin Carton
e890bb5e4b
Merge pull request #921 from afck/master
...
fix typos
2016-05-13 12:13:23 +02:00
Andreas Fackler
87df6ae8cb
fix typos
2016-05-13 08:50:51 +03:00
mcarton
a9bea1f52b
Rustup to *1.10.0-nightly (22ac88f1a 2016-05-11)*
2016-05-12 21:22:38 +02:00
Oliver Schneider
610883b7aa
don't suggest closures over constants
...
fixes #917
2016-05-12 10:23:06 +02:00
llogiq
8fa68f1e08
Merge pull request #913 from oli-obk/assign_ops
...
suggest `a op= b` over `a = a op b`
2016-05-11 23:36:10 +02:00
llogiq
c170aa262a
Merge pull request #915 from Manishearth/sysroot
...
Use rustc --print sysroot, bump to v66 r? @llogiq
2016-05-11 21:56:52 +02:00
llogiq
f966778770
Merge pull request #914 from oli-obk/non_expressive_names
...
similar_names fixes
2016-05-11 21:55:38 +02:00
Manish Goregaokar
03a309d182
Use rustc --print sysroot, bump to v66
2016-05-11 11:07:37 -07:00
Oliver Schneider
b0d008bc9d
add known problems
2016-05-11 17:04:27 +02:00
Oliver Schneider
f004120495
properly lint function argument patterns in similar_names
2016-05-11 16:45:06 +02:00
Oliver Schneider
49e2570b77
don't lint at the use-site of bad struct field bindings if they're shorthand
...
fixes #899
2016-05-11 16:44:43 +02:00
Oliver Schneider
c6b4b19a43
suggest a op= b
over a = a op b
2016-05-11 15:32:20 +02:00
Josh Stone
11987f5b6f
Support either rustup or multirust environment variables
...
Fixes #910
2016-05-10 13:45:37 -07:00