dvermd
230d9cbe36
Update clippy_lints/src/ref_option_ref.rs
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-29 17:39:19 +01:00
bors
e01d4875e9
Auto merge of #6248 - giraffate:replace_e_easy_with_good_first_issue, r=flip1995
...
Replace `E-easy` with `good first issue` in `CONTRIBUTING.md`
`E-easy` isn't used, so `good first issue` is more appropriate.
changelog: none
2020-10-29 15:54:38 +00:00
bors
c57d8ae515
Auto merge of #6227 - HMPerson1:collect_map, r=phansch
...
Add lint for replacing `.map().collect()` with `.try_for_each()`
Fixes #6208
changelog: Add `map_collect_result_unit`
2020-10-29 15:34:15 +00:00
Takayuki Nakata
38ec920fb0
Update CONTRIBUTING.md to describe E-medium
in detail
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-30 00:24:29 +09:00
bors
e1a2845558
Auto merge of #6226 - Urcra:master, r=flip1995
...
Add lint for comparing to empty slices instead of using .is_empty()
Hey first time making a clippy lint
I added the implementation of the lint the `len_zero` since it shared a lot of the code, I would otherwise have to rewrite. Just tell me if the lint should use it's own file instead
changelog: Add lint for comparing to empty slices
Fixes #6217
2020-10-29 15:12:24 +00:00
bors
ee9da9a194
Auto merge of #6176 - achris:issues/578, r=phansch
...
Lint items after statements in local macro expansions
The items_after_statements lint was skipping all expansions. Instead
we should still lint local macros.
Fixes #578
---
*Please keep the line below*
changelog: The items_after_statements now applies to local macro expansions
2020-10-29 14:51:41 +00:00
Christian Nielsen
e3de544c22
Remove empty lines in doc comment
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-29 15:49:42 +01:00
bors
e8de57c20d
Auto merge of #6212 - ThibsG:MacroTopLevelRefArg, r=flip1995
...
No lint in macro for `toplevel_ref_arg`
Do not lint when the span is from a macro.
Question: shouldn't we extend this for external macros also ?
Fixes : #5849
changelog: none
2020-10-29 14:29:30 +00:00
henil
e97602e482
Update existing arithmetic lint and add new tests related to it.
2020-10-29 19:08:52 +05:30
bors
6d5cd6eb8d
Auto merge of #6264 - matthiaskrgr:ra_setup_no_twice, r=llogiq
...
cargo dev ra-setup: don't inject deps multiple times if we have already done so
Fixes #6220
changelog: none
2020-10-29 07:49:27 +00:00
Matthias Krüger
7f3462aa89
cargo dev ra-setup: don't inject deps multiple times if we have already done so
...
Fixes #6220
2020-10-29 03:22:02 +01:00
Eduardo Broto
50419118b4
Merge commit '645ef505da378b6f810b1567806d1bcc2856395f' into clippyup
2020-10-28 23:36:07 +01:00
Matthias Krüger
abd64d7c05
add a couple of ICE testcases
...
Fixes #6250
Fixes #6251
Fixes #6252
Fixes #6255
Fixes #6256
2020-10-28 23:35:11 +01:00
bors
4f1240fd94
Auto merge of #6263 - matthiaskrgr:diff_u, r=ebroto
...
use diff -u in driver.sh test
this changs the add/delete indication from
>
>
<
to
+
+
-
(same as git diff)
changelog: none
2020-10-28 22:33:01 +00:00
Matthias Krüger
0d6eed1b1f
use diff -u in driver.sh test
...
this changs the add/delete indication from
>
>
<
to
+
+
-
(same as git diff)
2020-10-28 23:19:04 +01:00
bors
645ef505da
Auto merge of #6257 - giraffate:sync-from-rust, r=ebroto
...
Rustup
changelog: none
2020-10-28 21:53:23 +00:00
Eduardo Broto
e83e79f1c2
Reinstate link to temporary_cstr_as_ptr
2020-10-28 22:36:22 +01:00
Eduardo Broto
a50d9e7af6
Deprecate temporary_cstr_as_ptr
2020-10-28 22:34:45 +01:00
Takayuki Nakata
c42a22d2dc
Use double_neg.stderr
2020-10-29 01:02:09 +09:00
Takayuki Nakata
ffc2e66671
Fix reference
2020-10-28 14:36:29 +09:00
Takayuki Nakata
dace756c6f
cargo dev update_lints
2020-10-28 14:25:41 +09:00
Takayuki Nakata
8e988e1c66
Merge remote-tracking branch 'upstream/master' into sync-from-rust
2020-10-28 14:14:09 +09:00
Takayuki Nakata
4c58860cbf
Fix suggestion to add unneeded space in unused_unit
2020-10-28 12:40:47 +09:00
bors
de83f09be8
Auto merge of #6216 - alex-700:improve-match-like-matches-lint, r=ebroto
...
Improve match like matches lint
fixes #6186
changelog: improve MATCH_LIKE_MATCHES_MACRO lint
2020-10-27 23:01:35 +00:00
Aleksei Latyshev
2b7dd31368
improve MATCH_LIKE_MATCHES_MACRO lint
...
- add tests
- refactor match_same_arms lint
- prioritize match_expr_like_matches_macro over match_same_arms
2020-10-27 23:45:58 +03:00
Aleksei Latyshev
09e7053607
simplify SpanlessEq::eq_path_segment
2020-10-27 20:44:41 +03:00
Takayuki Nakata
8bd1e23167
Replace E-easy
with good first issue
in CONTRIBUTING.md
...
`E-easy` isn't used, so `good first issue` is more appropriate.
2020-10-27 23:34:50 +09:00
bors
8823684197
Auto merge of #6244 - mikerite:invalid_paths_20201027, r=flip1995
...
New internal lint: Invalid paths
Add a new internal lint that detects invalid paths in the `util::paths` and fix some invalid paths found.
This commit partially addresses #6047 but the lint would have to be run before running tests to close that issue.
changelog: none
2020-10-27 11:16:21 +00:00
Michael Wright
f79c4afd3a
Fix invalid paths
2020-10-27 07:43:38 +02:00
Michael Wright
66d56fefc5
Add invalid_paths
internal lint
2020-10-27 07:42:13 +02:00
Tim Nielens
111b9023da
add manual_ok_or lint
2020-10-27 01:57:04 +01:00
rail
e568a328f9
fix the error-causing suggestion of 'borrowed_box'
...
fix the error-causing suggestion of 'borrowed_box',
which missed parentheses and was ambiguous.
2020-10-27 12:11:09 +13:00
Nathan Whitaker
a1bb10e9b8
Remove lint from clippy
2020-10-26 18:19:48 -04:00
dvermd
6212950ceb
Explain why 'run-rustfix' is not defined
2020-10-26 23:00:10 +01:00
dvermd
8337c467e9
Change Applicability to MaybeIncorrect
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-26 22:34:43 +01:00
dvermd
ffddb669e0
clippy_lint: run after changing category to pendantic
2020-10-26 22:34:43 +01:00
dvermd
db40a07665
Update clippy_lints/src/ref_option_ref.rs
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-26 22:34:43 +01:00
dvermd
7fd74c6bf6
clippy_lint: Add Known Problems message
2020-10-26 22:34:43 +01:00
dvermd
1566db704d
Update clippy_lints/src/ref_option_ref.rs
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-26 22:34:43 +01:00
dvermd
8e26004a5f
Update clippy_lints/src/ref_option_ref.rs doctest
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-10-26 22:34:43 +01:00
dvermd
2270ff4d16
clippy_lint: Add test cases
2020-10-26 22:34:43 +01:00
dvermd
b41b38cb7f
clippy_lint: Refactor 'ref_option_ref'
2020-10-26 22:34:42 +01:00
dvermd
bdd76a9d1c
clippy_lint: Allow 'ref_option_ref' for 'option_if_let_else'
2020-10-26 22:34:42 +01:00
dvermd
c1f3bab6b1
clippy_lint: Add 'ref_option_ref' remove unused import
2020-10-26 22:34:42 +01:00
dvermd
469b2fc781
clippy_lint: Add 'ref_option_ref' move to check_ty and add type alias test
2020-10-26 22:34:42 +01:00
dvermd
d1baa25f04
clippy_lint: Add 'ref_option_ref' refactor code
2020-10-26 22:34:42 +01:00
dvermd
213dbf7aac
clippy_lint: Add 'ref_option_ref'
2020-10-26 22:34:40 +01:00
ThibsG
c0dd1f9f76
Fix tests for map_unwrap_or*
2020-10-26 11:15:01 +01:00
ThibsG
e2d86b5b80
Move fixable filter_next
and filter_map_next
cases to rustfixed tests
2020-10-26 11:02:07 +01:00
ThibsG
2a3ae11485
Move fixable map_unwrap_or
cases to rustfixed test
2020-10-26 11:02:07 +01:00