Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-22 11:03:16 +00:00
Code Issues Projects Releases Packages Wiki Activity
8101 commits 4 branches 212 tags 142 MiB
Commit graph

8101 commits

This branch
This branch
All branches
Author SHA1 Message Date
Rich Kadel
b4736b4d35 git attribute macros not allowed in submodules 
This change simply moves the `rust` macro definition directly into the
attributes for `*.rs` files.

git commands that recurse from the rust toplevel tree into submodules
produce errors in clippy due to the fact that:

  "Custom macro attributes can be defined only in top-level
  gitattributes files"

For example, from the toplevel `rust` directory in a rustc development
build, try:

  $ git grep "search string" --recurse-submodules

Embedded within the actual results is the error message:

  [attr]rust text eol=lf whitespace=tab-in-indent,trailing-space,tabwidth=4
   not allowed: src/tools/clippy/.gitattributes:1
 2020-03-29 06:58:37 -07:00
bors
ec5e9c7bbd Auto merge of #5381 - lzutao:itertools, r=matthiaskrgr 
Bump itertools

changelog: none
 2020-03-29 13:19:32 +00:00
Lzu Tao
d055b7d61c Deprecate REPLACE_CONSTS lint 2020-03-29 12:59:35 +07:00
Lzu Tao
53880a5bd6 Bump itertools 2020-03-29 12:50:11 +07:00
bors
70b93aab6e Auto merge of #5376 - flip1995:verbose_file_reads_restriction, r=matthiaskrgr 
Move verbose_file_reads to restriction

cc #5368

Using `File::read` instead of  `fs::read_to_end` does make sense in multiple cases, so this lint is rather restriction, than complexity

changelog: Move [`verbose_file_reads`] to restriction
 2020-03-27 20:13:06 +00:00
bors
64befe59cc Auto merge of #5377 - matthiaskrgr:rustup_38, r=flip1995 
rustup

changelog: none
 2020-03-27 19:57:44 +00:00
Matthias Krüger
0982097e4d remove redundant import 2020-03-27 20:47:34 +01:00
Matthias Krüger
48da6e926c rustup https://github.com/rust-lang/rust/pull/68404 2020-03-27 20:41:53 +01:00
Matthias Krüger
6b1bad54ef rustup https://github.com/rust-lang/rust/pull/69644 2020-03-27 20:41:51 +01:00
Matthias Krüger
8177e49e10 rustup https://github.com/rust-lang/rust/pull/70344 2020-03-27 20:41:35 +01:00
flip1995
7a40b5c132
Move verbose_file_reads to restriction 2020-03-26 15:01:03 +01:00
flip1995
aa1ad42736
Also deploy from the beta branch 2020-03-25 20:20:54 +01:00
flip1995
d7440a0d7c
Document how to backport changes to beta 2020-03-25 19:52:58 +01:00
flip1995
14534fa071
Document how to create a Clippy release 2020-03-25 19:52:58 +01:00
bors
2ff568d746 Auto merge of #5334 - flip1995:backport_remerge, r=flip1995 
Backport remerge

blocked on landing the backport

cc @ehuss

changelog: none
 2020-03-25 18:07:35 +00:00
bors
5de8c101e5 Auto merge of #5372 - matthiaskrgr:rpc_nursery, r=flip1995 
move redundant_pub_crate to nursery

cc #5369
changelog: none
 2020-03-25 17:21:15 +00:00
Matthias Krüger
b86e8434df move redundant_pub_crate to nursery 
cc #5369
 2020-03-25 18:14:11 +01:00
bors
d3e21fe690 Auto merge of #5371 - matthiaskrgr:rdm, r=phansch 
readme: explain how to run only a single lint on a codebase

changelog: none
 2020-03-25 10:50:38 +00:00
Matthias Krüger
b0de238b65 readme: explain how to run only a single lint on a codebase 2020-03-25 11:37:07 +01:00
bors
513b46793e Auto merge of #5370 - phansch:matches, r=matthiaskrgr 
Remove dependency on `matches` crate

The std equivalent works exactly the same.

changelog: none
 2020-03-25 07:38:00 +00:00
Philipp Hansch
cec1e8f74e
Remove dependency on matches crate 
The std equivalent works exactly the same.
 2020-03-25 07:50:08 +01:00
bors
100a24d9d8 Auto merge of #5364 - flip1995:useless_transmute_quarantine, r=Manishearth 
Move useless_transmute to nursery

cc #5343

@rust-lang/clippy anyone against moving this to nursery?

changelog: Move [`useless_transmute`] to nursery
 2020-03-23 20:52:57 +00:00
bors
d3989eef2d Auto merge of #5319 - 1tgr:master, r=flip1995 
Lint for `pub(crate)` items that are not crate visible due to the visibility of the module that contains them

changelog: Add `redundant_pub_crate` lint

Closes #5274.
 2020-03-23 20:35:49 +00:00
mgr-inz-rafal
ff9602515e Code clean-up and formatting 2020-03-23 21:21:18 +01:00
mgr-inz-rafal
3d3af07845 Provide appropriate suggestion 2020-03-23 21:00:02 +01:00
flip1995
13fcee51e7
Move useless_transmute to nursery 2020-03-23 20:32:04 +01:00
mgr-inz-rafal
12796cd688 Initial lint without suggestion 2020-03-23 20:29:12 +01:00
Tim Robinson
870b9e8139 nursery group -> style 2020-03-23 16:45:31 +00:00
bors
1ff81c1b6d Auto merge of #5350 - ThibsG:FixSingleBindingClosure, r=flip1995 
Fix single binding closure

Fix the `match_single_binding` lint when triggered inside a closure.

Fixes: #5347

changelog: Improve suggestion for [`match_single_binding`]
 2020-03-23 15:17:09 +00:00
bors
43bdee034f Auto merge of #5361 - matthiaskrgr:rustup_37, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69968/

changelog: none
 2020-03-23 14:41:57 +00:00
Matthias Krüger
0f319513d2 rustup https://github.com/rust-lang/rust/pull/69968/ 2020-03-23 15:21:46 +01:00
bors
89303daf6c Auto merge of #5353 - flip1995:conf_doc, r=Manishearth 
Fix documentation generation for configurable lints

In #5135, the configuration macro changed, but the documentation generation script wasn't updated. This PR catches up on this.

[Preview](https://flip1995.github.io/rust-clippy/master/index.html)

r? @Manishearth

changelog: Document configuration options of lints again.
 2020-03-22 18:54:58 +00:00
flip1995
a1dc609f21
Fix documentation generation for configurable lints 2020-03-22 18:15:06 +01:00
ThibsG
badfbbbbde Fix single binding in closure 2020-03-22 10:31:30 +01:00
Tim Robinson
de9092438d Update for PR feedback 2020-03-20 22:52:53 +00:00
bors
0e5e2c4365 Auto merge of #5323 - rabisg0:fix/5284, r=flip1995 
Improvement: Don't show function body in needless_lifetimes

Changes the span on which the lint is reported to point to only the
function return type instead of the entire function body.
Fixes #5284

changelog: none
 2020-03-20 12:45:30 +00:00
bors
d8e6e4cfcd Auto merge of #5342 - flip1995:rollup-77s2pmt, r=flip1995 
Rollup of 4 pull requests

Successful merges:

 - #5326 (rustup https://github.com/rust-lang/rust/pull/69838)
 - #5333 (rustup https://github.com/rust-lang/rust/pull/69189)
 - #5336 (rustup https://github.com/rust-lang/rust/pull/69920/)
 - #5341 (Rustup to rust-lang/rust#66131)

Failed merges:

r? @ghost

changelog: none
 2020-03-19 15:26:41 +00:00
flip1995
e4fc9316cd
Get integration test binary from deps dir 
cc rust-lang/cargo#7965
 2020-03-19 16:10:33 +01:00
Philipp Krones
606e3285b2
Rollup merge of #5341 - flip1995:rustup, r=flip1995 
Rustup to rust-lang/rust#66131

changelog: none
 2020-03-19 15:00:32 +01:00
Philipp Krones
a46675f229
Rollup merge of #5336 - matthiaskrgr:rustup_35, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69920/

changelog: none
 2020-03-19 15:00:31 +01:00
Philipp Krones
983d195bb5
Rollup merge of #5333 - matthiaskrgr:rustup_34, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69189

rustups https://github.com/rust-lang/rust/pull/69189 which is part of https://github.com/rust-lang/rust/pull/70085
(at least I think this is the only pr that changes clippy test stdout)

changelog: none
 2020-03-19 15:00:30 +01:00
Philipp Krones
027706630b
Rollup merge of #5326 - matthiaskrgr:rustup_33, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69838

changelog: none
 2020-03-19 15:00:29 +01:00
flip1995
21aeb21b8a
Rustup to rust-lang/rust#66131 2020-03-19 14:33:10 +01:00
Matthias Krüger
b9d6bf3bfb rustup https://github.com/rust-lang/rust/pull/69920/ 2020-03-19 09:14:53 +01:00
Rabi Guha
0812a0af4c Improvement: Don't show function body in needless_lifetimes 
Changes the span on which the lint is reported to point to only the
function return type instead of the entire function body.
Fixes #5284
 2020-03-19 12:03:02 +05:30
bors
c036c4f4a5 Auto merge of #5335 - flip1995:changelog, r=Manishearth 
Update changelog to 1.43.0 beta

In the beta changelog update, I accidentally used the commit of the 1.43.0 beta, instead of the 1.42.0 beta. I fixed this in this PR.

[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md)

r? @Manishearth

changelog: none
 2020-03-18 20:34:58 +00:00
bors
e004b9431d Auto merge of #5329 - matthiaskrgr:int_arith_on_ref_5328, r=flip1995 
integer_arithmetic: detect integer arithmetic on references.

changelog: integer_arithmetic fix false negatives with references on integers

Fixes #5328
 2020-03-18 14:56:05 +00:00
Matthias Krüger
ec1dcde46b tests: arithmetic: split into integer_arithmetic and float_arithmetic files. 2020-03-18 15:50:01 +01:00
bors
08fc39813f Auto merge of #5331 - matthiaskrgr:lint_docs1, r=flip1995 
clean up a few lint docs

changelog: none
 2020-03-18 14:34:34 +00:00
flip1995
f041dcdb4e
Fix limit-stderr-files test 2020-03-18 15:27:25 +01:00