Commit graph

13350 commits

Author SHA1 Message Date
Georg Brandl
6b589681c9 methods: allow multiple self kinds for "is_" methods
These can be static method predicates.  (Found one in rust-copperline,
called Term::is_unsupported_term().)
2015-09-02 17:14:27 +02:00
Georg Brandl
2e7496ae7c Merge pull request #283 from birkenfeld/wording
don't say "did you mean to" - use the standard "consider..."
2015-09-02 17:13:08 +02:00
Georg Brandl
846c164709 don't say "did you mean to" - use the standard "consider..."
"Did you mean to ..." sounds a bit condescending to me, since
if I meant to write "if let" I probably wouldn't have written "match" :)
2015-09-02 16:46:14 +02:00
llogiq
a9869e6fe4 Merge pull request #280 from Manishearth/fx-279
Only handle ranges starting with 0 for needless_range_loop (fixes #279)
2015-09-02 12:44:21 +02:00
Manish Goregaokar
73c34e12b3 Only handle ranges starting with 0 for needless_range_loop (fixes #279) 2015-09-02 16:11:54 +05:30
Manish Goregaokar
eb3b9b35da Merge pull request #276 from Manishearth/float_cmp
check item name for eq, fixes #268
2015-09-02 15:47:41 +05:30
llogiq
0c7f05dd76 check item name for eq, fixes #268 2015-09-02 10:30:11 +02:00
llogiq
2086f97bbd Merge pull request #275 from Manishearth/shadow
extended pattern matching
2015-09-02 08:56:12 +02:00
llogiq
0fb7d1d2d9 reporting improvements 2015-09-02 08:19:47 +02:00
llogiq
bc1eb84810 match region patterns 2015-09-02 07:56:13 +02:00
llogiq
683bffba08 Merge branch 'shadow' of https://github.com/Manishearth/rust-clippy into shadow 2015-09-02 07:55:30 +02:00
llogiq
1ab733cfa1 extended pattern matching 2015-09-02 07:55:07 +02:00
llogiq
e2e89bf800 extended pattern matching 2015-09-02 07:50:58 +02:00
llogiq
08fb953e1a extended pattern matching 2015-09-02 01:36:37 +02:00
Manish Goregaokar
91c3c97828 Merge pull request #274 from birkenfeld/copy_fix
methods: try to allow value self when type is Copy (fixes #273)
2015-09-02 01:24:42 +05:30
Georg Brandl
5264196538 methods: try to allow value self when type is Copy (fixes #273) 2015-09-01 21:08:49 +02:00
Manish Goregaokar
718da74c9f Merge pull request #272 from birkenfeld/conventions
new lint: self conventions for certain method names (fixes #267)
2015-09-01 22:25:19 +05:30
Georg Brandl
1007864198 new lint: self conventions for certain method names (fixes #267) 2015-09-01 18:52:48 +02:00
llogiq
77fcca00f0 Merge pull request #271 from birkenfeld/lint_groups
lib: add clippy_pedantic group with all Allow by default lints (fixes #265)
2015-09-01 18:24:33 +02:00
Georg Brandl
88dd38de87 lib: add clippy_pedantic group with all Allow by default lints (fixes #265) 2015-09-01 18:05:28 +02:00
llogiq
2abc5ab97c Merge pull request #270 from jedisct1/nightly
Yet another fix for rust-nightly
2015-09-01 14:54:21 +02:00
Frank Denis
833493cf07 FnKind::FkClosure -> FnKind::Closure 2015-09-01 14:28:23 +02:00
Manish Goregaokar
d3da9f6c81 Merge branch 'pr-260'
Conflicts:
	src/lib.rs
2015-08-31 15:06:53 +05:30
llogiq
994124521e Merge pull request #264 from birkenfeld/fix2
lifetimes lint: walk type bounds as well as types (fixes #253, again)
2015-08-31 11:32:33 +02:00
Georg Brandl
e33bef685e lifetimes lint: walk type bounds as well as types (fixes #253, again) 2015-08-31 11:26:41 +02:00
llogiq
9d49cc5167 Merge pull request #263 from birkenfeld/fix
fix for #261
2015-08-31 08:53:56 +02:00
Georg Brandl
0217fb81ee loops: fix false positives with explicit_iter_loop and references (fixes #261) 2015-08-31 08:29:40 +02:00
Georg Brandl
d499d2a9a7 loops: remove debugging print 2015-08-31 08:20:39 +02:00
llogiq
614ba3ab86 Merge pull request #255 from TimNN/precedence-negative-literal
add precedence_negative_literal lint
2015-08-30 19:32:44 +02:00
Georg Brandl
03abe275b2 new lint: unnecessary patterns (x@_ -> x) 2015-08-30 19:02:30 +02:00
Tim Neumann
ef0c933550 add precedence_negative_literal lint 2015-08-30 17:34:48 +02:00
llogiq
298728ed65 Merge pull request #258 from birkenfeld/collect-exhaust
new lint: using collect() to just exhaust an iterator
2015-08-30 15:26:35 +02:00
Georg Brandl
16df79a054 new lint: using collect() to just exhaust an iterator
Should use a for loop instead.
2015-08-30 13:10:59 +02:00
Georg Brandl
b72ef5a173 new lint: loop-match-break, which could be while-let (fixes #118) 2015-08-30 12:40:39 +02:00
llogiq
92563a9970 Merge pull request #254 from birkenfeld/lifetimes-where
lifetimes lint: take "where" clauses into account (fixes #253)
2015-08-30 12:07:57 +02:00
Georg Brandl
6461fb3308 lifetimes lint: take "where" clauses into account (fixes #253)
If a where clause is present and has lifetimes mentioned, just bail out.
2015-08-30 09:58:26 +02:00
llogiq
e340584cd8 Merge pull request #248 from Manishearth/rustup
rustup
2015-08-28 14:39:09 +02:00
llogiq
621818e606 rustup, the ExpnInfo stuff changed 2015-08-28 14:35:20 +02:00
Manish Goregaokar
2606f34bcb Merge pull request #247 from Manishearth/links
added the rest of the link help messages
2015-08-28 01:43:53 +05:30
llogiq
e0816e7959 Merge branch 'master' of https://github.com/Manishearth/rust-clippy into links 2015-08-27 15:53:07 +02:00
Manish Goregaokar
c3d4eb5bbd Merge branch 'pr-228'
Conflicts:
	README.md
	src/methods.rs
2015-08-27 15:25:56 +02:00
Manish Goregaokar
193e71be61 Merge branch 'pr-228'
Conflicts:
	README.md
	src/methods.rs
2015-08-27 11:09:40 +05:30
llogiq
ac8ab4eb8e Merge pull request #246 from Manishearth/macro
Improve macro checks
2015-08-27 05:27:53 +02:00
Manish Goregaokar
5159e034a6 appease the dogfood gods 2015-08-27 04:40:01 +05:30
Manish Goregaokar
9ebcd0bf29 More macro checks 2015-08-27 04:33:59 +05:30
Manish Goregaokar
7a1082d916 Merge pull request #239 from jedisct1/nightly
Changes for rust-nightly after #27856
2015-08-27 03:44:30 +05:30
Manish Goregaokar
b29a60226b Merge pull request #242 from Manishearth/autolink
Added automatic links to wiki for all lints.
2015-08-26 23:21:03 +05:30
llogiq
297d09906d Merge pull request #245 from birkenfeld/eta_unsafe
eta_reduction: fix false positive for unsafe fns (fixes #243)
2015-08-26 17:12:50 +02:00
Georg Brandl
bb552dc96f eta_reduction: fix false positive for unsafe fns (fixes #243) 2015-08-26 17:09:51 +02:00
llogiq
9461a480bd Added automatic links to wiki for all lints. 2015-08-26 16:04:50 +02:00