flip1995
eadd9d24dc
Don't trigger while_let_on_iterator when the iterator is recreated every iteration
2020-04-25 20:51:02 +02:00
bors
6ffe725bbc
Auto merge of #5520 - matthiaskrgr:rustup_44, r=flip1995,phansch
...
rustup https://github.com/rust-lang/rust/pull/71215/
There's currently an crash in `ui/new_without_default.rs` that I need to figure out how to avoid.
changelog: none
2020-04-25 18:18:32 +00:00
flip1995
dda1c8d8af
Update issue_2356.stderr reference file
2020-04-25 20:11:15 +02:00
flip1995
44511d5ee6
Update while_let_on_iterator tests
2020-04-25 20:11:15 +02:00
flip1995
fe25dbe549
Fix while_let_on_iterator suggestion and make it MachineApplicable
2020-04-25 20:00:00 +02:00
Philipp Hansch
bf73d51959
Add lifetime test case for new_ret_no_self
2020-04-25 10:43:41 +02:00
CrazyRoka
63b451ea25
Renamed lint to match_on_vec_items
2020-04-25 11:34:16 +03:00
CrazyRoka
b0115fb996
Removed unnecessary code, added support for vector references
2020-04-25 00:52:02 +03:00
CrazyRoka
96e2bc80f5
Added lint match_vec_item
2020-04-24 22:45:15 +03:00
Matthias Krüger
f9c1acbc45
rustup https://github.com/rust-lang/rust/pull/71215/
2020-04-24 15:29:31 +02:00
David Tolnay
ef28361293
Downgrade match_bool to pedantic
2020-04-23 16:30:06 -07:00
flip1995
451badeddf
Run fetch before testing if master contains beta
2020-04-23 23:25:35 +02:00
flip1995
c19ca0e8a8
The beta branch update should not require a force push
2020-04-23 23:25:35 +02:00
flip1995
4619bb243d
Add a note to the beta sections of release.md
2020-04-23 23:25:35 +02:00
bors
02c94352d4
Auto merge of #5513 - matthiaskrgr:reg, r=phansch
...
fix clippy_dev exit status and make regex match again
changelog: none
Fixes #5510
r? @phansch
2020-04-23 20:56:15 +00:00
flip1995
0476e8b483
Remove apt-get upgrade again
2020-04-23 21:14:45 +02:00
flip1995
35ef280b55
Always use the deploy script and templates of the master branch
2020-04-23 21:14:35 +02:00
bors
a609a9eb79
Auto merge of #5498 - phansch:update_changelog, r=flip1995
...
Update CHANGELOG.md for Rust 1.43 and 1.44
[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog/CHANGELOG.md )
changelog: none
2020-04-23 18:35:22 +00:00
Matthias Krüger
081641249e
README: fix lit count line
...
It looks like after changing to "there are more than 120 lints", an older PR was merged
and resolving merge conflicts this was changed back to "there are 123 lints" causing the update-script to silently fail.
Changed back the README.md back to the new format fixes the problem.
2020-04-23 16:11:18 +02:00
Matthias Krüger
d021d3ef88
clippy_dev: make it fatal when the regex for updating lint count does not match
...
Fixes #5510
2020-04-23 16:11:11 +02:00
bors
d01a49810b
Auto merge of #5508 - lzutao:rustup-71044, r=phansch
...
Rustup "Remove `BodyAndCache`"
cc https://github.com/rust-lang/rust/pull/71044
changelog: none
2020-04-23 05:08:29 +00:00
lzutao
3f6f392730
predecessors_for
will be removed soon
...
Co-Authored-By: ecstatic-morse <ecstaticmorse@gmail.com>
2020-04-23 09:09:09 +07:00
Lzu Tao
9ef9b7946f
Rustup "Remove BodyAndCache
"
2020-04-23 08:39:35 +07:00
flip1995
f31502f4bb
Only run (late) internal lints, when they are warn/deny/forbid
2020-04-22 20:51:58 +02:00
flip1995
14f596cb74
Only run cargo lints, when they are warn/deny/forbid
2020-04-22 20:32:37 +02:00
bors
1d4dd3d428
Auto merge of #5439 - rokob:lock-await, r=Manishearth
...
Lint for holding locks across await points
Fixes #4226
This introduces the lint await_holding_lock. For async functions, we iterate
over all types in generator_interior_types and look for types named MutexGuard,
RwLockReadGuard, or RwLockWriteGuard. If we find one then we emit a lint.
changelog: introduce the await_holding_lock lint
2020-04-22 15:50:32 +00:00
Andy Weiss
8b052d3142
span_lint_and_note now takes an Option<Span> for the note_span instead of just a span
2020-04-21 21:28:23 -07:00
Andy Weiss
d6e55e97ff
Make lint also capture blocks and closures, adjust language to mention other mutex types
2020-04-21 21:07:43 -07:00
Andy Weiss
54e7f7e5f2
don't test the code in the lint docs
2020-04-21 21:07:43 -07:00
Andy Weiss
2dc8c083f5
Switch to matching against full paths instead of just the last element of the path
2020-04-21 21:07:43 -07:00
Andy Weiss
6c25c3c381
Lint for holding locks across await points
...
Fixes #4226
This introduces the lint await_holding_lock. For async functions, we iterate
over all types in generator_interior_types and look for types named MutexGuard,
RwLockReadGuard, or RwLockWriteGuard. If we find one then we emit a lint.
2020-04-21 21:07:43 -07:00
Philipp Hansch
30c28a796d
Also mention --fix
for nightly users
2020-04-21 07:06:44 +02:00
bors
b3cb9b8376
Auto merge of #5499 - matthiaskrgr:crash_5497, r=flip1995
...
fix crash on issue-69020-assoc-const-arith-overflow.rs
Fixes #5497
changelog: fix crash on rustc test issue-69020-assoc-const-arith-overflow.rs
2020-04-20 23:54:15 +00:00
Matthias Krüger
7221db2dc3
fix crash on issue-69020-assoc-const-arith-overflow.rs
...
Fixes #5497
2020-04-20 23:01:34 +02:00
bors
6507728f23
Auto merge of #5496 - phansch:markdown-link, r=flip1995
...
util/fetch_prs_between.sh: Add Markdown formatted link
This can then be easily copy/pasted into the changelog 💙
changelog: none
2020-04-20 21:00:25 +00:00
Philipp Hansch
803670eeb2
Address review comments
2020-04-20 22:53:00 +02:00
bors
ef6ba82fee
Auto merge of #5495 - phansch:update_changelog_docs, r=flip1995
...
Update the changelog update documentation
I just started working on updating the changelog. Hopefully the docs are a bit clearer now?
r? @flip1995
changelog: none
2020-04-20 20:40:45 +00:00
Philipp Hansch
ca59ff2031
remark fixes
2020-04-20 22:29:27 +02:00
Philipp Hansch
4e63faa6df
Update CHANGELOG.md for Rust 1.43 and 1.44
2020-04-20 22:22:05 +02:00
bors
6ce05bf849
Auto merge of #5332 - DevinR528:if-let-else-mutex, r=flip1995
...
If let else mutex
changelog: Adds lint to catch incorrect use of `Mutex::lock` in `if let` expressions with lock calls in any of the blocks.
closes : #5219
2020-04-20 20:21:33 +00:00
Devin R
3fbe321440
update stderr file
2020-04-20 15:47:08 -04:00
Philipp Hansch
90d8b6354e
util/fetch_prs_between.sh: Add Markdown formatted Link
...
This can then be easily copy/pasted into the changelog 💙
2020-04-20 21:08:55 +02:00
Devin R
489dd2e504
factor ifs into function, add differing mutex test
2020-04-20 15:08:44 -04:00
Philipp Hansch
2141db84eb
Update the changelog update documentation
2020-04-20 20:39:49 +02:00
bors
1336558818
Auto merge of #5493 - ebroto:unsafe_derive_deserialize, r=flip1995
...
Implement unsafe_derive_deserialize lint
Added `unsafe_derive_deserialize` lint to check for cases when automatically deriving `serde::Deserialize` can be problematic, i.e. with types that have methods using `unsafe`.
Closes #5471
changelog: Add lint [`unsafe_derive_deserialize`]
2020-04-20 18:29:00 +00:00
Eduardo Broto
b7f85e8706
Apply suggestions from PR review
...
* Move the lint to pedantic
* Import used types instead of prefixing with `hir::`
2020-04-20 20:05:15 +02:00
Devin R
d1b1a4c5eb
update span_lint_and_help call to six args
2020-04-20 06:49:59 -04:00
Devin R
a9f1bb43ef
test for mutex eq, add another test case
2020-04-20 06:30:01 -04:00
Devin R
ae820924c4
use if chain
2020-04-20 06:30:01 -04:00
Devin R
4cebe2bf84
cargo dev fmt
2020-04-20 06:30:01 -04:00