Commit graph

4603 commits

Author SHA1 Message Date
Philipp Hansch
37ba42b7bc
Merge pull request #3235 from matthiaskrgr/rustc_tools__beta_fix
rustc_tools_util: don't require test feature.
2018-09-29 19:33:21 +01:00
Matthias Krüger
34693c0d6d rustc_tools_util: remove test and tool_lints features, both are actually unused.
Fixes build with beta.
2018-09-29 19:34:38 +02:00
Philipp Krones
4cb16e619f
Merge pull request #3238 from JoshMcguigan/excessive_precision-3180
Fixes #3180, suppress excessive_precision lint for floats with no decimal part
2018-09-29 17:46:15 +02:00
Josh Mcguigan
e25f884e6f Fixes #3180, suppress excessive_precision lint for floats with no decimal part 2018-09-29 07:39:30 -07:00
Michael Wright
c2ee9c29ab Merge branch 'master' into unnecessary_filter_map 2018-09-29 15:27:47 +02:00
Michael Wright
06f6b36025 rustfmt 2018-09-29 14:18:50 +02:00
Michael Wright
efdc739dfc Move unnecessary_filter_map to a submodule 2018-09-29 14:12:40 +02:00
Michael Wright
db5c63b77a Move tests into separate file 2018-09-29 13:57:04 +02:00
Philipp Krones
67d85bc47d
Merge pull request #3224 from matthiaskrgr/clippy_self__use_self
fix some clippy::pedantic warnings found in the codebase.
2018-09-28 15:26:50 +02:00
Philipp Hansch
8e808664fa
Merge pull request #3178 from ms2300/bad_unwrap
Fix for bad get unwrap suggestion
2018-09-28 07:38:00 +01:00
Philipp Hansch
6b17ce4267
Merge pull request #3227 from matthiaskrgr/cargo_lock
consistently gitignore all Cargo.lock files
2018-09-28 07:24:51 +01:00
Matthias Krüger
e7b820d626 consistently gitignore all Cargo.lock files 2018-09-27 12:34:16 +02:00
Michael Wright
4b4d758ce0 Fix warnings in clippy_lints 2018-09-27 06:29:48 +02:00
Michael Wright
2f364d9ac5 Merge branch 'master' into unnecessary_filter_map 2018-09-27 06:12:01 +02:00
Matthias Krüger
9fae4693f9 fix clippy::single-match-else and clippy::match_same_arms warnings in clippys codebase 2018-09-26 22:25:01 +02:00
Matthias Krüger
2a31937cc9 fix all clippy::use_self pedantic warnings found in the codebase.
cc #3172
2018-09-26 22:24:18 +02:00
Philipp Hansch
a72e786c5d
Merge pull request #3226 from matthiaskrgr/rustup_smallvec
rustup
2018-09-26 17:48:43 +01:00
Philipp Hansch
66afff9642
Merge pull request #3225 from matthiaskrgr/dogfood
tests: dogfood: extend to run with --all-features and clippy::internal enabled.
2018-09-26 17:47:51 +01:00
Matthias Krüger
fc35c20a0a rustup
fix breakage by https://github.com/rust-lang/rust/pull/53824

use smallvec crate instead of rustcs type alias.
2018-09-26 15:57:38 +02:00
Matthias Krüger
41d3df7321 tests: dogfood: extend to run with --all-features and clippy::internal enabled.
Run it on rustc_tools_util and clippy_dev as well.
2018-09-26 12:32:20 +02:00
Michael Wright
f5ffac4fce Implement unnecesary_filter_map lint 2018-09-26 06:52:36 +02:00
Manish Goregaokar
cdde22c2cc
Merge pull request #3218 from Hanaasagi/fix-travis-yaml-demo
fix invalid travis-yaml in README
2018-09-25 07:05:32 -07:00
Hanaasagi
2b4d9d55b8 fix invalid travis-yaml in README 2018-09-25 22:40:17 +09:00
Philipp Krones
e3f7b40b03
Merge pull request #3203 from yaahallo/master
Lint for chaining flatten after map
2018-09-25 12:54:48 +02:00
Philipp Hansch
1be78b90ac
Merge pull request #3212 from matthiaskrgr/clippy_dev_ed2018
clippy_dev: port to edition 2018
2018-09-25 07:27:12 +01:00
Jane Lusby
14feb3670f Lint for chaining flatten after map
This change adds a lint to check for instances of `map(..).flatten()`
that can be trivially shortened to `flat_map(..)`

Closes #3196
2018-09-24 14:29:16 -07:00
mikerite
417cf206ca
Merge pull request #3213 from mikerite/fix-3204
Fix single_char_pattern crash (#3204)
2018-09-24 09:11:32 +02:00
Michael Wright
ab71f08663 Fix single_char_pattern crash (#3204)
This commit fixes the crash by removing constant checking from the lint.

Closes #3204.
2018-09-24 08:33:57 +02:00
ms2300
523ba2a009 Full fix of get unwrap issue 2018-09-23 19:53:25 -07:00
ms2300
de8d233b06 #3006 : Fixing for .get().unwrap().foo() 2018-09-23 19:53:25 -07:00
Philipp Krones
bc6d85ceaf
Merge pull request #3207 from mikerite/fix-3206
Fix double_parens false positive
2018-09-23 18:24:27 +02:00
Philipp Krones
af2d6a0c14
Merge pull request #3191 from vi/suggest_with_applicability
Use span_suggestion_with_applicability instead of span_suggestion
2018-09-23 15:45:55 +02:00
Matthias Krüger
f2ecee3638 clippy_dev: port to edition 2018 2018-09-23 14:44:06 +02:00
Philipp Krones
b5c4342ef9
Merge pull request #3195 from JayKickliter/jsk/mem_replace_opt_w_none
Add lint for `mem::replace(.., None)`.
2018-09-23 10:23:48 +02:00
Manish Goregaokar
8e9f1a9d68
Mention rustup self update (fixes #3211) 2018-09-22 14:35:11 -07:00
Michael Wright
867ac98d38 Fix double_parens false positive
Closes #3206
2018-09-22 17:20:34 +02:00
flip1995
987b34d090
Another Applicability adjustment 2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela
52fb7d461e
Applicability adjustment per additional comments 2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela
58729346be
Fill in Applicability from review comments by @flip1995 2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela
3eccccb367
Fix indents 2018-09-20 14:38:48 +02:00
Vitaly _Vi Shukela
2781cac839
Apply subset of "cargo fmt". 2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela
3e853a632e
Add forgotten function: span_suggestion*s* to the previous refactoting 2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela
d4c994e670
Supplement DiagnosticBuilderExt with Applicability 2018-09-20 14:38:47 +02:00
Vitaly _Vi Shukela
92034e20c8
Use span_suggestion_with_applicability instead of span_suggestion 2018-09-20 14:38:47 +02:00
Philipp Hansch
c0c770c60b
Merge pull request #3201 from phansch/rust_master_in_contributing_docs
Mention how to install master Rust in CONTRIBUTING
2018-09-20 09:37:39 +01:00
Philipp Hansch
f72cfc2985
Mention rustup component history 2018-09-20 07:10:23 +02:00
Philipp Hansch
2b57cec649
s/rustc/Rust/ 2018-09-20 06:58:07 +02:00
Philipp Hansch
f9511bfdc3
s/rust/Rust, repeat 'Clippy' less 2018-09-20 06:56:51 +02:00
Jay Kickliter
79cda3bb1e mem_replace: fix grammar. 2018-09-19 14:54:38 -07:00
Jay Kickliter
2f53aaa5bd mem_replace: match on path. 2018-09-19 14:41:22 -07:00